aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Stop calling "super" twice in Rails::Server#appCarlos Antonio da Silva2013-03-121-1/+4
| | | | | | | | | | | | Cache the value of "super" in a variable and use it instead.
* | | Remove manual "return true" from AS::TZ match methodCarlos Antonio da Silva2013-03-121-1/+1
| | |
* | | Merge pull request #9676 from neerajdotname/9567-destroy-should-call-destroy-allRafael Mendonça França2013-03-121-2/+3
|\ \ \ | |/ / |/| | dependent: :destroy should call destroy_all
| * | dependent: :destroy should call destroy_allNeeraj Singh2013-03-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit https://github.com/rails/rails/pull/9668 shows warning when `delete_all` is invoked with `:dependent` option `:destroy`. Unfortunately invoking `Post.destroy_all` invokes `post.comments.delete_all` as part of `has_many` callbacks. This commit ensures that instead `post.comments.destroy_all` is invoked and in the process no warning is generated. See issue #9567 for details .
* | | Merge pull request #9615 from mmb/copy_table_binary_sqliteCarlos Antonio da Silva2013-03-123-2/+23
|\ \ \ | | | | | | | | | | | | | | | | Pass column to quote when copying a sqlite table. To make quote escape binary data correctly it needs the column passed in.
| * | | Pass column to quote when copying a sqlite table.Matthew M. Boedicker2013-03-113-2/+23
| | |/ | |/| | | | | | | To make quote escape binary data correctly it needs the column passed in.
* | | Merge pull request #9681 from vipulnsward/fix_typo_in_module_nameCarlos Antonio da Silva2013-03-124-7/+7
|\ \ \ | |/ / |/| | Fix typo in DependenciesTestHelpers module name
| * | Fix typo in DependenciesTestHelpers module nameVipul A M2013-03-124-7/+7
| | |
* | | Fix typo [ci skip]Carlos Antonio da Silva2013-03-111-1/+1
| |/ |/|
* | promotes change_column_null to the migrations APIXavier Noria2013-03-112-0/+27
| |
* | quick pass over the RDoc of schema_statements.rb [ci skip]Xavier Noria2013-03-111-122/+190
| |
* | documents how to DROP DEFAULT [ci skip]Xavier Noria2013-03-111-3/+7
| |
* | Merge pull request #9668 from neerajdotname/9567-delete-all-warningXavier Noria2013-03-111-0/+9
|\ \ | | | | | | Show warning message if delete_all is firing callbacks
| * | Show warning message if delete_all is firing callbacksNeeraj Singh2013-03-111-0/+9
| | | | | | | | | | | | | | | | | | `post.comments.delete_all` will fire callbacks if :dependent option is :destroy . It will be fixed in Rails 4.1 . In the meantime display a warning . Look at #9567 for details .
* | | Replace assert_(no_)match args from regexps to strings to remove warningsCarlos Antonio da Silva2013-03-111-40/+40
| | | | | | | | | | | | | | | | | | Using regexps as arguments without parentheses end up raising: warning: ambiguous first argument; put parentheses or even spaces
* | | Skip fetching path if the iteration is going to be skippedCarlos Antonio da Silva2013-03-111-2/+2
| | |
* | | There's no need to install test group in travisSantiago Pastorino2013-03-112-2/+2
| | |
* | | Move benchmark-ips to test groupSantiago Pastorino2013-03-111-2/+2
| | |
* | | Use platforms instead of conditionals in GemfileSantiago Pastorino2013-03-111-4/+7
| | |
* | | Merge pull request #9666 from sikachu/master-fix-test_test_failureRafael Mendonça França2013-03-111-1/+17
|\ \ \ | | | | | | | | Make sure that the test case is run under test env
| * | | Make sure that the test case is run under test envPrem Sichanugrist2013-03-111-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | * Unset $RAILS_ENV that got set by abstract_unit to trigger the default. * split out environment setting since Ruby 1.9.3 doesn't support inline ENV setting.
* | | | Mention that debugging can be slow.Steve Klabnik2013-03-111-0/+2
|/ / / | | | | | | | | | | | | | | | https://github.com/rails/rails/pull/3180\#issuecomment-14705821 has mention of rendering going from 1-2ms to 4 seconds with this on, which seems reasonable: debugging is slow.
* | | default the reaping frequency to 10 secondsAaron Patterson2013-03-111-1/+1
| | |
* | | debugger does not work on trunkAaron Patterson2013-03-111-1/+1
|/ /
* | Merge pull request #9664 from sikachu/master-fix-test_test_failureAndrew White2013-03-111-5/+3
|\ \ | | | | | | Fix test failure introduced in 3ed41e57
| * | Fix test failure introduced in 3ed41e57Prem Sichanugrist2013-03-111-5/+3
|/ / | | | | | | I forgot to run the test suit after changing the task name. :bomb:
* | Merge pull request #9080 from sikachu/master-rails-testRafael Mendonça França2013-03-118-132/+591
|\ \ | | | | | | Add `rails test` command to run the test suite
| * | Make sure that `rails test` load test in test envPrem Sichanugrist2013-03-094-7/+55
| | |
| * | Update Rake tasks to call `rails test` insteadPrem Sichanugrist2013-03-092-62/+41
| | | | | | | | | | | | | | | Also, print out deprecation warning for other rake tasks except `rake test` and `rake` (default)
| * | Improve wording for rails test commandDalibor Nasevic2013-03-095-39/+41
| | |
| * | Load fixtures only when running suites, or `-f`Prem Sichanugrist2013-03-094-3/+80
| | | | | | | | | | | | | | | | | | * `rails test -f` will run the test suites with all fixtures loaded * New application will now generated without `fixtures :all` line enabled by default.
| * | Add support for MiniTest flags in TestRunnerPrem Sichanugrist2013-03-094-59/+93
| | | | | | | | | | | | | | | Any flags that got set will be passed through to MiniTest::Unit.runner, such as `-n`, `-s-, and `-v`.
| * | Update testing documentationPrem Sichanugrist2013-03-091-63/+71
| | | | | | | | | | | | | | | | | | | | | * Update test invocation to use `rails test` instead. * Update all the test command previews (since we're now using MiniTest.) * Mentioning MiniTest instead of Test::Unit. * Update list of test suites.
| * | Add `rails test` command to run the test suitePrem Sichanugrist and Chris Toomey2013-03-094-0/+311
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To run the whole test suite: $ rails test To run the test file(s): $ rails test test/unit/foo_test.rb [test/unit/bar_test.rb ...] To run the test suite $ rails test [models,helpers,units,controllers,mailers,...] For more information, see `rails test --help`. This command will eventually replacing `rake test:*`, and `rake test` command will actually invoking `rails test` instead.
* | | Merge pull request #9657 from vipulnsward/cleanup_testsRafael Mendonça França2013-03-113-4/+2
|\ \ \ | | | | | | | | Cleanup tests for unused variables
| * | | Cleanup tests for unused variablesVipul A M2013-03-113-4/+2
| | |/ | |/|
* | | Merge pull request #9658 from ↵Rafael Mendonça França2013-03-111-0/+1
|\ \ \ | |/ / |/| | | | | | | | tkhr/add-assert-to-test_company_descends_from_active_record add an missing assertion to inheritance_test.rb
| * | add an missing assertion to inheritance_test.rbTakehiro Adachi2013-03-111-0/+1
|/ / | | | | | | | | | | assertion for https://github.com/rails/rails/blob/ad624345e54bd20802de67b2b5c9ef29ecf5 d5f4/activerecord/lib/active_record/inheritance.rb#L32
* | Merge pull request #9653 from jetthoughts/masterCarlos Antonio da Silva2013-03-101-5/+5
|\ \ | | | | | | | | | | | | | | | | | | Fixed tests `to_time` returning an instance of `Time` in the local system timezone. Tests for to_time returning an instance of Time in the local system timezone did not take in account DST when they used mixed timezone declarations like 'US/Eastern' and '-0500'. Replaced timezone with DST by timezone without DST.
| * | Fixed tests for returning an instance of `Time` in the local system timezone.Paul Nikitochkin2013-03-101-5/+5
| | |
* | | Merge pull request #9651 from vipulnsward/change_to_each_value_intestCarlos Antonio da Silva2013-03-101-1/+1
|\ \ \ | | | | | | | | Change from each to each_value on hash to avoid unused variable warning
| * | | Change from each to each_value on hash to avoid unused variable warningVipul A M2013-03-111-1/+1
| | | |
* | | | Merge pull request #9650 from yahonda/group_by_oracleRafael Mendonça França2013-03-101-2/+2
|\ \ \ \ | |_|/ / |/| | | Address ActiveRecord::StatementInvalid: OCIError: ORA-00979
| * | | Address ActiveRecord::StatementInvalid: OCIError: ORA-00979Yasuo Honda2013-03-111-2/+2
| |/ /
* | | Merge pull request #9645 from senny/9643_habtm_wrong_table_nameCarlos Antonio da Silva2013-03-101-0/+2
|\ \ \ | |/ / |/| | document habtm join-table name with custom prefix [ci skip]
| * | document habtm join-table name with custom prefix [ci skip].Yves Senn2013-03-101-0/+2
|/ / | | | | | | | | | | Closes #9643. The logic was introduced with 46492949
* | Merge pull request #9638 from siong1987/debuggerCarlos Antonio da Silva2013-03-091-1/+1
|\ \ | | | | | | Make sure that debugger isn't included in production environment.
| * | Make sure that debugger isn't included in production environment.Teng Siong Ong2013-03-091-1/+1
|/ /
* | Change uniq validation with conditions examples to use where with hashesCarlos Antonio da Silva2013-03-092-5/+5
| | | | | | | | Take the opportunity to showcase where.not.
* | Merge pull request #9637 from GSI/masterCarlos Antonio da Silva2013-03-091-0/+1
|\ \ | | | | | | Include Montevideo time zone in list of aliases. Closes #9628