aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | changed default value of `caching` option to `nil`yuuji.yaginuma2016-03-212-2/+3
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | The default is that's false, caching even if you do not specify the caching option is determined not to use, and `tmp/caching-dev.txt` will be deleted. If it is this, regardless of whether or not there is `tmp/caching-dev.txt`, be sure to order would be necessary to specify the caching option, I think that in than good to so as not to do anything by default.
* | | | | Merge pull request #24243 from dewski/dont-upgrade-file-watcherArthur Neves2016-03-212-0/+19
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Comment out config.file_watcher during Rails upgrade process
| * | | | | Add tests for file_watcher config on updateArthur Neves2016-03-211-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | [related #24243]
| * | | | | Don't upgrade config.file_watcher during upgrade pathGarrett Bjerkhoel2016-03-181-0/+5
| | | | | |
* | | | | | Fix generator test to match to use the stringRafael Mendonça França2016-03-212-2/+2
| | | | | |
* | | | | | Merge pull request #24231 from hallmatt/masterRafael Mendonça França2016-03-211-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | switched layout :mailer to a string so that mail layout can be properly sent
| * | | | | | switched layout :mailer to a string so that mail layout can be properly ↵Matt Hall2016-03-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | found and mail can be delivered properly
* | | | | | | Keep all session tests in the same fileRafael Mendonça França2016-03-212-46/+28
| | | | | | |
* | | | | | | Merge pull request #24229 from maclover7/fix-24222Rafael Mendonça França2016-03-213-1/+51
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | Fix request.reset_session for API controllers
| * | | | | | Fix request.reset_session for API controllersJon Moss2016-03-193-1/+51
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to that `ActionDispatch::Flash` (the flash API's middleware) is not included for API controllers, the `request.reset_session` method, which relies on there being a `flash=` method which is in fact defined by the middleware, was previously breaking. Similarly to how add46482a540b33184f3011c5c307f4b8e90c9cc created a method to be overridden by the flash middleware in order to ensure non-breakage, this is how flashes are now reset. Fixes #24222
* | | | | | Merge pull request #24244 from bronson/asset-pipeline-docJon Moss2016-03-181-7/+3
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | remove Rails 4 text from asset pipeline guide
| * | | | | remove Rails 4 text from asset pipeline guideScott Bronson2016-03-181-7/+3
|/ / / / /
* | | | | Merge pull request #22518 from ↵Arthur Nogueira Neves2016-03-182-1/+18
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | RochesterinNYC/better-error-message-for-includes-relations-missing Improve error message for missing relations for includes and eager_load
| * | | | | Improve clarity of error message for missing includes and eager_loadJames Wen2016-01-282-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | relations
* | | | | | Merge pull request #24223 from mechanicles/reserved-keys-testsEileen M. Uchitelle2016-03-181-6/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | Added more tests for reserved hash keys of ActiveJob::Arguments.
| * | | | | | Added more tests for reserved hash keys of ActiveJob::Arguments.Santosh Wadghule2016-03-171-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Added tests for checking all reserved hash keys of ActiveJob::Arguments. - Moved unrelated code from the test to the correct place, i.e. newly created test.
* | | | | | | Merge pull request #24226 from mabras/masterXavier Noria2016-03-181-0/+0
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | use rails 5 favicon.ico for rails guides [ci skip]
| * | | | | | use rails 5 favicon.ico for rails guidesMohamad Abras2016-03-171-0/+0
| | |_|/ / / | |/| | | |
* / | | | | Evented Redis adapter: log reconnect failures as errors, not just infoJeremy Daer2016-03-171-1/+1
|/ / / / / | | | | | | | | | | | | | | | [ci skip]
* | | | | Merge pull request #24218 from schneems/schneems/match-loggerRichard Schneeman2016-03-172-10/+26
|\ \ \ \ \ | | | | | | | | | | | | Document and Match the Rails logger interface
| * | | | | Document and Match the Rails logger interfaceschneems2016-03-162-10/+26
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | The logger interface to get all Rails features is not obvious. This change adds documentation on how to assign a logger that will use all Rails features. We are also matching the stdout logging interface to the default logger in bootstrap https://github.com/rails/rails/blob/f5a5988352b165143f0f9d622707c351c1470882/railties/lib/rails/application/bootstrap.rb#L42-L45.
* | | | | Merge pull request #24201 from rails/rake-db-createRafael França2016-03-173-10/+17
|\ \ \ \ \ | |/ / / / |/| | | | Creates development and test databases in db:migrate task
| * | | | Creates development and test databases in db:migrate taskRafael Mendonça França2016-03-143-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts a334425caff9b2140d5e99fcfc2eb8c4ab10bdfa. The main reason is that now the workflow is inconsistent when using spring. When using spring `RAILS_ENV` is always set, so only one database is created. This means that in development `bin/rake db:create` and `bundle exec rake db:create` have different results. It also breaks the `bin/setup` script since `bin/rake db:setup db:test:prepare` will fail.
* | | | | Merge pull request #24215 from shiraikenta/modify-atom-feed-helper-rbJon Moss2016-03-161-1/+1
|\ \ \ \ \ | | | | | | | | | | | | fix a comment in atom_feed_helper.rb
| * | | | | fix a comment in atom_feed_helper.rb白井 健太2016-03-161-1/+1
|/ / / / /
* | | | | Merge pull request #24205 from delftswa2016/improve-activesupport-dependenciesXavier Noria2016-03-161-3/+6
|\ \ \ \ \ | | | | | | | | | | | | Improve ActiveSupport::Dependencies code understanding
| * | | | | Improve code readability in ActiveSupport::DependenciesAaron Ang2016-03-161-5/+6
| | | | | |
| * | | | | Add comments to ActiveSupport::Dependencies to help understandingAaron Ang2016-03-161-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a previous patch, all log-related stuff was removed. However, some logs are still useful to understand the code. Therefore, in this patch, I put those log messages back as comments. [ci skip]
* | | | | | adds .gitattributes to enable Ruby-awarenessXavier Noria2016-03-161-0/+2
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This configuration improves git diff, git log -p -W, git grep -p, ..., and allows to inspect the history of a method with a command like git log -L:new_constants_in:activesupport/lib/active_support/dependencies.rb Let me also appeal to authority by saying it is present in the Ruby repository as well https://github.com/ruby/ruby/blob/trunk/.gitattributes :)
* | | | | no need to clear an unusued collectionXavier Noria2016-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the code reaches that line new_constants is no longer needed. We only need here to iterate over it to discard stuff and done. Note that constant_watch_stack.new_constants returns a new reference each time it is invoked, so that #clear call was not cleaning state in some internal structure (which would have been a bit dirty as well at this level of coupling).
* | | | | removes unreachable codeXavier Noria2016-03-161-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This array literal cannot be reached. The previous begin either returns to the caller via the explicit return in the ensure block if all goes well, or else propagates whatever make the begin block abort execution. I have investigated the origin of this a bit. In the past the ensure block didn't have a return call, see for example c08547d. Later on the return was added in 4da4506, but the trailing literal was left there.
* | | | | tests the raising/throwing discards the watching stackXavier Noria2016-03-163-4/+8
| | | | |
* | | | | s/removes/discards/Xavier Noria2016-03-161-2/+2
| | | | |
* | | | | adds coverage for raising while autoloadingXavier Noria2016-03-162-0/+12
| | | | |
* | | | | adds coverage for throwing while autoloadingXavier Noria2016-03-152-0/+14
| | | | | | | | | | | | | | | | | | | | References #24205.
* | | | | Share dev caching implementation between task and server.Kasper Timm Hansen2016-03-153-25/+46
| | | | | | | | | | | | | | | | | | | | | | | | | Lets have the server and the Rake task go through the same ropes, so we can share all the file lookup, adding, and deleting code.
* | | | | Merge pull request #24204 from sand33pn/masterVipul A M2016-03-151-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Update action_controller_overview.md
| * | | | | Update action_controller_overview.mdSandeep Navghane2016-03-151-1/+1
|/ / / / /
* | | | | Merge pull request #24198 from delftswa2016/remove-log-related-stuffXavier Noria2016-03-153-51/+0
|\ \ \ \ \ | |/ / / / |/| | | | Remove log-related stuff from ActiveSupport::Dependencies
| * | | | Remove log-related stuff from ActiveSupport::DependenciesAaron Ang2016-03-153-51/+0
|/ / / / | | | | | | | | | | | | | | | | In this patch, all log-related stuff in `ActiveSupport::Dependencies` is removed because the logging is no longer useful.
* | | | Merge pull request #24188 from wiehann/railsguide-fixJon Moss2016-03-141-1/+1
|\ \ \ \ | | | | | | | | | | Correct command for generating secret_key_base [ci skip]
| * | | | Correct command for generating secret_key_base [ci skip]Wiehann2016-03-141-1/+1
| | | | |
* | | | | Merge pull request #24187 from akihiro17/fix-find-docArthur Nogueira Neves2016-03-141-2/+2
|\ \ \ \ \ | |/ / / / |/| | | | [ci skip] Fix the FinderMethods#find document
| * | | | [ci skip] Fix the FinderMethods#find documentakihiro172016-03-141-2/+2
|/ / / / | | | | | | | | | | | | We should use #find_or_initialize_by and #find_or_create_by because #first_or_initialize and #first_or_create methods are not the public API
* | | | Merge pull request #24184 from y-yagi/add_queue_classic_to_listप्रथमेश Sonpatki2016-03-141-3/+4
|\ \ \ \ | | | | | | | | | | add `queue_classic` to list of provide `provider_job_id` [ci skip]
| * | | | add `queue_classic` to list of provide `provider_job_id` [ci skip]yuuji.yaginuma2016-03-141-3/+4
|/ / / /
* | | | Merge pull request #24175 from y-yagi/add_headers_to_payloadJon Moss2016-03-121-0/+4
|\ \ \ \ | | | | | | | | | | add headers to payload list [ci skip]
| * | | | add headers to payload list [ci skip]yuuji.yaginuma2016-03-131-0/+4
| | |/ / | |/| | | | | | | | | | Follow up to #24115.
* | | | Merge pull request #24174 from y-yagi/silence_deprecation_messageArthur Nogueira Neves2016-03-121-1/+3
|\ \ \ \ | | | | | | | | | | silence deprecation message for dynamic controller and actions on Action View test
| * | | | silence deprecation message for dynamic controller and actions on Action ↵yuuji.yaginuma2016-03-131-1/+3
| |/ / / | | | | | | | | | | | | | | | | | | | | View test Follow up to #23980.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 17:16:36 +0000