aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* test, inline `DeveloperWithAggregate`, which is used by a single test.Yves Senn2014-05-192-7/+7
|
* Merge pull request #15168 from ↵Rafael Mendonça França2014-05-191-0/+2
|\ | | | | | | | | eileencodes/return-early-on-delete-and-destroy-methods Return early on delete and destroy methods
| * early return on delete and destroy methodseileencodes2014-05-181-0/+2
| | | | | | | | | | | | When delete or destroy is called on all records nothing is deleted or destroyed. Intead of running through the code and still not deleteing anything, we should early return
* | Merge pull request #14126 from schuetzm/index_option_for_columnRafael Mendonça França2014-05-193-6/+28
|\ \ | | | | | | Make `:index` in migrations work with all column types
| * | Make `:index` in migrations work with all column typesMarc Schütz2014-05-183-6/+28
| |/
* | Merge pull request #15160 from sgrif/sg-destructured-eachRafael Mendonça França2014-05-191-4/+4
|\ \ | | | | | | Use destructured arguments when looping through pairs
| * | Use destructured arguments when looping through pairsSean Griffin2014-05-171-4/+4
| | | | | | | | | | | | Minor refactoring of looping behavior for aggregation
* | | pg, re-introduce `PostgreSQL::Utils` to unify schema/table extraction.Yves Senn2014-05-196-39/+51
| | | | | | | | | | | | Partial revert of c0bfc3f412834ffe8327a15ae3a46602cc28e425
* | | pg, add missing nodocs for extracted modules.Yves Senn2014-05-195-10/+10
| | |
* | | Merge pull request #14962 from arunagw/aa-fix-rake-activerecordYves Senn2014-05-194-78/+81
|\ \ \ | | | | | | | | Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]
| * | | Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]Arun Agrawal2014-05-164-78/+81
| | | |
* | | | pg guide, move introductory sentences into main content. [ci skip]Yves Senn2014-05-191-7/+7
| | | | | | | | | | | | | | | | This is a reaction to https://github.com/rails/rails/commit/7ca75f3789e316b6f3dc1f8000ec4f85c8ba32ea#commitcomment-6303828
* | | | Merge pull request #15156 from sgrif/sg-postgres-timestampsYves Senn2014-05-181-6/+3
|\ \ \ \ | | | | | | | | | | PostgreSQL timestamps should always be datetimes
| * | | | PostgreSQL timestamps are always datetimesSean Griffin2014-05-171-6/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current behavior is that they are treated as `datetime` normally, but if they are part of an array, they are treated as `timestamp`. The only place that seems to be impacted by this is schema dumping, which shouldn't matter since `t.datetime` and `t.timestamp` are equivalent in the `PostgreSQL` adapter, anyway.
* | | | | Feature detect based on Ruby version.Aaron Patterson2014-05-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I didn't want to do this, FNM_EXTGLOB is defined on 2.1.x, but Dir.glob returns the wrong value on Ruby less than 2.2.0. Checking for a case-insensitive FS seems too hard, so just check Ruby version Checking for a case-insensitive FS seems too hard, so just check Ruby version.
* | | | | A tiny pass through the PostgreSQL guide [ci skip]Robin Dupret2014-05-181-3/+4
| | | | |
* | | | | copy edits[ci skip]Vijay Dev2014-05-181-7/+6
| | | | |
* | | | | Merge pull request #15157 from msgehard/remove_cruft_in_has_secure_passwordYves Senn2014-05-181-0/+1
|\ \ \ \ \ | | | | | | | | | | | | Remove cruft now that strong_parameters is default [ci skip]
| * | | | | Let others know why this code is hereMike Gehard2014-05-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Merge pull request #15169 from Gaurav2728/gaurav-ecosystemYves Senn2014-05-181-1/+0
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | remove ecosystem link that is broken [ci skip]
| * | | | | remove ecosystem link that is brokenGaurav Sharma2014-05-181-1/+0
|/ / / / /
* | | | | Merge pull request #15151 from sgrif/sg-add-type-to-columnYves Senn2014-05-1814-57/+86
|\ \ \ \ \ | |_|_|_|/ |/| | | | Add a type object to Column constructor
| * | | | Add a type object to Column constructorSean Griffin2014-05-1714-57/+86
|/ / / / | | | | | | | | | | | | | | | | | | | | Part of #15134. In order to perform typecasting polymorphically, we need to add another argument to the constructor. The order was chosen to match the `oid_type` on `PostgreSQLColumn`.
* | / / Merge pull request #15137 from sgrif/sg-remove-dead-codeRafael Mendonça França2014-05-1719-183/+82
|\| | | | |/ / |/| | Remove dead test code for unsupported adapters
| * | Remove dead test code for unsupported adaptersSean Griffin2014-05-1719-183/+82
|/ /
* | Merge pull request #14428 from jnormore/reset_counters_aliasRafael Mendonça França2014-05-173-8/+27
|\ \ | | | | | | Updates reset_counters to allow counter name in params
| * | Updates reset_counters to allow counter name in paramsJason Normore2014-05-163-8/+27
| | | | | | | | | | | | | | | | | | | | | Add support for counter name to be passed as parameter on `CounterCache::ClassMethods#reset_counters`. This is to be consistent with the other methods in the module that all accept counter name.
* | | Document method visibility for designing API docs. [ci skip]Zachary Scott2014-05-171-0/+34
| | | | | | | | | | | | cc https://github.com/rails/rails/issues/14848#issuecomment-41198795
* | | Merge pull request #15152 from printercu/patch-5Rafael Mendonça França2014-05-171-70/+69
|\ \ \ | | | | | | | | Collected TimeZone's class methods together
| * | | Collected TimeZone's class methods togetherprintercu2014-05-171-70/+69
| | | | | | | | | | | | | | | | Just moved class methods up in file and moved `def self.` methods into `class << self`.
* | | | Merge pull request #15149 from sgrif/sg-missing-testsRafael Mendonça França2014-05-171-0/+36
|\ \ \ \ | | | | | | | | | | Add missing tests for column type cast behavior
| * | | | Add missing tests for column type cast behaviorSean Griffin2014-05-171-0/+36
| |/ / /
* / / / New applications should be created with json serializerRafael Mendonça França2014-05-172-0/+41
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fix introduced at 75ba7425f6d235f254c00a45a58f42e88f80301a were missing this case. To fix the original issue mentioned at that commit the correct is to remove update_config_files from the command list since we should not run both config_files command when creating a new application. Tests were added to make sure everything is working fine.
* | | Merge pull request #15150 from xtian/fix-railties-testsGuillermo Iguaran2014-05-172-6/+2
|\ \ \ | | | | | | | | Fix app generator test hanging.
| * | | Fix app generator test hanging.Christian Wesselhoeft2014-05-172-6/+2
|/ / /
* | | Merge pull request #15147 from regonn/fix-symbolRichard Schneeman2014-05-171-1/+1
|\ \ \ | | | | | | | | Fix symbol at guides getting_started.md
| * | | fix symbolregonn2014-05-171-1/+1
|/ / /
* | | Merge pull request #15132 from zuhao/refactor_actionpack_abstract_collector_testYves Senn2014-05-171-5/+11
|\ \ \ | | | | | | | | Ensure :js is defined regardless of the outcome of the test.
| * | | Ensure :js is defined regardless of the outcome of the test.Zuhao Wan2014-05-171-5/+11
| | | |
* | | | prefer file name instead of filename [ci skip]Vijay Dev2014-05-171-2/+2
| | | |
* | | | fix typo [ci skip]Vijay Dev2014-05-171-1/+1
| | | |
* | | | Merge pull request #15145 from ShunsukeAida/capitalizationVijay Dev2014-05-171-3/+3
|\ \ \ \ | | | | | | | | | | fixed capitalizations [ci skip]
| * | | | fixed capitalizations [ci skip]SA2014-05-171-3/+3
|/ / / / | | | | | | | | jQuery, SQLite3 and Unicorn use these respective capitalizations pretty much everywhere else in the comment sections of the project.
* | | | Merge pull request #15144 from leafac/fix-changelog-#15071Godfrey Chan2014-05-161-1/+3
|\ \ \ \ | |_|/ / |/| | | Fix typo in CHANGELOG entry for #15071
| * | | Fix typo in CHANGELOG entry for #15071Leandro Facchinetti2014-05-171-1/+3
|/ / /
* | | Merge pull request #15143 from htanata/first_person_pronounsRafael Mendonça França2014-05-163-11/+11
|\ \ \ | | | | | | | | Replace first person point of view on guides.
| * | | Replace first person point of view on guides.Hendy Tanata2014-05-163-11/+11
|/ / / | | | | | | | | | [skip ci]
* | | Merge pull request #15037 from ↵Rafael Mendonça França2014-05-163-7/+34
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | roccoblues/fix_duplicate_activesupport_subscribers Fixed duplicate subscribers in ActiveSupport::Subscriber Conflicts: activesupport/CHANGELOG.md
| * | | Fixed duplicate subscribers in ActiveSupport::SubscriberDennis Schoen2014-05-093-7/+34
| | | | | | | | | | | | | | | | | | | | ActiveSupport::Subscriber no longer creates multiple subscribers when you redefine a method.
* | | | Add CHANGELOG entry for #15071 [ci skip]Rafael Mendonça França2014-05-161-0/+8
| | | |