Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Perf: refactor _assign method to avoid inject and defining unneeded local var. | Emilio Tagua | 2010-09-22 | 1 | -5/+1 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Refactor methods in html node to avoid injects. | Emilio Tagua | 2010-09-22 | 1 | -8/+4 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Refactor association_collection uniq method. | Emilio Tagua | 2010-09-22 | 1 | -4/+3 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | No need to use inject here. | Emilio Tagua | 2010-09-22 | 1 | -5/+5 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Perf: refactor method. | Emilio Tagua | 2010-09-22 | 1 | -11/+8 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | No need to use inject here, use map instead. | Emilio Tagua | 2010-09-22 | 1 | -4/+1 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Goodbye inject, hello map. | Emilio Tagua | 2010-09-22 | 1 | -7/+5 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Use map instead inject. | Emilio Tagua | 2010-09-22 | 1 | -4/+3 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Missing the mysql2 gem here | Santiago Pastorino | 2010-09-22 | 1 | -1/+1 | |
| | | ||||||
* | | Error message should advice to use 'mysql2' gem. | Neeraj Singh | 2010-09-22 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | If I create a new app using command rails new demo -d mysql then Gemfile contains 'mysql2' gem by default. However if mysql gem is missing then error message says raise "!!! Missing the mysql gem. Add it to your Gemfile: gem 'mysql', '2.8.1'" [#5569 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | avoid a proc object | Aaron Patterson | 2010-09-22 | 1 | -1/+1 | |
| | | ||||||
* | | avoid creating a range object | Aaron Patterson | 2010-09-22 | 1 | -1/+1 | |
| | | ||||||
* | | form_for with file_field docs fixed | Santiago Pastorino | 2010-09-22 | 1 | -2/+2 | |
| | | ||||||
* | | drying up construct_association | Aaron Patterson | 2010-09-21 | 1 | -15/+15 | |
| | | ||||||
* | | dry up some conditionals | Aaron Patterson | 2010-09-21 | 1 | -3/+4 | |
| | | ||||||
* | | fixing case / when indentation | Aaron Patterson | 2010-09-21 | 1 | -19/+19 | |
| | | ||||||
* | | fix case / when indentation | Aaron Patterson | 2010-09-21 | 1 | -18/+18 | |
| | | ||||||
* | | avoid a hash lookup | Aaron Patterson | 2010-09-21 | 1 | -2/+2 | |
| | | ||||||
* | | remove more codes | Aaron Patterson | 2010-09-21 | 1 | -6/+4 | |
| | | ||||||
* | | deleting more code | Aaron Patterson | 2010-09-21 | 1 | -4/+1 | |
| | | ||||||
* | | use each properly to avoid splatting a variable | Aaron Patterson | 2010-09-21 | 1 | -2/+1 | |
| | | ||||||
* | | deleting repeated codes | Aaron Patterson | 2010-09-21 | 1 | -13/+10 | |
| | | ||||||
* | | do not pass nil values to arel | Aaron Patterson | 2010-09-21 | 1 | -1/+1 | |
| | | ||||||
* | | refacoring duplicate code. <3 <3 <3 | Aaron Patterson | 2010-09-21 | 1 | -2/+3 | |
| | | ||||||
* | | this reject can be replaced with compact | Aaron Patterson | 2010-09-21 | 1 | -1/+1 | |
| | | ||||||
* | | removing unused code | Aaron Patterson | 2010-09-21 | 1 | -2/+1 | |
| | | ||||||
* | | remove some repeated code | Aaron Patterson | 2010-09-21 | 1 | -2/+2 | |
| | | ||||||
* | | break up giant method | Aaron Patterson | 2010-09-21 | 1 | -62/+72 | |
| | | ||||||
* | | api guidelines: adds Test::Unit and RSpec as examples of correct spelling, ↵ | Xavier Noria | 2010-09-21 | 1 | -1/+3 | |
| | | | | | | | | also advice when in doubt | |||||
* | | removing lolinject | Aaron Patterson | 2010-09-21 | 1 | -1/+1 | |
| | | ||||||
* | | fixing tests. woo | Aaron Patterson | 2010-09-21 | 1 | -4/+7 | |
| | | ||||||
* | | remove join table rows before removing owner row for habtm associations, ↵ | Hemant Kumar | 2010-09-21 | 2 | -2/+2 | |
| | | | | | | | | fixes#5674 | |||||
* | | providing arel with column information when possible [#5392 state:resolved] | Aaron Patterson | 2010-09-21 | 3 | -3/+29 | |
| | | ||||||
* | | un-nodocs AR::Batches | Xavier Noria | 2010-09-21 | 1 | -1/+1 | |
| | | ||||||
* | | Remove helper methods that were moved to helper.rb | Emilio Tagua | 2010-09-21 | 1 | -15/+0 | |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | Move helper methods to helper.rb. Make test not depend on local TZ to pass ↵ | Emilio Tagua | 2010-09-21 | 2 | -9/+27 | |
| | | | | | | | | | | | | or fail. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | List all of isolated engine changes | Piotr Sarnacki | 2010-09-20 | 1 | -3/+21 | |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | use instance_eval, reduce method calls. | Stevie Graham | 2010-09-21 | 1 | -15/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | execution time in seconds for `rake test_sqlite3`: ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-darwin10.4.0] - before: 52.771426, 52.159505, 52.937056 - after: 51.452584, 51.897017, 51.584431 rubinius 1.0.1 (1.8.7 release 2010-06-03 JI) [x86_64-apple-darwin10.4.0] - before: 284.334076 - after: 285.753028 ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0] - before: 75.811548, 75.533153, 75.353122 - after: 75.244243, 75.19226, 75.256925 | |||||
* | | Strengthen documantation on engine's migrations and seed data | Piotr Sarnacki | 2010-09-20 | 1 | -0/+15 | |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | Add helper for loading seed data for engine and application | Piotr Sarnacki | 2010-09-20 | 4 | -2/+30 | |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | file_field propagates up multipart property even inside of fields_for | Santiago Pastorino | 2010-09-20 | 2 | -8/+34 | |
| | | ||||||
* | | Updating error message on ruby_version_check.rb | Thiago Pradi | 2010-09-19 | 1 | -2/+1 | |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Send 'rails runner' help message to stdout instead of stderr. | rohit | 2010-09-19 | 2 | -3/+2 | |
| | | | | | | | | | | | | [#5661 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | application.js should be the last file on javascript_include_tag(:all) | Santiago Pastorino | 2010-09-19 | 2 | -9/+9 | |
| | | ||||||
* | | Exception handling more readable | Thiago Pradi | 2010-09-19 | 8 | -26/+26 | |
| | | | | | | | | | | | | [#5601 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Use `Time.current` to maintain consistency with AS::Duration | Prem Sichanugrist | 2010-09-19 | 2 | -2/+40 | |
| | | | | | | | | | | | | | | | | | | | | In [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch methods in AS::Duration to use `Time.current` to return the correct duration based on the `Time.default_zone` instead of using `Time.now`. [#5607 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | | Fix running engine_test in isolation | Piotr Sarnacki | 2010-09-19 | 2 | -1/+1 | |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | Remove unnecessary puts | Piotr Sarnacki | 2010-09-19 | 1 | -1/+0 | |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | | adds to the API guidelines the proper spelling of Arel | Xavier Noria | 2010-09-19 | 3 | -4/+4 | |
| | | ||||||
* | | removing some warnings | Aaron Patterson | 2010-09-18 | 3 | -8/+8 | |
| | |