| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
reflecting on wrong association
|
|\
| |
| | |
Add an interface for type objects to control Ruby => SQL
|
| |
| |
| |
| |
| | |
Adds the ability to save custom types, which type cast to non-primitive
ruby objects.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Remove duplicated to_s method call.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Fix test cases for inflector.rb
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`yield` was missing in #with_dup, due to which 57 assertions were not running
in real, and all tests were passing by default.
Error was introduced in commit - 31ceb5e.
|
|\ \ \ \
| | | | |
| | | | | |
simple solution that brings rake stats task to all rails project
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
remove unused variable warning.
|
| | | | |
| | | | |
| | | | |
| | | | | |
`warning: assigned but unused variable - album`
|
|/ / / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Remove unnecessary flatten! method call.
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
[ci skip] Update GFM link in guides guidelines.
|
| |/ /
| | |
| | |
| | | |
Also remove a duplicated sentence.
|
|\ \ \
| | | |
| | | | |
Convert source to string if it is present.
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
The correct status to test should be :switching_protocols.
|
|/ / |
|
|\ \
| | |
| | | |
Remove unnecessary require of Minitest.
|
| | |
| | |
| | |
| | | |
Minitest has already been required when calling Minitest.autorun.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Unwrap Constraints objects. I don't actually think it's possible
to pass a Constraints object to this constructor, but there were
multiple places that kept testing children of this object. I
*think* they were just being defensive, but I have no idea.
|
|\ \ \
| | | |
| | | | |
Update all Rails 4.1.0 references in guides to 4.1.1 [ci skip]
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | | |
I don't know when this changed, checked back up to 3.2 and integration
tests instantiate fixtures just fine.
|
|\ \ \
| | | |
| | | | |
Improve readability of Explain Queries table in guides
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
rake stats for engines
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
documentation link fix and removing unused reader
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
fixed capitalization [ci skip]
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | | |
avoid using alias in generators
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Ruby's alias produces public methods, causing a spurious Thor task
to be created. For example, this is the reason MigrationGenerator
currently has two tasks:
> ActiveRecord::Generators::MigrationGenerator.all_tasks.keys
=> ["singular_name", "create_migration_file"]
singular_name was meant to be an attribute, not a task. Because it's
public, it gets called as a task every time the generator is invoked.
The fix is to ensure all generator methods have the correct
visibility.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[Guides] Add documentation for using Rails with a reverse proxy [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes URL generation with trailing_slash: true
Conflicts:
actionpack/lib/action_dispatch/http/url.rb
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
URL generation with trailing_slash: true was adding a trailing slash
after .:format
Routes.draw do
resources :bars
end
bars_url(trailing_slash: true, format: 'json')
# => /bars.json/
This commit removes that extra trailing slash
|
| | | | | | | |
|
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This mirrors the layout of abstract adapter and puts the definitions
inside the `PostgreSQL` namespace (no longer under the adapter namespace).
/cc @kares
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
schneems/schneems/generator-output-in-error"
This reverts commit 7466d6a9f989a1a8f90899b79b34f1152e440b7c, reversing
changes made to b850c4c540e8f0c15742f67c532f521a4a123655.
This was an accidental merge. A new PR will follow.
/cc @schneems
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
print generators on failed generate
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Let's say we just ran:
```
$ rails g migrate add_click_to_issue_assignment
```
We will get an error that looks like:
```
Could not find generator migrate.
```
This patch adds all existing migrations to the output to make it easier for a developer to find a valid migration.
```
Could not find generator "migrate". Please select a valid generator:
Rails:
assets
controller
generator
helper
integration_test
mailer
migration
model
resource
scaffold
scaffold_controller
task
```
It would be nice to do some spelling detection and suggest alternatives, but for now this should help.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ci skip] Improve doc for ModuleConstMissing.guess_for_anonymous
|
| | | | | | | | |
|