aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | Move `require 'ipaddr'` in `postgresql/oid/cidr.rb`Ryuta Kamizono2016-04-242-2/+2
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | `IPAddr` is used in `OID::Cidr`.
* | | | | | | Merge pull request #24704 from graemeboy/masterप्रथमेश Sonpatki2016-04-241-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix typo in ActiveJob #retry_job doc
| * | | | | | | Fix typo in ActiveJob #retry_job docGraeme Boy2016-04-231-1/+1
|/ / / / / / /
* | | | | | | Merge pull request #24703 from vipulnsward/24695-handle-nilsSean Griffin2016-04-232-0/+10
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Followup of #15771
| * | | | | | | Followup of #15771Vipul A M2016-04-242-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure we handle explicitly passed nil's to lock_version as well. An explicitly passed nil value is now converted to 0 on LockingType, so that we don't end up with ActiveRecord::StaleObjectError in update record optimistic locking Fixes #24695
* | | | | | | | Share lock: avoid livelock due to exclusive thread sleeping before waiting ↵Jeremy Daer2016-04-231-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | threads wake
* | | | | | | | Merge pull request #24699 from vipulnsward/to_time_cleanupAndrew White2016-04-232-5/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Follow up of https://github.com/rails/rails/commit/c9c5788a527b70d7f9…
| * | | | | | | | Follow up of ↵Vipul A M2016-04-242-5/+5
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/c9c5788a527b70d7f983e2b4b47e3afd863d9f48 [ci skip]
* | | | | | | | Make getlocal and getutc always return instances of TimeAndrew White2016-04-236-23/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously these methods could return either a DateTime or a Time depending on how the ActiveSupport::TimeWithZone instance had been constructed. Changing to always return an instance of Time eliminates a possible stack level too deep error in to_time where it was wrapping a DateTime instance. As a consequence of this the internal time value is now always an instance of Time in the UTC timezone, whether that's as the UTC time directly or a representation of the local time in the timezone. There should be no consequences of this internal change and if there are it's a bug due to leaky abstractions.
* | | | | | | | Add DateTime#subsecAndrew White2016-04-233-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mirrors the Time#subsec method by returning the fraction of the second as a Rational.
* | | | | | | | Change Time#sec_fraction to use subsecAndrew White2016-04-232-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Time instances can have fractional parts smaller than a nanosecond.
* | | | | | | | Add additional aliases for DateTime#utcAndrew White2016-04-232-0/+7
| | | | | | | |
* | | | | | | | Add CHANGELOG entry for #24700Andrew White2016-04-231-0/+5
| | | | | | | |
* | | | | | | | Add Time#sec_fractionAndrew White2016-04-232-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mirrors the DateTime#sec_fraction method by returning the fraction of the second as a Rational.
* | | | | | | | Merge pull request #24700 from yui-knk/refactor_localtimeAndrew White2016-04-232-11/+12
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Move `DateTime#getlocal` to `/core_ext/date_time/calculations.rb`
| * | | | | | | Move `DateTime#getlocal` to `/core_ext/date_time/calculations.rb`yui-knk2016-04-232-11/+12
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `DateTime#getlocal` is newly added public API. It's responsible is same as `DateTime#utc`, so `calculations.rb` is a best plase to define this method. For keeping consistency with `DateTime#utc`, defines `#localtime` and defines `getlocal` as an alias method.
* | | | | | | Add compatibility for Ruby 2.4 `to_time` changesAndrew White2016-04-2316-7/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will preserve the timezone of the receiver when converting to an instance of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we need to introduce a compatibility layer so that apps that upgrade do not break. New apps will have a config initializer file that defaults to match the new Ruby 2.4 behavior going forward. For information about the changes to Ruby see: https://bugs.ruby-lang.org/issues/12189 https://bugs.ruby-lang.org/issues/12271 Fixes #24617.
* | | | | | | Merge pull request #24697 from tomkadwill/action_pack_typos_2Vipul A M2016-04-234-10/+10
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Actionpack documentation typos [ci skip]
| * | | | | | Actionpack documentation typos [ci skip]Tom Kadwill2016-04-234-10/+10
| | | | | | |
* | | | | | | Schema load: Fix dupe version insertJeremy Daer2016-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Re. 6e098284e97250eaed6f30f5c7c362d87da986b0
* | | | | | | Merge pull request #24693 from vipulnsward/fix-test-nameArthur Nogueira Neves2016-04-221-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix test name
| * | | | | | | Fix test nameVipul A M2016-04-231-1/+1
|/ / / / / / /
* | | | | | | Merge pull request #24685 from vipulnsward/sqlite-compat-for-multi-insertJeremy Daer2016-04-224-4/+43
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Gracefully fallback on version migrations for sqlite < 3.7.11
| * | | | | | | https://github.com/rails/rails/commit/42dd2336b31a8d98776d039a2b9fd7f834156a ↵Vipul A M2016-04-234-4/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 78 changed INSERT INTO versions to run in 1 single query. This breaks for sqlite versions < 3.7.11, which is especially the case on Ubuntu 12.04 LTS, that has SQLite version 3.7.9 as default. So we check for support for multi insert, before performing single query inserts, else fallback to older version of running multiple queries. [Vipul A M & Yasuo Honda]
* | | | | | | | Do not attempt to return connection with open transaction to pool (#24610)Sean Griffin2016-04-222-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the query cache completes, if Active Record is still inside of a transaction, it is because the transaction is meant to be left open above this unit of work (such as transactional fixtures in tests). There were several tests around the behavior of "tests" that were invalid, as tests are not run through the executor. They have been changed to reflect the new behavior, which is closer to what actually occurs in Rails tests. Fixes #23989 Fixes #24491 Close #24500
* | | | | | | | fix boot performance issueAaron Patterson2016-04-221-12/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Slight refactor to improve boot performance on some Ruby implementations (for now).
* | | | | | | | Merge pull request #24686 from javiervidal/broken-links-in-3-0-releases-notesVipul A M2016-04-221-3/+2
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | Fix broken links in 'Ruby on Rails 3.0 Release Notes' [ci skip]
| * | | | | | | Fix broken links in 'Ruby on Rails 3.0 Release Notes' [ci skip]Javier Vidal2016-04-221-3/+2
|/ / / / / / /
* | | | | | | Change definition of what async means for an Active Job Job [ci skip]Vipul A M2016-04-221-1/+2
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Change definition of what async means for an Active Job Job [ci skip]
| * | | | | | - [ci skip] Active Job Async doesn't support to Async feature as per it's ↵Mohit Natoo2016-04-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | definition. - [ci skip] Active Job Async doesn't support to Async feature as per it's definition. - [ci skip] Active Job Async doesn't support to Async feature as per it's definition. - [ci skip] Active Job Async doesn't support to Async feature as per it's definition. - [ci skip] Active Job Async doesn't support to Async feature as per it's definition.
* | | | | | | Merge pull request #24681 from tcopeland/not_example_can_demonstrate_inequalityRichard Schneeman2016-04-211-3/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Combine inequality and equality and add SQL examples [ci skip]
| * | | | | | | Add SQL examples for equality and NOT [ci skip]Tom Copeland2016-04-211-3/+13
|/ / / / / / /
* | | | | | | Merge pull request #24669 from tomkadwill/action_pack_typosVipul A M2016-04-223-12/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Actioncable and Actionpack documentation typos [ci skip]
| * | | | | | | Actioncable and Actionpack documentation typos [ci skip]Tom Kadwill2016-04-213-12/+11
| | |/ / / / / | |/| | | | |
* | | | | | | just say nothing about why this regexp is slower [ci skip]Xavier Noria2016-04-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Further investigation seems to disprove that backtracking is the reason why the positive variant is slower, see https://github.com/rails/rails/pull/24658#issuecomment-213079710 so, just say nothing about it, only assert it is slower.
* | | | | | | Merge pull request #24680 from mohitnatoo/rake-dev-cacheKasper Timm Hansen2016-04-211-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | using rails dev:cache instead of rake dev:cache
| * | | | | | | - using rails dev:cache instead of rake dev:cacheMohit Natoo2016-04-221-1/+1
| | |/ / / / / | |/| | | | |
* | | | | | | Merge pull request #24676 from vipulnsward/log-ac-failed-statesJeremy Daer2016-04-211-0/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Log if redis connection is in stale/failed state.
| * | | | | | | Log if redis connection is in stale/failed state.Vipul A M2016-04-211-0/+4
| | | | | | | |
* | | | | | | | Make file update checker tests more resilient on WindowsSean Griffin2016-04-213-5/+10
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without the `wdm` gem, it appears that `listen` keeps an open handle to each of these files, causing them not to be removed when the tempdir tries to clean iteslf up, and then directory to fail to unlink. In addition to fixing that particular failure, we now construct OS agnostic paths, and capture exceptions if the directory fails to unlink so that minitest will report it rather than crash
* | | | | | | Merge pull request #24661 from maclover7/fix-22975Rafael França2016-04-212-1/+9
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix ApplicationController.renderer.defaults.merge!
| * | | | | | | Fix ApplicationController.renderer.defaults.merge!Jon Moss2016-04-202-1/+9
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, users were trying to modify a frozen Hash. Includes a regression test :) Fixes #22975
* | | | | | | Merge pull request #24672 from mrkjlchvz/mc-space-bumpRafael França2016-04-211-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Minor space bump.
| * | | | | | | Minor space bump.Mark2016-04-211-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #24664 from ↵Rafael França2016-04-211-1/+1
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | y-yagi/use_wrapper_file_to_add_rake_task_for_engines use wrapper file to add rake task for engines
| * | | | | | | use wrapper file to add rake task for enginesyuuji.yaginuma2016-04-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `bundler` provides wrapper file to add rask tasks. https://github.com/bundler/bundler/blob/master/lib/bundler/gem_tasks.rb Instead of directly call method, by which require this file, it can be used without updating of Rakefile if task has been added.
* | | | | | | | restores code comments in String#blank? [ci skip]Xavier Noria2016-04-211-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you come here without context, it is important to hightlight that checking the predicate is worthwhile due to the observation that blank strings are often empty. So you complicate the code (which has a cost in terms of readability and aesthetics), but statistically makes sense. Then, you also need to explain why the second operand is so convoluted. Otherwise, you wonder why this line is written precisely this way. That is what code comments are for.
* | | | | | | | Merge pull request #24663 from kamipo/remove_unused_blank_reJeremy Daer2016-04-201-2/+0
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove unused `BLANK_RE`
| * | | | | | | | Remove unused `BLANK_RE`Ryuta Kamizono2016-04-211-2/+0
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | Follow up to #24658.
* | | | | | | | Merge pull request #24657 from maclover7/fix-23643-1Rafael França2016-04-211-0/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add #18323 to 5.0 release notes
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 10:46:44 +0000