| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
By having the `:has_and_belongs_to_many` macro in the `@collection`
we are punishing `:has_many` associations because it has to allocate
the array and check the macro.
@collection is returned to `macro == :has_many` and a new reflection
class `HABTMReflection` is created to handle this case instead.
|
|\
| |
| | |
Remove a long gone :order option from has_one's valid_options
|
|/ |
|
| |
|
|\
| |
| | |
Mail 2.6.1 silences excessive warnings; remove Gemfile hack
|
|/
|
|
|
|
|
|
| |
Completes https://github.com/rails/rails/pull/15493
Revert "For our build, stick with mail 2.5.x for now"
This reverts commit b8f586a094c104006d29a87fee0d8b48d0af2d14.
|
|\
| |
| | |
Update migrations.md
|
|/
|
| |
default column type modifier
|
|
|
|
|
|
|
| |
Not sure what's causing them suddenly, but it seems unlikely there's
much we can do about it. For the small amount of coverage this
particular job gains us, it's hurting us more, by making CI failures
unremarkable.
|
|\
| |
| | |
Restore test deliveries for ActionMailer.
|
| | |
|
|\ \
| | |
| | | |
Handle client disconnect during live streaming
|
| | |
| | |
| | |
| | | |
.. even when the producer is blocked for a write.
|
|\ \ \
| | | |
| | | | |
Add Additional Test Cases for the constantize
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
fix test cases after #15558 merge to master.
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rename `property` to `attribute`
Conflicts:
activerecord/lib/active_record/attribute_methods/serialization.rb
activerecord/lib/active_record/base.rb
|
| | | |
| | | |
| | | |
| | | | |
For consistency with https://github.com/rails/rails/pull/15557
|
|\ \ \ \
| |_|/ /
|/| | | |
Don't query the database schema when calling `serialize`
|
| | |/
| |/|
| | |
| | |
| | |
| | | |
We need to decorate the types lazily. This is extracted to a separate
API, as there are other refactorings that will be able to make use of
it, and to allow unit testing the finer points more granularly.
|
|\ \ \
| | | |
| | | | |
Ensure time zones don't change after round trip with array columns
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The times would be equivalent, even if they were in different time
zones. E.g. 12:00 UTC == 5:00 PDT
|
|\ \ \ \
| | | | |
| | | | | |
Do not type cast twice on attribute assignment
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The definition of `write_attribute` in dirty checking ultimately leads
to the columns calling `type_cast` on the value to perform the
comparison. However, this is a potentially expensive computation that we
cache when it occurs in `read_attribute`. The only case that we need the
non-type-cast form is for numeric, so we pass that through as well
(something I'm looking to remove in the future).
This also reduces the number of places that manually access various
stages in an attribute's type casting lifecycle, which will aid in one
of the larger refactorings that I'm working on.
|
|\ \ \ \
| | | | |
| | | | | |
Correct Example output in Rails guides [ci skip]
|
| | |_|/
| |/| | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove dead branch when restoring ID within a transaction
Conflicts:
activerecord/lib/active_record/transactions.rb
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There is no way to have an instance of an Active Record model where
`has_attribute?(self.class.primary_key)` returns false. The record is
always initialized in such a way that `@raw_attributes` will have an id
key with nil for the value.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Move conditionals about freezing closer to the definition of `freeze`
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Reduces the number of places that care about the internals of how we
store and type cast attributes. We do not need to go through the
dup/freeze dance, as you couldn't have saved a frozen new record anyway,
and that is the only time we would end up modifying the frozen hash.
|
|\ \ \ \
| |_|/ /
|/| | | |
Remove duplicated `@raw_attributes.keys`
|
|/ / /
| | |
| | |
| | |
| | | |
Reduces the number of things outside of attribute methods that cares
about the details of how we store and type cast attributes
|
|\ \ \
| | | |
| | | | |
Specify a time zone when testing TZ aware attributes
|
| |/ /
| | |
| | |
| | | |
Millisecond inequality causes failures on Travis
|
|/ /
| |
| |
| |
| |
| | |
This is a follow up to #15556
@kuldeepaggarwal did submit this patch way back (#13624).
|
|\ \
| | |
| | | |
Add array support when time zone aware attributes are enabled
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
This is a regression test for 29844dd.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We cannot cache keys because arrays are mutable. We rather want to cache
the arrays. This behaviour is tailor-made for the usage pattern strongs
params is designed for.
In a forthcoming commit I am going to add a test that covers why we need
to cache by value.
Every strong params instance has a live span of a request, the cache goes
away with the object. Since strong params have such a concrete intention,
it would be interesting to see if there are actually any real-world use
cases that are an actual leak, one that practically may matter.
I am not convinced that the theoretical leak has any practical consequences,
but if it can be shown there are, then I believe we should either get rid of
the cache (which is an optimization), or else wipe it in the mutating API.
This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b.
|
| | | |
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
When you manually specify `id:` attribute in a fixture Rails' built in association assignment feature will no longer work. http://stackoverflow.com/questions/23985675/incorrect-association-in-fixtures
This commit raises awareness of this behavior and encourages developers to look directly at the fixture documentation.
|
| | | |
| | | |
| | | | |
The fixtures API docs are really comprehensive. We should either be driving people there, or perhaps making fixtures its own guide.
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix capitalization
|
|/ / / / |
|