| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\
| |
| | |
Always passing a respond block from to responder
|
| |
| |
| |
| |
| |
| |
| | |
We should let the responder to decide what to do with the given
overridden response block, and not short circuit it.
Fixes #5280
|
|/ |
|
|
|
|
| |
builder
|
|\
| |
| | |
[3-2-stable] Fix build
|
| | |
|
|/
|
|
|
|
|
| |
Conflicts:
railties/test/generators/app_generator_test.rb
railties/test/isolation/abstract_unit.rb
|
|
|
|
| |
Change the default for newly generated applications to whitelist all attribute assignment. Also update the generated model classes so users are reminded of the importance of attr_accessible.
|
| |
|
|
|
|
|
|
| |
would get ConnectionNotEstablished error because it always tried to use
ActiveRecord::Base's connection, even though it should be using the connection
of the model whose context we're operating in
|
|
|
|
|
|
|
| |
In Ubuntu Chrome, in the last lines of code blocks, the underscore isn't
visible. Increasing the line height slightly seems to fix this. This
problem doesn't exist in Firefox even on Ubuntu. Too lazy to test in
any other OS-browser combo :)
|
|
|
|
|
|
| |
that info
Closes #5245
|
|
|
|
|
|
| |
Conflicts:
activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Logic in clone_empty method was dealing with old @dirty variable, which
has changed by @html_safe in this commit:
https://github.com/rails/rails/commit/139963c99a955520db6373343662e55f4d16dcd1
This was issuing a "not initialized variable" warning - related to:
https://github.com/rails/rails/pull/5237
The logic applied by this method is already handled by the [] override,
so there is no need to reset the variable here.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 3dbedd2 added NOT NULL constraints both to table
creation and modification. For creation the new default
makes sense, but the generic situation for changing a
table is that there exist records. Those records have
no creation or modification timestamps, and in the
general case you don't even know them, so when updating
a table these constraints are not going to work. See
a bug report for this use case in #3334.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* 3-2-2:
bumping to 3.2.2
Ensure [] respects the status of the buffer.
Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare
Merge pull request #5084 from johndouthat/patch-1
updating RAILS_VERSION
delete vulnerable AS::SafeBuffer#[]
use AS::SafeBuffer#clone_empty for flushing the output_buffer
add AS::SafeBuffer#clone_empty
fix output safety issue with select options
|
| | |
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* 3-2-stable-security:
Ensure [] respects the status of the buffer.
delete vulnerable AS::SafeBuffer#[]
use AS::SafeBuffer#clone_empty for flushing the output_buffer
add AS::SafeBuffer#clone_empty
fix output safety issue with select options
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Fix usage of psql in db:test:prepare
|
| | |
| | |
| | |
| | | |
Remove reference to rails_legacy_mapper, which isn't compatible with 3.2...
|
| | | |
|
|\ \ \
| | | |
| | | | |
[3-2-stable] Fix type_to_sql with text and limit on mysql/mysql2. Fix GH #3931
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
[3-2-stable] Add a new line after the textarea opening tag.
|
| | | |
| | | |
| | | |
| | | | |
Closes #393
|
|\ \ \ \
| |/ / /
|/| | | |
Binary mode window bug
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In asset_tag_helper_test.rb there is an assert on the number of bytes in a
concatenated file. This test failed because Windows converts \n to \r\n as
the default for "w". This is different than in *nix systems where there is
no conversion done.
THe test that failed was test_caching_stylesheet_link_tag_when_caching_on
Using bin mode fixes this behavior on windows and makes no change on the
*nix systems.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Options is needed for some Rails extensions to determine when
referential integrity should be disabled
This reverts commit bcb466c543451dce69403aaae047295758589d8e.
Fixes #5052
|
|/ / / |
|
| | | |
|
| | |
| | |
| | |
| | | |
itself instead of other_money.amount
|
|\ \ \
| | | |
| | | | |
assert => assert_equal
|
| | | | |
|
|\| | |
| | | |
| | | | |
3 2 stable
|
|/ / /
| | |
| | |
| | | |
406ece4729e8fd81f156bcb3fce16e938522466e
|
|\ \ \
| | | |
| | | | |
Build fix ruby187 p358
|
|/ / / |
|
| | |
| | |
| | |
| | | |
Fix usage of psql in db:test:prepare
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove reference to config.action_view.logger from Rails configuration guide
|
| | | | |
|
| |/ /
|/| |
| | |
| | | |
Remove reference to rails_legacy_mapper, which isn't compatible with 3.2...
|