aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* add lib to $LOAD_PATH on application inhertence. fixes #17106Aaron Patterson2014-11-043-9/+16
|
* add a test for #17106Aaron Patterson2014-11-042-0/+22
|
* Merge pull request #17498 from rochefort/remove-redundant-to_sRafael Mendonça França2014-11-031-1/+1
|\ | | | | Remove redundant `to_s` in interpolation
| * Remove redundant `to_s` in interpolationrochefort2014-11-041-1/+1
|/
* Remove unneeded autoloadRafael Mendonça França2014-11-031-4/+1
|
* Merge pull request #17494 from craftsmen/issue-17484Zachary Scott2014-11-030-0/+0
|\ | | | | Change `rails` to `bin/rails` in getting started, fix #1748 [ci skip]
| * Change `rails` to `bin/rails` in getting started, fix #1748 [ci skip]kevcha2014-11-031-3/+3
| |
* | Merge pull request #17487 from pabloh/avoid_allocationsRafael Mendonça França2014-11-035-5/+5
|\ \ | | | | | | Avoid unnecessary allocations and method calls
| * | Avoid unnecessary allocations/callsPablo Herrero2014-11-025-5/+5
| | |
* | | Merge pull request #17383 from rwz/string-removeRafael Mendonça França2014-11-033-8/+26
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Make `String#remove` and `String#remove!` accept multiple arguments Conflicts: activesupport/CHANGELOG.md
| * | | Make `String#remove` and `String#remove!` accept multiple argumentsPavel Pravosud2014-10-253-8/+26
| | | |
* | | | Add comment to point out String#[] is intentionalAndrew White2014-11-021-0/+1
| | | |
* | | | Revert "Replace String index juggling with Pathname goodness in ↵yuuji.yaginuma2014-11-022-1/+11
| |/ / |/| | | | | | | | | | | | | | | | | | | | db:fixtures:load" This reverts commit 482fdad5ef8a73688b50bba3991dd4ef6f286edd. Fixes #17237.
* | | Add an `assert_deprecated` for `sanitize_sql_hash_for_conditions`Sean Griffin2014-11-021-1/+3
| | |
* | | Handle `RangeError` from casting in `find_by` and `find_by!` on RelationSean Griffin2014-11-022-0/+14
| | | | | | | | | | | | | | | We should not behave differently just because a class has a default scope.
* | | Revert deprecation of `sanitize_sql_hash_for_assignment`Sean Griffin2014-11-022-6/+2
| | | | | | | | | | | | This method is still used by `update_all`
* | | Deprecate `sanitize_sql_hash_` methods on ActiveRecordSean Griffin2014-11-022-0/+12
| | | | | | | | | | | | | | | These appear to be implementation relics of times past. They duplicate the logic in Relation, and are no longer used internally.
* | | Pass the `SelectManager`, rather than the AST when querying w/ RelationSean Griffin2014-11-021-1/+1
| | | | | | | | | | | | | | | | | | Arel specifically handles `SelectManager`, with the same logic we're currently performing. The AST is `Enumerable`, which Arel looks for separately now.
* | | Tiny documentation styling fixes [ci skip]Robin Dupret2014-11-023-18/+24
| | |
* | | Merge pull request #17469 from rishijain/update_docs_2Zachary Scott2014-11-022-2/+4
|\ \ \ | | | | | | | | added punctuations, and role of queue_adapter module [ci skip]
| * | | placed description at correct place [ci skip]Rishi Jain2014-11-011-2/+2
| | | |
| * | | added punctuations, and role of queue_adapter module [ci skip]Rishi Jain2014-11-012-2/+4
| | | |
* | | | Merge pull request #17483 from pabloh/optimize_gsub_callsSean Griffin2014-11-015-5/+5
|\ \ \ \ | | | | | | | | | | Call gsub with a Regexp instead of a String for better performance
| * | | | Call gsub with a Regexp instead of a String for better performancePablo Herrero2014-11-015-5/+5
| | | | |
* | | | | Don't duplicate predicate building logic in Relation findersSean Griffin2014-11-011-5/+2
| | | | |
* | | | | Add a test case for range type castingSean Griffin2014-11-011-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | We support this behavior, but have no tests which assert that type casting actually occurs.
* | | | | Use a bound parameter for the "id = " portion of update statementsSean Griffin2014-11-012-5/+14
|/ / / / | | | | | | | | | | | | | | | | | | | | We need to re-order the bind parameters since the AST returned by the relation will have the where statement as the first bp, which breaks on PG.
* | | | Correctly cast calculation results on PGSean Griffin2014-11-014-2/+17
| | | | | | | | | | | | | | | | | | | | MySQL reports the column name as `"MAX(developer_id)"`. PG will report it as `"max"`
* | | | Merge pull request #17482 from djpowers/patch-1Zachary Scott2014-11-011-0/+1
|\ \ \ \ | | | | | | | | | | Add link to API Documentation Guidelines [ci skip]
| * | | | Add link to API Documentation GuidelinesDave Powers2014-11-011-0/+1
|/ / / / | | | | | | | | | | | | Link to the "English" section to specify American English be used for the Guides [ci skip]
* | | | [ci skip] `Relation#bind` is not public APISean Griffin2014-11-011-1/+1
| | | |
* | | | Fix test which failed in isolationSean Griffin2014-11-011-0/+1
| | | | | | | | | | | | | | | | It was transitively relying on the vertex model being loaded
* | | | Use bind values for joined tables in where statementsSean Griffin2014-11-018-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In practical terms, this allows serialized columns and tz aware columns to be used in wheres that go through joins, where they previously would not behave correctly. Internally, this removes 1/3 of the cases where we rely on Arel to perform type casting for us. There were two non-obvious changes required for this. `update_all` on relation was merging its bind values with arel's in the wrong order. Additionally, through associations were assuming there would be no bind parameters in the preloader (presumably because the where would always be part of a join) [Melanie Gilman & Sean Griffin]
* | | | Merge pull request #17463 from mrgilman/remove-index-from-substitute-atSean Griffin2014-11-013-7/+6
|\ \ \ \ | | | | | | | | | | Remove redundant substitute index when constructing bind values
| * | | | Remove redundant substitute index when constructing bind valuesMelanie Gilman2014-10-313-7/+6
| |/ / / | | | | | | | | | | | | | | | | | | | | We end up re-ordering them either way when we construct the Arel AST (in order to deal with rewhere, etc), so we shouldn't bother giving it a number in the first place beforehand.
* | | | Merge pull request #17477 from Adam89/ma-remove-redundant-requireRichard Schneeman2014-11-011-1/+0
|\ \ \ \ | | | | | | | | | | Remove redundant require of file
| * | | | Remove redundant require of fileAdam892014-11-011-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This file was required inside 'test/validators/namespace/email_validator.rb' that's already required here. Therefore I removed the redundant required.
* | | | | Don't needlessly alphabetize columns for insert/updateSean Griffin2014-11-011-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | This slightly simplifies the code, and reduces the number of times we need to iterate over the attributes by one.
* | | | | Tiny documentation fixes and styling improvementsRobin Dupret2014-11-012-12/+17
|/ / / / | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #17474 from kuldeepaggarwal/fix-indentaionRafael Mendonça França2014-11-011-1/+1
|\ \ \ \ | | | | | | | | | | add missing space.[ci skip]
| * | | | add missing space.[ci skip]Kuldeep Aggarwal2014-11-011-1/+1
|/ / / /
* | | | Merge pull request #17470 from keikun17/masterZachary Scott2014-10-311-2/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Fix line break on asset pipeline guide
| * | | | Fix break on generated htmlCakey | Buddy Magsipoc2014-11-011-2/+1
|/ / / / | | | | | | | | | | | | | | | | fixes this : ![http://i.imgur.com/86scI3a.png](http://i.imgur.com/86scI3a.png))
* | | | remove unused and untested APIAaron Patterson2014-10-311-6/+2
| | | |
* | | | fix set_pk_sequence and add a test for it.Aaron Patterson2014-10-312-1/+9
| | | |
* | | | Added region sequencing of primary keys for Postgres.Joe Rafaniello2014-10-311-0/+21
|/ / / | | | | | | | | | | | | | | | | | | Skip setting sequence on a table create if the value is 0 since it will start the first value at 1 anyway. This fixes the PG error 'setval: value 0 is out of bounds for sequence vms_id_seq...' encountered when migrating a new DB. BugzID: 15452,9772,13475,16850
* | | Don't attempt to load the schema file in tests if none existsSean Griffin2014-10-312-3/+18
| | |
* | | Don't modify the columns hash to set defaults from the attributes APISean Griffin2014-10-313-14/+39
| | | | | | | | | | | | | | | Nothing is directly using the columns for the default values anymore. This step helps us get closer not not mutating the columns hash.
* | | Load test schema even if there are no migrationsSean Griffin2014-10-312-1/+18
| | | | | | | | | | | | Fixes #17170
* | | Merge pull request #17040 from clyfe/patch-1Rafael Mendonça França2014-10-311-2/+4
|\ \ \ | | | | | | | | Explicit route test class
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 11:43:45 +0000