Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | | | fix deprecation test | Aaron Patterson | 2013-05-10 | 1 | -0/+2 | |
| | | | | | | | | ||||||
| * | | | | | | | push merge code to the callback itself | Aaron Patterson | 2013-05-10 | 1 | -18/+10 | |
| | | | | | | | | ||||||
| * | | | | | | | dup the callback and set the chain | Aaron Patterson | 2013-05-10 | 1 | -8/+8 | |
| | | | | | | | | ||||||
| * | | | | | | | remove klass because it is not used | Aaron Patterson | 2013-05-10 | 1 | -9/+7 | |
| | | | | | | | | ||||||
| * | | | | | | | rename instance variables | Aaron Patterson | 2013-05-10 | 1 | -12/+14 | |
| | | | | | | | | ||||||
| * | | | | | | | push duplicates? logic to the instance | Aaron Patterson | 2013-05-10 | 1 | -16/+7 | |
| | | | | | | | | ||||||
| * | | | | | | | callback chain is in charge of the cache, so remove method based cache | Aaron Patterson | 2013-05-10 | 1 | -21/+0 | |
| | | | | | | | | ||||||
| * | | | | | | | __define_callbacks method is not necessary anymore | Aaron Patterson | 2013-05-10 | 1 | -8/+1 | |
| | | | | | | | | ||||||
| * | | | | | | | just run compiled callbacks since they are cached | Aaron Patterson | 2013-05-10 | 1 | -14/+4 | |
| | | | | | | | | ||||||
| * | | | | | | | cache compiled callbacks | Aaron Patterson | 2013-05-10 | 1 | -7/+27 | |
| | | | | | | | | ||||||
| * | | | | | | | use delegation over inheritance so we can figure when to cache / bust cache | Aaron Patterson | 2013-05-10 | 1 | -5/+22 | |
| | | | | | | | | ||||||
| * | | | | | | | fixing activemodel tests | Aaron Patterson | 2013-05-10 | 1 | -1/+2 | |
| | | | | | | | | ||||||
| * | | | | | | | use an environment object to hold state about the filter calls | Aaron Patterson | 2013-05-10 | 1 | -21/+41 | |
| | | | | | | | | ||||||
| * | | | | | | | object based callbacks cannot be duplicated | Aaron Patterson | 2013-05-10 | 1 | -7/+4 | |
| | | | | | | | | ||||||
| * | | | | | | | pass the run block as a normal variable to the rest of the callbacks | Aaron Patterson | 2013-05-10 | 1 | -12/+12 | |
| | | | | | | | | ||||||
| * | | | | | | | fixing more variable names | Aaron Patterson | 2013-05-10 | 1 | -10/+10 | |
| | | | | | | | | ||||||
| * | | | | | | | fix variable name | Aaron Patterson | 2013-05-10 | 1 | -6/+6 | |
| | | | | | | | | ||||||
| * | | | | | | | reduce the number of lambas | Aaron Patterson | 2013-05-10 | 1 | -5/+2 | |
| | | | | | | | | ||||||
| * | | | | | | | callback sequence is no longer used | Aaron Patterson | 2013-05-10 | 1 | -6/+0 | |
| | | | | | | | | ||||||
| * | | | | | | | no need for variable assignments, just pass the values in | Aaron Patterson | 2013-05-10 | 1 | -6/+2 | |
| | | | | | | | | ||||||
| * | | | | | | | make_lambda is never called with an Array | Aaron Patterson | 2013-05-10 | 1 | -2/+0 | |
| | | | | | | | | ||||||
| * | | | | | | | callbacks are wrapped with lambdas | Aaron Patterson | 2013-05-10 | 3 | -108/+78 | |
| | | | | | | | | ||||||
| * | | | | | | | remove dead code | Aaron Patterson | 2013-05-10 | 1 | -10/+0 | |
| | | | | | | | | ||||||
| * | | | | | | | fix method names | Aaron Patterson | 2013-05-10 | 1 | -40/+44 | |
| | | | | | | | | ||||||
| * | | | | | | | using lambas for the callback bodies | Aaron Patterson | 2013-05-10 | 1 | -32/+12 | |
| | | | | | | | | ||||||
| * | | | | | | | wrap all options in lambas | Aaron Patterson | 2013-05-10 | 1 | -7/+13 | |
| | | | | | | | | ||||||
| * | | | | | | | conditions in callbacks return consistent lambdas | Aaron Patterson | 2013-05-10 | 1 | -9/+43 | |
| | | | | | | | | ||||||
* | | | | | | | | Merge pull request #10600 from aditya-kapoor/code_refactor | Rafael Mendonça França | 2013-05-14 | 1 | -11/+9 | |
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | | Removed Class Eval and used define_method instead for the SafeBuffer | |||||
| * | | | | | | | Added a blank space and removed to_sym | aditya-kapoor | 2013-05-14 | 1 | -4/+5 | |
| | | | | | | | | ||||||
| * | | | | | | | Removed Class Eval and used define_method instead for the SafeBuffer | aditya-kapoor | 2013-05-14 | 1 | -12/+9 | |
| | |/ / / / / | |/| | | | | | ||||||
* | | | | | | | private callback methods should work | Aaron Patterson | 2013-05-14 | 1 | -1/+2 | |
| | | | | | | | ||||||
* | | | | | | | Update mail to minimum version 2.5.4 | Mikel Lindsaar | 2013-05-14 | 1 | -1/+1 | |
| |_|_|/ / / |/| | | | | | ||||||
* | | | | | | adding more callback type coverage | Aaron Patterson | 2013-05-13 | 1 | -0/+40 | |
| |_|/ / / |/| | | | | ||||||
* | | | | | extract getting an setting callbacks to methods | Aaron Patterson | 2013-05-13 | 1 | -15/+22 | |
| | | | | | ||||||
* | | | | | call extracted method from callback manipulation methods | Aaron Patterson | 2013-05-13 | 1 | -6/+8 | |
| | | | | | ||||||
* | | | | | extract callback param munging | Aaron Patterson | 2013-05-13 | 1 | -3/+8 | |
| | | | | | ||||||
* | | | | | no reason to make these defaulted, we always pass values in | Aaron Patterson | 2013-05-13 | 1 | -1/+1 | |
|/ / / / | ||||||
* | | | | add tests for reset_calbacks | Aaron Patterson | 2013-05-13 | 1 | -0/+40 | |
| | | | | ||||||
* | | | | Merge pull request #10592 from arunagw/build-fix-flash-hash | Rafael Mendonça França | 2013-05-13 | 1 | -2/+2 | |
|\ \ \ \ | |_|_|/ |/| | | | Fixing build broken by this change | |||||
| * | | | Fixing build broken by this change | Arun Agrawal | 2013-05-13 | 1 | -2/+2 | |
|/ / / | | | | | | | | | | c43ca06ca091fc09e2c86bb051ac92b648f12b64 | |||||
* | | | Merge pull request #10587 from vipulnsward/indent_var | Rafael Mendonça França | 2013-05-12 | 1 | -1/+2 | |
|\ \ \ | | | | | | | | | Extract variable out of loop | |||||
| * | | | Extract variable out of loop | Vipul A M | 2013-05-13 | 1 | -1/+2 | |
| | | | | ||||||
* | | | | Merge pull request #10584 from alindeman/range-missing-alias-attribute | Rafael Mendonça França | 2013-05-12 | 2 | -0/+4 | |
|\ \ \ \ | | | | | | | | | | | Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext | |||||
| * | | | | Fixes NoMethodError: `alias_method_chain` when requiring just ↵ | Andy Lindeman | 2013-05-12 | 2 | -0/+4 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | active_support/core_ext * Each file that uses `alias_method_chain` brings it in explicitly | |||||
* | | | | Merge pull request #10586 from AJ-Acevedo/comments | Rafael Mendonça França | 2013-05-12 | 1 | -1/+1 | |
|\ \ \ \ | |/ / / |/| | | | Updated comment to Rails 4 | |||||
| * | | | Updated comment to Rails 4 | AJ Acevedo | 2013-05-12 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge pull request #10581 from shime/better-generator-error | Rafael Mendonça França | 2013-05-12 | 1 | -1/+9 | |
|\ \ \ | | | | | | | | | better error message when app name is not passed in `rails new` | |||||
| * | | | better error message when app name is not passed in `rails new` | Hrvoje Šimić | 2013-05-12 | 1 | -1/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this change, for the following command: $ rails new we received "Options should be given after the application name" as an error message. This is outdated and should be "Application name should be provided in arguments". | |||||
* | | | | Merge pull request #10580 from CodeTag/master | Guillermo Iguaran | 2013-05-12 | 1 | -9/+3 | |
|\ \ \ \ | |/ / / |/| | | | Code cleanup for ActionDispatch::Flash#call | |||||
| * | | | Code cleanup for ActionDispatch::Flash#call | Julian Vargas | 2013-05-12 | 1 | -9/+3 | |
|/ / / | | | | | | | | | | | | | | | | | | | The nested `if` was replaced by using `presence` which takes account for the given hash when it is `nil` or when it is empty. The `else` was removed because what it was doing was to assign to `env[KEY]` the value it already had. |