Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make use of helpers in AssociationReflection | Jon Leighton | 2011-01-30 | 1 | -4/+4 |
| | |||||
* | Has many through - It is not necessary to manually merge in the conditions ↵ | Jon Leighton | 2011-01-30 | 4 | -6/+16 |
| | | | | hash for the through record, because the creation is done directly on the through association, which will already handle setting the conditions. | ||||
* | @join_table_name is no longer used | Jon Leighton | 2011-01-30 | 1 | -2/+1 |
| | |||||
* | Make AssociationCollection#include? a bit more readable | Jon Leighton | 2011-01-30 | 1 | -4/+10 |
| | |||||
* | Don't use method_missing when we don't have to | Jon Leighton | 2011-01-30 | 1 | -2/+2 |
| | |||||
* | AssociationCollection#clear can basically just use #delete_all, except it ↵ | Jon Leighton | 2011-01-30 | 2 | -16/+13 |
| | | | | should return self. | ||||
* | AssociationCollection#to_ary should definitely dup the target! Also changed ↵ | Jon Leighton | 2011-01-30 | 2 | -3/+10 |
| | | | | #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping. | ||||
* | Just use primary_key here, AR::Relation will resolve the ambiguity before it ↵ | Jon Leighton | 2011-01-30 | 1 | -1/+1 |
| | | | | is converted to SQL | ||||
* | Call sum on the scope directly, rather than relying on method_missing and ↵ | Jon Leighton | 2011-01-30 | 1 | -2/+2 |
| | | | | calculate | ||||
* | Condense first_or_last a bit more | Jon Leighton | 2011-01-30 | 1 | -7/+5 |
| | |||||
* | Get rid of separate reset_target! and reset_scopes_cache! methods | Jon Leighton | 2011-01-30 | 1 | -26/+17 |
| | |||||
* | target is always an array | Jon Leighton | 2011-01-30 | 1 | -5/+0 |
| | |||||
* | load_target will return the target. it also will not load if loaded? is true. | Jon Leighton | 2011-01-30 | 1 | -2/+1 |
| | |||||
* | DRY up first/last and hence make last benefit from the bugfix in first | Jon Leighton | 2011-01-30 | 2 | -15/+19 |
| | |||||
* | Use scoped.find directly rather than having a find_by_sql method | Jon Leighton | 2011-01-30 | 1 | -5/+1 |
| | |||||
* | Use scoped.first and scoped.last instead of find(:first, ...) and ↵ | Jon Leighton | 2011-01-30 | 1 | -2/+2 |
| | | | | find(:last, ...) | ||||
* | Try to make fetch_first_or_last_using_find? more readable | Jon Leighton | 2011-01-30 | 1 | -2/+20 |
| | |||||
* | load_target returns the target | Jon Leighton | 2011-01-30 | 1 | -2/+1 |
| | |||||
* | Rename AssociationProxy#loaded to loaded! as it mutates the association | Jon Leighton | 2011-01-30 | 6 | -10/+10 |
| | |||||
* | Abstract load_target conditional logic | Jon Leighton | 2011-01-30 | 2 | -6/+7 |
| | |||||
* | Remove unused methods conditions, sql_conditions and sanitize_sql | Jon Leighton | 2011-01-30 | 1 | -12/+0 |
| | |||||
* | Don't pass around conditions as strings in ThroughAssociation | Jon Leighton | 2011-01-30 | 1 | -30/+25 |
| | |||||
* | Indent methods under private/protected sections | Jon Leighton | 2011-01-30 | 2 | -115/+115 |
| | |||||
* | Let's be less blasé about method visibility on association proxies | Jon Leighton | 2011-01-30 | 9 | -117/+135 |
| | |||||
* | We shouldn't be using scoped.scoping { ... } to build associated records, as ↵ | Jon Leighton | 2011-01-30 | 6 | -17/+57 |
| | | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved] | ||||
* | Merge branch 'fix-gitignore' of https://github.com/telemachus/rails into ↵ | Mikel Lindsaar | 2011-01-30 | 1 | -1/+1 |
|\ | | | | | | | telemachus-fix-gitignore | ||||
| * | Minor fix to gitignore syntax | Peter Aronoff | 2011-01-14 | 1 | -1/+1 |
| | | |||||
* | | Test non zero exit code and that a message still appears when generating ↵ | Philip Arndt | 2011-01-29 | 1 | -0/+11 |
| | | | | | | | | inside an existing Rails directory. | ||||
* | | Dir.chdir is not useful in this test, that was for another one I am planning ↵ | Philip Arndt | 2011-01-29 | 1 | -4/+3 |
| | | | | | | | | to do. | ||||
* | | Added test to ensure non zero exit codes when generating an application with ↵ | Philip Arndt | 2011-01-29 | 1 | -0/+7 |
| | | | | | | | | | | | | a reserved name. Unfortunately, I can't find out how to suppress its output so we see ....Invalid application name test. Please give a name which does not match one of the reserved rails words..................................... | ||||
* | | Exit with non-zero to signal failure. | Philip Arndt | 2011-01-29 | 1 | -1/+1 |
| | | |||||
* | | Use exit(1) instead of exit(false) | Philip Arndt | 2011-01-29 | 1 | -2/+2 |
| | | |||||
* | | Use Thor's self.exit_on_failure? to exit whenever accessing the generators ↵ | Philip Arndt | 2011-01-29 | 1 | -0/+12 |
| | | | | | | | | from the CLI and a Thor::Error is raised. | ||||
* | | Apply exit code 1 when commands don't succeed so that other libraries can ↵ | Philip Arndt | 2011-01-29 | 1 | -0/+2 |
| | | | | | | | | properly detect the failure. | ||||
* | | always return the identity function from type_cast_code | Aaron Patterson | 2011-01-28 | 1 | -1/+1 |
| | | |||||
* | | use an identity conversion to avoid conditional codes | Aaron Patterson | 2011-01-28 | 2 | -4/+4 |
| | | |||||
* | | Fixing incorrectly writtent testcase | Alexey Nayden | 2011-01-28 | 1 | -2/+2 |
| | | |||||
* | | Nested attributes and in-memory changed values #first and #[] behaviour ↵ | Alexey Nayden | 2011-01-28 | 1 | -1/+1 |
| | | | | | | | | consistency fix | ||||
* | | test_first_and_array_index_zero_methods_return_the_same_value_when_nested_at ↵ | Alexey Nayden | 2011-01-28 | 1 | -0/+9 |
| | | | | | | | | tributes_are_set_to_update_existing_record added | ||||
* | | make sure we play nicely when syck is activated | Aaron Patterson | 2011-01-28 | 2 | -5/+30 |
| | | |||||
* | | Psych correctly gets visitor for SafeBuffer from superclass | brainopia | 2011-01-28 | 1 | -2/+5 |
| | | |||||
* | | Remove unneeded yaml_as declaration | brainopia | 2011-01-28 | 1 | -2/+0 |
| | | |||||
* | | load psych by default if possible | Aaron Patterson | 2011-01-28 | 1 | -0/+5 |
| | | |||||
* | | Bump mail version up | Santiago Pastorino | 2011-01-28 | 1 | -1/+1 |
| | | |||||
* | | render_to_string must ensure that response_body | Neeraj Singh | 2011-01-25 | 2 | -1/+11 |
| | | | | | | | | | | | | | | | | is nil [ #5875 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | If I want to set respond_body to nil then it | Neeraj Singh | 2011-01-25 | 1 | -1/+1 |
| | | | | | | | | | | | | | | should be nil and not [nil]. If anything other than nil then wrap it in array Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | A patch so that http status codes are still included in logs even during an ↵ | Doug Fales | 2011-01-25 | 2 | -1/+20 |
| | | | | | | | | | | | | exception [#6333 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | load and prefer psych as the YAML parser when it is available | Aaron Patterson | 2011-01-21 | 3 | -0/+17 |
| | | |||||
* | | use spec compliant YAML | Aaron Patterson | 2011-01-21 | 1 | -1/+1 |
| | | |||||
* | | psych does not emit a space after the tag | Aaron Patterson | 2011-01-21 | 1 | -1/+1 |
| | |