| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ /
| |
| |
| |
| |
| | |
assertion for
https://github.com/rails/rails/blob/ad624345e54bd20802de67b2b5c9ef29ecf5
d5f4/activerecord/lib/active_record/inheritance.rb#L32
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fixed tests `to_time` returning an instance of `Time` in the local system timezone.
Tests for to_time returning an instance of Time in the local system timezone did not take in account DST when they used mixed timezone declarations like 'US/Eastern' and '-0500'.
Replaced timezone with DST by timezone without DST.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Change from each to each_value on hash to avoid unused variable warning
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Address ActiveRecord::StatementInvalid: OCIError: ORA-00979
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
document habtm join-table name with custom prefix [ci skip]
|
|/ /
| |
| |
| |
| |
| | |
Closes #9643.
The logic was introduced with 46492949
|
|\ \
| | |
| | | |
Make sure that debugger isn't included in production environment.
|
|/ / |
|
| |
| |
| |
| | |
Take the opportunity to showcase where.not.
|
|\ \
| | |
| | | |
Include Montevideo time zone in list of aliases. Closes #9628
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
Uniqueness validation uses a proc to specify the `:conditions` option.
This is a follow up to #5321 and follows the general direction in
AR to make things lazy evaluated.
|
| | |/
| |/|
| | |
| | |
| | | |
This is a follow up to #5321 and follows the general direction in
AR to make things lazy evaluated.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
Bugfix for enable_extension in postgresql_adapter.
The use of quotations is required to install extensions with certain
characters in them (e.g. uuid-ossp).
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The use of quotations is required to install extensions with certain
characters in them (e.g. uuid-ossp).
removes CHANGELOG entry
Deemed unnecessary.
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Access an instance's connection via its class, rather than via #connection
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This allows end-users to have a `connection` method on their models
without clashing with ActiveRecord internals.
|
|\ \ \ \
| | | | |
| | | | | |
Use AS::Notifications to instrument Strong Params
|
| | | | | |
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This should fix travis. For real this time! This is the one!
The readpartial(100) meant that an earlier assert_stdout could chomp up
the output that a later assert_stdout wants, meaning that the later
assertion fails.
Reading only 1 byte at a time ensure that we don't read any more than is
necessary to verify the assertion.
|
|\ \ \ \
| | | | |
| | | | | |
Use "Fixes" in place of "Fix" in changelogs for consistency [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Update documentation for collection<< to reflect behavior for new parent objects.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
collection<< does not automatically fire update sql unless the parent object
is not a new record (and thus has a primary key).
eg:
p = Post.new
p.comments << Comment.new
does not call update sql until:
p.save
at which point it saves the parent object and then the collection object.
changes that to the
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This replicates the situation described in
https://github.com/rails/strong_parameters/issues/114
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
this was pulled out of Rails 4, see rails/rails#8399 for the discussion
|
| | | | | |
|
| | | | |
| | | | |
| | | | | |
if there's content for the right column, then we need the two-column class, if not the one-column
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This should fix travis.
Also ensuring that we don't try to kill when pid is nil.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Renumbering the comments in the application boot process.
|
|/ / / / / |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
ensure response.stream is closed
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Preserve magic comments and content encoding of copied migrations.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
During insertion of "# This migration comes from ... " comment at the beginning of
a migration, presence of magic comment was not considered.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix incorrectly appended square brackets to a multiple select box
Before:
select(:category, [], {}, {:multiple => true, :name => "post[category][]"})
# => <select name="post[category][][]" ...>
After:
select(:category, [], {}, {:multiple => true, :name => "post[category][]"})
# => <select name="post[category][]" ...>
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If an explicit name has been given and it already ends with "[]"
Before:
select(:category, [], {}, multiple: true, name: "post[category][]")
# => <select name="post[category][][]" ...>
After:
select(:category, [], {}, multiple: true, name: "post[category][]")
# => <select name="post[category][]" ...>
|