Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | deprecate Proc#bind that can cause symbol memory leak | Sergey Nartimov | 2012-03-22 | 3 | -6/+11 |
| | |||||
* | Merge pull request #5540 from mhfs/another_blank_line_fix | Piotr Sarnacki | 2012-03-21 | 2 | -2/+1 |
|\ | | | | | Avoid another blank line in generated migration and remove assertion as per @spastorino request | ||||
| * | Avoid another blank line in generated migration and remove assertion as per ↵ | Marcelo Silveira | 2012-03-21 | 2 | -2/+1 |
| | | | | | | | | @spastorino request | ||||
* | | remove duplicate requires. thanks @atambo | Aaron Patterson | 2012-03-21 | 1 | -1/+0 |
| | | |||||
* | | evented listeners can subscribe to any message | Aaron Patterson | 2012-03-21 | 1 | -9/+27 |
| | | |||||
* | | evented subscribers work | Aaron Patterson | 2012-03-21 | 1 | -6/+10 |
| | | |||||
* | | start / finish events are sent by the instrumenter | Aaron Patterson | 2012-03-21 | 2 | -7/+41 |
| | | |||||
* | | push the autoloads up to requires | Aaron Patterson | 2012-03-21 | 1 | -4/+4 |
|/ | |||||
* | Deprecate eager-evaluated scopes. | Jon Leighton | 2012-03-21 | 20 | -83/+159 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions | ||||
* | Avoid obscure &Proc.new thing | Jon Leighton | 2012-03-21 | 1 | -2/+2 |
| | |||||
* | Remove valid_scope_name? check - use ruby | Jon Leighton | 2012-03-21 | 2 | -30/+1 |
| | | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods. | ||||
* | no need for cast | Jon Leighton | 2012-03-21 | 1 | -1/+0 |
| | |||||
* | no need for lvar | Jon Leighton | 2012-03-21 | 1 | -3/+1 |
| | |||||
* | split subscribers based on pattern type | Aaron Patterson | 2012-03-21 | 1 | -13/+31 |
| | |||||
* | Merge pull request #5532 from mhfs/migration_blank_line | José Valim | 2012-03-21 | 2 | -1/+2 |
|\ | | | | | Remove blank line from generated migration | ||||
| * | Remove blank line from generated migration | Marcelo Silveira | 2012-03-20 | 2 | -1/+2 |
| | | |||||
* | | Merge pull request #5522 from ↵ | José Valim | 2012-03-21 | 2 | -0/+21 |
|\ \ | |/ |/| | | | | | travisjeffery/fix_migration_generator_adding_removing_index Fix adding/removing field's index when generating migration | ||||
| * | Generate Migration Thats Adds Removed Index | Travis Jeffery | 2012-03-21 | 2 | -0/+21 |
|/ | | | | | When generating a migration that removes a field with an index, the down will add both the field and its index. | ||||
* | We dont need to merge in the parameters as thats all being reset by the rack ↵ | David Heinemeier Hansson | 2012-03-20 | 1 | -1/+0 |
| | | | | headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing) | ||||
* | probably should require the objects we monkey patch. | Aaron Patterson | 2012-03-20 | 1 | -0/+1 |
| | |||||
* | search private and protected methods for convert_key | Aaron Patterson | 2012-03-20 | 2 | -3/+3 |
| | |||||
* | bigdecimal can be duped on Ruby 2.0 | Aaron Patterson | 2012-03-20 | 2 | -2/+22 |
| | |||||
* | guides location has changed [ci skip] | Vijay Dev | 2012-03-20 | 1 | -1/+1 |
| | |||||
* | Merge pull request #5524 from kennyj/add_missing_require | Xavier Noria | 2012-03-20 | 1 | -0/+1 |
|\ | | | | | Add missing require | ||||
| * | Add missing require | kennyj | 2012-03-20 | 1 | -0/+1 |
|/ | |||||
* | Merge pull request #5515 from rafaelfranca/remove-exclude | José Valim | 2012-03-19 | 2 | -14/+29 |
|\ | | | | | Remove exclude option from ActionDispatch::SSL and fix secure cookies | ||||
| * | Fix secure cookies when there are more than one space before the secure | Rafael Mendonça França | 2012-03-19 | 2 | -1/+29 |
| | | | | | | | | keyword | ||||
| * | Remove exclude option from ActionDispatch::SSL | Rafael Mendonça França | 2012-03-19 | 2 | -13/+0 |
|/ | |||||
* | Merge pull request #5503 from jeyb/leap_day_time_date_time_selector | Andrew White | 2012-03-19 | 3 | -13/+27 |
|\ | | | | | Fixes issue #5222: DateTimeSelector builds invalid dates on leap days | ||||
| * | Fixes issue #5222: DateTimeSelector builds invalid dates on leap day when ↵ | Jey Balachandran | 2012-03-18 | 3 | -13/+27 |
| | | | | | | | | discarding both day and month. | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-19 | 9 | -23/+122 |
|\ \ | |||||
| * | | -h also shows help options. | Sandeep | 2012-03-19 | 1 | -1/+1 |
| | | | |||||
| * | | respond_with description: changed 'response' to 'format' | Mark Thomson | 2012-03-18 | 1 | -1/+1 |
| | | | |||||
| * | | Revised comments for respond_with | Mark Thomson | 2012-03-18 | 1 | -17/+18 |
| | | | |||||
| * | | Merge remote-tracking branch 'origin/master' | Mark Thomson | 2012-03-17 | 7 | -3/+5 |
| |\ \ | |||||
| | * | | [getting started] Explain what the create action is accomplishing after ↵ | Ryan Bigg | 2012-03-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | params are output [ci skip] | ||||
| | * | | [getting started] [ci skip] Explain in better terms what we are doing with ↵ | Ryan Bigg | 2012-03-17 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | render and params[:post] inspection upon first use | ||||
| | * | | [getting started] [ci skip] Just want to get post params | Ryan Bigg | 2012-03-17 | 1 | -1/+1 |
| | | | | |||||
| | * | | [getting started] Add images | Ryan Bigg | 2012-03-17 | 6 | -0/+0 |
| | | | | |||||
| * | | | Merge remote-tracking branch 'origin/master' | Mark Thomson | 2012-03-17 | 533 | -11025/+2734 |
| |\| | | |||||
| * | | | Revised description for responds_with | Mark Thomson | 2012-03-17 | 1 | -19/+115 |
| | | | | |||||
* | | | | Merge pull request #5507 from sandeepravi/warning_fixes | Xavier Noria | 2012-03-19 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | changed all.map to pluck | ||||
| * | | | | changed all.map to pluck | Sandeep | 2012-03-19 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #5508 from FND/tagged_logger_shortcut | José Valim | 2012-03-19 | 2 | -2/+7 |
|\ \ \ \ \ | |/ / / / |/| | | | | Provide access to logger instance within TaggedLogging blocks | ||||
| * | | | | Provide access to logger instance within TaggedLogging blocks | FND | 2012-03-19 | 2 | -2/+7 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this improves encapsulation, simplifying occurrences like the following: Rails.logger.tagged("DEBUG") { Rails.logger.debug(msg) } ... by removing the need to rely on (i.e. repeat) outer variables: Rails.logger.tagged("DEBUG") { |logger| logger.debug(msg) } | ||||
* | | / | Increase minimum version of mail. | Mikel Lindsaar | 2012-03-19 | 1 | -1/+1 |
| |_|/ |/| | | | | | | | | | | | Second security vulnerability found in mail file delivery method patched in version 2.4.4. | ||||
* | | | Merge pull request #5492 from arunagw/build_fix_app_generator_test | Piotr Sarnacki | 2012-03-18 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Build fix for app_generator_test.rb | ||||
| * | | | Build fix for app_generator_test.rb | Arun Agrawal | 2012-03-18 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #3329 from armstrjare/autosave_collection_new_record_bug | José Valim | 2012-03-18 | 2 | -1/+16 |
|\ \ \ \ | | | | | | | | | | | Autosave association doesn't save all records on a new record for a collection association if there are records marked for destruction | ||||
| * | | | | Fix bug with autosave collection association on new record with a marked for ↵ | Jared Armstrong | 2012-03-18 | 2 | -1/+16 |
| | | | | | | | | | | | | | | | | | | | | destroy record in autosave collection. |