aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* List assert_{,no_}changes in the testing guideGenadi Samokovarov2017-05-291-0/+2
| | | | | This lists the `assert_changes` and `assert_no_changes` methods in the guides. [ci skip]
* Merge pull request #29208 from ↵Guillermo Iguaran2017-05-283-2/+13
|\ | | | | | | | | kamipo/default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is an empty string
| * `DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is ↵Ryuta Kamizono2017-05-253-2/+13
| | | | | | | | | | | | an empty string Follow up of #27399.
* | Merge pull request #29262 from ↵Guillermo Iguaran2017-05-283-2/+36
|\ \ | | | | | | | | | | | | kamipo/deprecate_passing_arguments_with_block_to_count_and_sum Deprecate passing arguments and block at the same time to `count` and `sum` in `ActiveRecord::Calculations`
| * | Deprecate passing arguments and block at the same time to `count` and `sum` ↵Ryuta Kamizono2017-05-293-2/+36
|/ / | | | | | | | | | | | | | | in `ActiveRecord::Calculations` `select`, `count`, and `sum` in `Relation` are also `Enumerable` method that can be passed block. `select` with block already doesn't take arguments since 4fc3366. This is follow up of that.
* | Merge pull request #29258 from koic/remove_redundant_command_recorder_testMatthew Draper2017-05-291-5/+0
|\ \ | | | | | | Remove a redundant test case of command_recorder_test
| * | Remove a redundant test case of command_recorder_testKoichi ITO2017-05-291-5/+0
| | |
* | | Merge pull request #29257 from ↵Kasper Timm Hansen2017-05-281-3/+1
|\ \ \ | | | | | | | | | | | | | | | | clupprich/remove-action-dispatch-callbacks-to-prepare-mention Remove mentions of deprecated callbacks on ActionDispatch::Callbacks
| * | | Remove mentions of deprecated callbacks on ActionDispatch::CallbacksChristoph Lupprich2017-05-281-3/+1
| | | | | | | | | | | | | | | | | | | | ActionDispatch::Callbacks.to_prepare was removed in #27587 [ci skip]
* | | | Merge pull request #29146 from y-yagi/fix_29138Kasper Timm Hansen2017-05-282-2/+15
|\ \ \ \ | | | | | | | | | | Correctly set user_supplied_options when there is no whitespace in option specification
| * | | | Correctly set user_supplied_options when there is no whitespace in option ↵yuuji.yaginuma2017-05-242-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | specification Current `user_supplied_options` method can not set the value correctly if there is no space between option and value (e.g., `-p9000`). This makes it possible to set the value correctly in the case like the above. Fixes #29138
* | | | | Merge pull request #29108 from inopinatus/ujs-sgjs-ie9-supportKasper Timm Hansen2017-05-281-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix server-generated JS response processing on IE9
| * | | | | Fix server-generated JS response processing on IE9 when using rails-ujs and ↵Josh Goodall2017-05-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | remote: true
* | | | | | Merge pull request #29074 from ↵Kasper Timm Hansen2017-05-283-13/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/remove_returning_true_in_internal_callbacks Remove returning true in internal callbacks
| * | | | | | Remove returning true in internal callbacksRyuta Kamizono2017-05-143-13/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `display_deprecation_warning_for_false_terminator` was removed since 3a25cdc.
* | | | | | | Merge pull request #28132 from mikeycgto/aead-encrypted-cookiesKasper Timm Hansen2017-05-2810-108/+295
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | AEAD encrypted cookies and sessions
| * | | | | | | AEAD encrypted cookies and sessionsMichael Coyne2017-05-2210-108/+295
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes encrypted cookies from AES in CBC HMAC mode to Authenticated Encryption using AES-GCM. It also provides a cookie jar to transparently upgrade encrypted cookies to this new scheme. Some other notable changes include: - There is a new application configuration value: +use_authenticated_cookie_encryption+. When enabled, AEAD encrypted cookies will be used. - +cookies.signed+ does not raise a +TypeError+ now if the name of an encrypted cookie is used. Encrypted cookies using the same key as signed cookies would be verified and serialization would then fail due the message still be encrypted.
* | | | | | | | Merge pull request #29253 from kamipo/prevent_extra_queryMatthew Draper2017-05-292-6/+12
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype`
| * | | | | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype`Ryuta Kamizono2017-05-282-6/+12
| | | | | | | |
* | | | | | | | Merge pull request #28969 from ↵Matthew Draper2017-05-284-14/+16
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/refactor_enum_to_use_value_instead_of_label Refactor enum to use `value` instead of `label` in the scope
| * | | | | | | | Refactor enum to use `value` instead of `label` in the scopeRyuta Kamizono2017-05-074-14/+16
| | | | | | | | |
* | | | | | | | | Merge pull request #29003 from kamipo/delegate_ast_and_locked_to_arel_explicitlyMatthew Draper2017-05-284-1/+13
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | Delegate `ast` and `locked` to `arel` explicitly
| * | | | | | | | Delegate `ast` and `locked` to `arel` explicitlyRyuta Kamizono2017-05-064-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `ast` and `locked` are used in the internal but delegating to `arel` is depend on `method_missing`. If a model class is defined these methods, `select_all` will be broken. It should be delegated to `arel` explicitly.
* | | | | | | | | Merge pull request #29097 from ↵Matthew Draper2017-05-283-6/+20
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EilisHamilton/fix_uncountable_pluralization_locale Fix pluralization of uncountables when given a locale
| * | | | | | | | | Fix pluralization of uncountables when given a localeEilis Hamilton2017-05-193-6/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously apply_inflections would only use the :en uncountables rather then the ones for the locale that was passed to pluralize or singularize. This changes apply_inflections to take a locale which it will use to find the uncountables.
* | | | | | | | | | Merge pull request #29197 from kamipo/enable_extending_even_if_scope_returns_nilMatthew Draper2017-05-282-7/+7
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Enable extending even if scope returns nil
| * | | | | | | | | | Enable extending even if scope returns nilRyuta Kamizono2017-05-242-7/+7
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #29250 from kamipo/remove_unused_association_interpolateMatthew Draper2017-05-281-8/+0
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Remove unused `Association#interpolate`
| * | | | | | | | | | | Remove unused `Association#interpolate`Ryuta Kamizono2017-05-281-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `Association#interpolate` was removed since #11251.
* | | | | | | | | | | | Merge pull request #29255 from y-yagi/bring_back_delayed_job_to_integration_testKasper Timm Hansen2017-05-282-6/+5
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Bring back delayed_job to test list
| * | | | | | | | | | | | Bring back delayed_job to test listyuuji.yaginuma2017-05-281-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `delayed_job_active_record` 4.1.2 supports Rails 5.1. Ref: https://github.com/collectiveidea/delayed_job_active_record/pull/138
| * | | | | | | | | | | | Bump `delayed_job_active_record` gemyuuji.yaginuma2017-05-281-4/+4
| | | | | | | | | | | | |
* | | | | | | | | | | | | Clear all current instances before a reload.Kasper Timm Hansen2017-05-282-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If users added an attribute or otherwise changed a CurrentAttributes subclass they'd see exceptions on the next page load. Because `ActiveSupport::CurrentAttributes.current_instances` would keep references to the old instances from the previous request. We can fix this by clearing out the `current_attributes` before we unload constants. Then any change to the model can be autoloaded again since its slot isn't taken by an old instance. We'll still have to call reset before we clear so external collaborators, like Time.zone, won't linger with their current value throughout other code.
* | | | | | | | | | | | | Make reset execution assertions easier to read.Kasper Timm Hansen2017-05-281-15/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The app is booted by then, so there's no need to stash the code away in some other script.
* | | | | | | | | | | | | Remove double Thread.current storage.Kasper Timm Hansen2017-05-281-5/+3
|/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we're generating a key through the class name we can combine the two Thread.current calls into a single hash version.
* | | | | | | | | | | | Merge pull request #28895 from codeforkjeff/fix-session-keys-and-values-methodsMatthew Draper2017-05-282-0/+20
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Add lazy loading to #keys and #values methods in Session
| * | | | | | | | | | | | Add lazy loading to #keys and #values methods in Sessioncodeforkjeff2017-04-262-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug where session.keys and session.values return an empty array unless one of the other methods that does lazy loading from the underlying store is called first. #keys and #values should also call #load_for_read!
* | | | | | | | | | | | | Merge pull request #29249 from bradleypriest/numericality-precision-regressionMatthew Draper2017-05-283-1/+22
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix regression in Numericality validator
| * | | | | | | | | | | | | Fix regression in Numericality validator where extra decimal places on Bradley Priest2017-05-273-1/+22
| | |/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | a user input for a decimal column were ignored by numerically validations
* | | | | | | | | | | | | Merge pull request #29251 from y-yagi/fix_29247Matthew Draper2017-05-282-1/+6
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | | Includes namespace in system test skelton when namespace is specified
| * | | | | | | | | | | | Includes namespace in system test skelton when namespace is specifiedyuuji.yaginuma2017-05-282-1/+6
|/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #29247
* | | | | | | | | | | | Use non-raising finder.Kasper Timm Hansen2017-05-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `find` raises when it can't find a record, so we'll never reach the else. Switch to `find_by` which returns nil when no record can be found.
* | | | | | | | | | | | [ci skip] Fix spelling that's a bit of an overreach.Kasper Timm Hansen2017-05-271-1/+1
| | | | | | | | | | | |
* | | | | | | | | | | | Use models to match the docs.Kasper Timm Hansen2017-05-271-1/+1
| | | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #29246 from nihemak/fix-docs-take-firstMatthew Draper2017-05-271-3/+3
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]fix wrong variable name in docs
| * | | | | | | | | | | | [ci skip]fix wrong variable name in docsMakoto Nihei2017-05-271-3/+3
| | |_|_|_|_|_|_|_|_|/ / | |/| | | | | | | | | |
* | | | | | | | | | | | Merge pull request #29245 from nihemak/fix-docs-findRichard Schneeman2017-05-261-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | | [ci skip]fix wrong variable name in docs
| * | | | | | | | | | | [ci skip]fix wrong variable name in docsMakoto Nihei2017-05-271-1/+1
|/ / / / / / / / / / /
* | | | | | | | | | | Switch to rb-inotify masterMatthew Draper2017-05-272-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/guard/rb-inotify/pull/49 has been merged.
* | | | | | | | | | | Merge pull request #29240 from tjschuck/ar_batches_doc_updatesRafael França2017-05-261-12/+12
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Doc updates for ActiveRecord::Batches
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 12:44:55 +0000