| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Add private method primary_key_for, which more clearly shows that the
expected return value is nil when a primary key is not found.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Consistent whitespace
* Remove unnecessary parentheses
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
[guides] Use `match ..., via: :all` in the custom exceptions app [ci skip]
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Using `get` results in an unexpected error page(returning empty body) for requests of other HTTP mehtods other than GET. Use `match ..., via:
:all` so the exceptions app can be more stable.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Continuation of c9a43126c5e2c608ab3ff1be994bce69e815a144
:cry:
|
|\ \ \ \
| |/ / /
|/| | | |
Add support for Rack::ContentLength middelware
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | | |
This fixes <"SQLite3::SQLException: no such column: legacy_things.person_id: SELECT \"legacy_things\".* FROM \"legacy_things\" WHERE \"legacy_things\".\"person_id\" = ?">
in OptimisticLockingTest#test_lock_destroy
|
|\ \ \
| | | |
| | | | |
fix the undefined method content_tag #15245
|
| | | |
| | | |
| | | |
| | | | |
not required include ActionView::Helpers::TagHelper in test as well
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
jeremy/deprecate-problematic-implicit-response-splatting
Deprecate implicit AD::Response splatting and Array conversion
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[Postgresql tests] Added enable_extension! to helper
|
| | | | | |
|
| | | | | |
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Callback order in Active Record objects are important. Users should not
define callbacks before the association definition or surprising
behaviours like the described at #3798 will happen. This callback order
dependency is documented at https://github.com/rails/rails/blob/31bfcdc77ca0d8cec9b5fe513bdc6f05814dd4f1/activerecord/lib/active_record/associations.rb#L1222-1227.
This reverts #15728.
Fixes #16620.
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Propagate test messages through assert_routing helper, Fixes #14908
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
assert_routing was not raising the message passed into the assertion
violation that it raised. This change propagates messages through
the on_fail error.
This fixes this error:
https://github.com/rails/rails/issues/14908
A test case for this issue is located here.
https://github.com/estsauver/test14908
To see that test case fail in the example app, just run
ruby -Itest test/controllers/guests_controller_test.rb
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #8015, #9756.
[Fred Wu & Matthew Draper]
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
world writable might be a bit too open...
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commits e969c928463e329fd6529ac59cad96385c538ffb and
bd2b3fbe54e750ba97469a7896e8d143d6dfd465.
|
|\ \ \ \
| | | | |
| | | | | |
Freeze ADAPTER_NAME in adapters
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is cased by 03118bc + 9b5d603. The first commit referenced the undefined
local variable `column` when it should be using `reflection.type` as the lookup
key. The second commit changed `build_arel` to not modify the `bind_values` in-
place so we need to combine the arel's `bind_values` with the relation's when
building the SQL.
Fixes #16591
Related #15821 / #15892 / 7aeca50
|
|\ \ \ \
| | | | |
| | | | | |
Move variable assignment within logging block.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Time#change throws exception with an out-of-range :usec
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5
did not properly handled out-of-range `:usec`s.
Passing a `:usec` that's out of range now throws an `ArgumentError` as it
should.
Fixes #16759.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix ActiveJob rdoc `enqueue` -> `perform_later` [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Cover all cases of `For not` --> `Do not`, related to #16804
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Active Job partial refactor
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Skip StatementCache for eager loaded associations
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Eagerly loaded collection and singular associations are ignored by the StatementCache, which causes errors when the queries they generate reference columns that were not eagerly loaded.
This commit skips the creation of the StatementCache as a fix for these scenarios.
|
| | | | | | | |
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Document that method objects are not `duplicable?` [ci skip]
|
| | |_|/ / / /
| |/| | | | | |
|