| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Add Enum type to postgresql adapter's oids to prevent unknown OID warnings
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There's no need to rely on Active Support's Hash#reverse_merge for
simple cases with default values, since we can just merge from the
default rather than reverse merge from the options.
This also avoids the creation of one extra hash object by moving to a
Hash#merge! call.
|
| | |
|
|\ \
| |/
|/| |
Fixes #14254 ActionView button_tag helper default options values issue.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Add spaces to the log message of ActionController:: LogSubscriber#deep_munge
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
The 'cow' => 'kine' inflection has gone with c300dca9 but it should
not be removed from the tested irregularities since it ensures that
inflections work with words that do not begin with the same letters.
|
|\ \
| | |
| | | |
Refactor actionpack ActionDispatch::Request tests
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Fix PG warnings.
|
|/ /
| |
| |
| |
| | |
- unused variable in PG Adapter.
- Ambiguous argument warning from range_test for use - to + Infinity range without brackets.
|
|\ \
| | |
| | | |
Remove unnecessary db call when replacing.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When replacing a has_many association with the same one, there is no
need to do a round-trip to the db to create/and drop a new transaction.
[fixes #14220]
|
|\ \ \
| | | |
| | | | |
Replace map.flatten(1) with flat_map
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Avoid namespacing routes inside engines
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since #11544, invoking the controller generator, any generated route is
namespaced according to the class_path method. Since a mountable plugin
is namespaced, creating a controller inside would generate a namespaced
route based on the engine's name.
The controller generator now relies on regular_class_path which does not
contain the class hierarchy but the given path.
Fixes #14079.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
when an exception happens in an action before the response has been
committed, then we should re-raise the exception in the main thread.
This lets us reuse the existing exception handling.
|
| |/ /
|/| |
| | |
| | |
| | |
| | | |
detect the type of controller we're testing and return the right type of
response based on that controller. This allows us to stop doing the
weird sleep thing.
|
|\ \ \
| | | |
| | | | |
use `secrets.secret_key_base` instead of `config.secret_key_base`
|
| | | |
| | | |
| | | |
| | | | |
use secrets.yml instead of secret_token.rb
|
| | | |
| | | |
| | | |
| | | | |
callback and an error happens
|
|\ \ \ \
| |/ / /
|/| | | |
Correct `select` examples and doc, ref [522c0fd] [ci skip]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix a few typos. #present_in has been changed to #presence_in through
commit d61baee5.
|
|\ \ \ \
| | | | |
| | | | | |
`includes` uses SQL parsing when String joins are involved.
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a partial revert of 22b3481ba2aa55fad1f9a5db94072312b345fb55.
The current implementation of `references_eager_loaded_tables?` needs to know
every table involved in the query. With the current API this is not possible
without SQL parsing.
While a2dab46cae35a06fd5c5500037177492a047c252 deprecated SQL parsing for `includes`.
It did not issue deprecation warnings when String joins are involved. This resulted
in a breaking change after the deprecated behavior was removed (22b3481ba2aa55fad1f9a5db94072312b345fb55).
We will need to rethink the usage of `includes`, `preload` and `eager_load` but for now,
this brings back the old *working* behavior.
|
|\ \ \ \
| |/ / /
|/| | | |
Use secrets.yml instead of secret_token.rb in the docs
|
|/ / /
| | |
| | |
| | | |
controller guide
|
|\ \ \
| | | |
| | | | |
Fix a bug affecting validations of enum attributes
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes a bug where any enum attribute of a model
would be evaluated always as 0 when calling the
database on validations.
This fix converts the value of the enum attribute
to its integer value rather than the string before
building the relation as the bug occured when the
string finally gets converted to integer using
string.to_i which converts it to 0.
[Vilius Luneckas, Ahmed AbouElhamayed]
|
|\ \ \
| | | |
| | | | |
fix test cases
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Active Record is specifically for databases. Refs #12101.
|
|\ \ \ \
| | | | |
| | | | | |
Cache#fetch_multi returns a Hash instead of an Array
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The current implementation of `fetch_multi` returns an array and has no
means to easily backtrack which names yielded which results. By changing
the return value to a Hash we retain the name information. Hash#values
can be used on the response if only the values are needed.
|
|\ \ \ \
| | | | |
| | | | | |
[skip ci] Fixes docs typo in nested resource path helpers
|
| | | | | |
|