| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
actionview/README.rdoc
activerecord/lib/active_record/migration.rb
guides/source/development_dependencies_install.md
guides/source/getting_started.md
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing
changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9.
Seems to be a code merge done by mistake.
|
| |
| |
| |
| | |
messaging around 'Showing Posts' section
|
| | |
|
| | |
|
| |\ |
|
| | |
| | |
| | |
| | | |
change - https://github.com/rails/rails/commit/f038d4cc5fe1ac21f92c7e32c61ff85a0c816f3f
|
| | |
| | |
| | |
| | | |
This reverts commit 157dc275da0ad38635337b7c1d96de656d91de8e.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fixed grammar error in ordered_options documention.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Improve the testing guide [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Improve the "Testing Rails Applications" guide adding a section for
testing helpers and a little note about associations with ActiveRecord
and YAML fixtures.
Also add a link to Fixture Builder ; yet another replacement for
fixtures such as Machinist or FactoryGirl.
|
|\ \ \ \
| | | | |
| | | | | |
Use binary mode to write uploaded files [ci skip]
|
|/ / / /
| | | |
| | | |
| | | | |
http://stackoverflow.com/a/4988984/129798 for an explanation for why this is required for Ruby 1.9.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Adding LESS to rake notes
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fixing multi-word automatic inverse detection.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Currently, ActiveRecord models with multiple words cannot have their
inverse associations detected automatically.
|
|\ \ \ \
| | | | |
| | | | | |
Typo Fix[ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix assign ip address with invalid values raise exception
|
| | | | |
| | | | |
| | | | |
| | | | | |
In order that set attribute should not be bang method
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
jetthoughts/remove_redundant_assert_from_datatype_test
Removed redundant asserts for assigns attribute operation
|
|/ / / / |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Added SanitizeHelper to rails guide docs [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Added SanitizeHelper to rails guide docs [ci skip]
Added SanitizeHelper to rails guide docs update [ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Generate namespaced routes correctly for generators. Fix for #11532
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
added String#to_date documentation to Rails 4 upgrade guide [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add description of action in Getting Started Guide [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
Closes #11804
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Updated outdated initialization guide [ci skip]
|
| | | | | | | | |
|
| |/ / / / / /
|/| | | | | |
| | | | | | |
| | | | | | | |
String#gsub(pattern, '')
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
using assert_not instead of refute
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
sadjow/improve-doc-translations-active-record-models
Add plural form example for AR I18n section [ci skip]
|
|/ / / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
That is a better name, thanks @jeremy.
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
See the CHANGELONG message in the patch for further details.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Refactor Duration#inspect
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In preparing https://github.com/rails/rails/pull/11855, it took me a
minute to understand what was going on due to naming (parts refers first
to an attr_accessor, then to a local, and is then reassigned), but also
because the iterator conditionally builds nulls and then removes them.
I refactored to something much more functional-looking that I find
easier to read, but you may or may not. If you do, great! Enjoy! If
not, oh well, I tried. Can't win 'em all :)
Rationale:
* no name conflict between local var and attr_accessor
* no reassignment of local var
* algorithm spelled out in steps
* unused items in initial list filtered out early
* empty-list case handled early instead of reassigning local var
* no duplication of formatting strings ("0 seconds")
Benchmarks (after PR #11855 merged):
10000.times do
1.second.inspect
end
original #inspect
0.350000 0.000000 0.350000 ( 0.354709)
0.330000 0.000000 0.330000 ( 0.331885)
0.330000 0.000000 0.330000 ( 0.334441)
refactored #inspect
0.340000 0.000000 0.340000 ( 0.340080)
0.340000 0.010000 0.350000 ( 0.345069)
0.330000 0.000000 0.330000 ( 0.335873)
10000.times do
(1.day + 1.month + 2.minutes + 1.day).inspect
end
original #inspect
0.400000 0.000000 0.400000 ( 0.403027)
0.400000 0.000000 0.400000 ( 0.403781)
0.390000 0.000000 0.390000 ( 0.387596)
refactored #inspect
0.400000 0.010000 0.410000 ( 0.399792)
0.400000 0.000000 0.400000 ( 0.404145)
0.400000 0.000000 0.400000 ( 0.403820)
|