aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* adds more tests for the file monitorsXavier Noria2015-11-091-0/+60
|
* s/watcher/checker/gXavier Noria2015-11-081-3/+3
| | | | "checker" is the name being used everywhere.
* more ad-hoc sleepsXavier Noria2015-11-081-2/+4
| | | | This sucks, but otherwise I get occasional Fs on Mac OS X.
* create the tmpdir under testXavier Noria2015-11-081-1/+1
| | | | | Mac OS X tries by all means to hide that /var is /private/var, and that is what FSEvents reports back.
* encapsulate sleep margin when touching filesXavier Noria2015-11-081-5/+6
|
* renames the monitor creation helperXavier Noria2015-11-083-11/+11
|
* refactors the file monitors test suiteXavier Noria2015-11-083-57/+47
| | | | | In particular files are no longer created in the current working directory, but in a temporary folder.
* let listen stop all listeners on teardownXavier Noria2015-11-081-0/+5
|
* s/@modified/@updated/gXavier Noria2015-11-081-6/+6
|
* stop ascending at the longest common subpathXavier Noria2015-11-082-33/+126
| | | | This commit also bases everything on Pathname internally.
* remove unused constants in the file monitor suitesXavier Noria2015-11-082-4/+0
|
* upgrade listen to 3.0.4Xavier Noria2015-11-084-5/+5
| | | | 3.0.3 has a bug in OS X.
* document the evented file system monitor opt-in in the config guide [ci skip]Xavier Noria2015-11-081-0/+22
|
* remove explicit File.expand_path callXavier Noria2015-11-081-1/+1
|
* no need to have access to the listenerXavier Noria2015-11-081-4/+1
|
* move the listen gem in the Gemfile to the development groupXavier Noria2015-11-081-3/+4
|
* revises the implementation of the evented file monitorXavier Noria2015-11-081-24/+65
|
* initial edit pass over the evented file checker patchXavier Noria2015-11-083-41/+67
|
* implements an evented file update checker [Puneet Agarwal]Xavier Noria2015-11-089-104/+218
| | | | | | | | | | | | This is the implementation of the file update checker written by Puneet Agarwal for GSoC 2015 (except for the tiny version of the listen gem, which was 3.0.2 in the original patch). Puneet's branch became too out of sync with upstream. This is the final work in one single clean commit. Credit goes in the first line using a convention understood by the contrib app.
* Merge pull request #22230 from y-yagi/fix_method_name_typoRichard Schneeman2015-11-091-1/+1
|\ | | | | fix method name typo [ci skip]
| * fix method name typo [ci skip]yuuji.yaginuma2015-11-091-1/+1
|/
* Merge pull request #22226 from boone/docsSean Griffin2015-11-083-3/+3
|\ | | | | ActiveJob docs text fix. [ci skip]
| * Fixed wording.Mike Boone2015-11-083-3/+3
| |
* | Merge pull request #22225 from arnvald/allow_host_in_js_css_helpersSantiago Pastorino2015-11-083-2/+8
|\ \ | | | | | | Allow `host` option in javscript and css helpers
| * | Allow `host` option in javscript and css helpersGrzegorz Witek2015-11-083-2/+8
| | | | | | | | | | | | | | | Now both `javascript_include_tag` and `stylesheet_tag` can accept `host` option to provide custom host for the asset
* | | Merge pull request #22206 from grosser/grosser/drySantiago Pastorino2015-11-081-20/+15
|\ \ \ | |_|/ |/| | dry up increment/decrement
| * | dry up increment/decrementMichael Grosser2015-11-071-20/+15
| | |
* | | Merge pull request #22222 from ↵Godfrey Chan2015-11-082-1/+25
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/fix_application_controller_require_dependency_path_in_api fix application_controller require_dependency path generated by api scaffold generator
| * | | fix application_controller require_dependency path generated by api scaffold ↵yuuji.yaginuma2015-11-082-1/+25
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | generator In the app generator, regardless of the namespace, it is adapted to read the same `application_controller.rb`, modified to api generator also be the same behavior. ref 686966a1861e6761021d45f6795de753e8a62216, 06ac63b4c602e4b26cb3bfbf0dfd2bed8b00e786
* | | Merge pull request #22224 from kassio/masterRafael França2015-11-083-2/+28
|\ \ \ | |/ / |/| | Improve support for non Active Record objects on `validates_associated`
| * | Improve support for non Active Record objects on `validates_associated`Kassio Borges2015-11-083-2/+28
|/ / | | | | | | | | | | Skipping `marked_for_destruction?` when the associated object does not responds to it make easier to validate virtual associations built on top of Active Model objects and/or serialized objects that implement a `valid?` instance method.
* | Merge pull request #22218 from EhsanYousefi/patch-2Richard Schneeman2015-11-071-2/+1
|\ \ | | | | | | Fix Unnecessary variable assignment /associations/builder/belongs_to.rb#add_destroy_callbacks
| * | Update belongs_to.rbEhsan Yousefi2015-11-081-2/+1
|/ / | | | | There is no need to to assign reflection name to a variable, because it's called once.
* | Merge pull request #21897 from swaathi/masterKasper Timm Hansen2015-11-077-14/+156
|\ \ | | | | | | Parameterize with options to preserve the case of string
| * | Parameterize with options to preserve case of stringSwaathi K2015-11-077-14/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added test cases Using kwargs instead of three seperate functions Updated parameterize in transliterate.rb Updated parameterize in transliterate.rb Added deprecation warnings and updating RDoc+Guide Misspelled separtor. Fixed. Deprecated test cases and added support to parameterize with keyword parameters Squashing commits. Fixed test cases and added deprecated test cases Small changes to Gemfile.lock and CHANGELOG Update Gemfile.lock
* | | docs, get rid of artifact in `RecordFetchWarning` docs.Yves Senn2015-11-071-0/+2
| | | | | | | | | | | | | | | | | | | | | [ci skip] There was a `ActiveRecord::Relation::RecordFetchWarning::ActiveSupport` artifact caused by subscribing to AS notifications.
* | | docs, nodoc `EnumType`. [ci skip]Yves Senn2015-11-071-1/+1
| | | | | | | | | | | | | | | This type is backed by a class macro. Documentation related to the type casting behavior should be added in the macro description.
* | | docs, `ActiveRecord::JoinDependency` is not part of the public API.Yves Senn2015-11-071-1/+1
| | | | | | | | | | | | | | | | | | | | | [ci skip] While `JoinDependency` and `JoinDependency::Aliases` were nodoced, the inner `Table` class made them appear in the API.
* | | docs, `ActiveRecord::TypeCaster` is not part of the public API.Yves Senn2015-11-073-3/+3
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #22197 from grosser/grosser/fetchKasper Timm Hansen2015-11-072-11/+14
|\ \ \ | |_|/ |/| | do not override fetch on local cache
| * | do not override fetch on local cacheMichael Grosser2015-11-072-11/+14
| | | | | | | | | | | | | | | | | | fetch is supposed to behave differently, this was a mistake merged in https://github.com/rails/rails/pull/22194
* | | Merge pull request #21806 from kachick/fix-transformer-sizeEileen M. Uchitelle2015-11-074-8/+12
|\ \ \ | | | | | | | | Return a sized Enumerator from Hash#transform_values{!}
| * | | Return a sized Enumerator from Hash#{transform_values{!}|transform_keys{!}}Kenichi Kamiya2015-09-294-8/+12
| | | |
* | | | Fix test failuresSean Griffin2015-11-071-0/+1
| | | | | | | | | | | | | | | | | | | | The previous commit changes the state of the class, and while we are cleaning up the database, I forgot to clean up the class
* | | | Ensure `#reset_column_information` clears child classes as wellSean Griffin2015-11-073-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've added a redundant test for this under the attributes API as well, as that also causes this bug to manifest through public API (and demonstrates that calling `reset_column_information` on the child classes would be insufficient) Since children of a class should always share a table with their parent, just reloading the schema from the cache should be sufficient here. `reload_schema_from_cache` should probably become public and `# :nodoc:`, but I'd rather avoid the git churn here. Fixes #22057
* | | | Merge pull request #22213 from y-yagi/remove_deprecated_option_from_guideRichard Schneeman2015-11-071-15/+0
|\ \ \ \ | | | | | | | | | | remove deprecated `:tokenizer` option from guide [ci skip]
| * | | | remove deprecated `:tokenizer` option from guide [ci skip]yuuji.yaginuma2015-11-071-15/+0
| | |_|/ | |/| | | | | | | | | | `:tokenizer` option was deprecated in 1c341eb7cbaeb52435f14c2595e391bfb2e5e38b
* | | | Merge pull request #22145 from atul-shimpi/masterYves Senn2015-11-071-2/+0
|\ \ \ \ | |/ / / |/| | | | | | | | | | | guides, the required option in generators is no longer available. [ci skip]
| * | | Issue #22139 : Edge Guides - ActiveRecord Migrations - Remove required ↵atul-shimpi2015-11-011-2/+0
| | | | | | | | | | | | | | | | option for column
* | | | Merge pull request #22211 from atul-shimpi/masterKasper Timm Hansen2015-11-071-1/+1
|\ \ \ \ | | | | | | | | | | Add comma to to make the information clear