| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
|
| |
| |
| |
| |
| |
| |
| |
| | |
image/x-icon.
Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon,
registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products.
The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
|
|\ \
| | |
| | | |
replace class_eval by define_method in abstract_controller/callbacks
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add test for using ActionView::Helpers::FormHelper.label with block and html
|
|/ / / |
|
| |/
|/| |
|
|\ \
| | |
| | | |
ActionController::Renderers documentation fix
|
| | |
| | |
| | |
| | |
| | | |
ActionController::Renderers::RENDERERS is an instance of Set. Docs incorrectly
state that it's a Hash.
|
|\ \ \
| |/ /
|/| | |
Removed missleading comment [ci skip]
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After this 21dbe6f39b57f52967e92716dbd5e2b894e7a64c
2.1.1 :001 > 'business'.classify
=> "Business"
2.1.1 :004 > 'calculus'.classify
=> "Calculu"
2.1.1 :005 >
|
|\ \
| |/
|/| |
correct the classify example's output.
|
|/ |
|
|\
| |
| | |
[ci skip] builtin -> built-in
|
| | |
|
|\ \
| |/
|/| |
Fix code indentation and improve formatting
|
|/
|
|
|
|
|
| |
in the Getting Started Guide.
This PR regroups #14817, #14818 and #14819 into one commit.
[skip ci]
|
|\
| |
| | |
Grammar fix in Getting Started Guide [ci skip]
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Escape '%' characters in URLs - only unescaped data
should be passed to URL helpers
2. Add an `escape_segment` helper to `Router::Utils`
that escapes '/' characters
3. Use `escape_segment` rather than `escape_fragment`
in optimized URL generation
4. Use `escape_segment` rather than `escape_path`
in URL generation
For point 4 there are two exceptions. Firstly, when a route uses wildcard
segments (e.g. *foo) then we use `escape_path` as the value may contain '/'
characters. This means that wildcard routes can't be optimized. Secondly,
if a `:controller` segment is used in the path then this uses `escape_path`
as the controller may be namespaced.
Fixes #14629, #14636 and #14070.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The URI::Parser#escape method is a general use method that has to deal
with a variety of input however our use of it is limited in scope so
we can increase the performance by implementing our specific needs
within ActionDispatch::Journey::Router::Utils directly.
If there is no encoding required then there is no change in performance
or number of objects allocated, but for each character that needs to be
encoded we save five object allocations and gain a performance boost.
The performance boost seen varies from 20% when there is one character
to over 50% when encoding ten characters.
|
|
|
|
|
|
|
|
|
|
| |
Makes it clear that anything passed with the helper must not be percent encoded.
Fixes previous behavior which tricks people into believing passing
non-percent-encoded will generate a proper percent-encoded path while in
reality it doesn't ('%' isn't escaped).
The intention is nice but the heuristic is broken.
|
|\
| |
| | |
Remove statement assuming coffee shop/public space wifi is inherently insecure
|
|/ |
|
|\
| |
| | |
Don't rely on Arel master in bug report template
|
|/
|
|
|
|
| |
We should rely instead on the version supported by Active Record
Closes #14809
|
|\
| |
| | |
multibyte_conformance.rb --> multibyte_conformance_test.rb
|
| | |
|
|\ \
| | |
| | | |
"subhash" --> "sub-hash"
|
| |/ |
|
|\ \
| |/
|/|
| |
| | |
akalyaev/few-corrections-in-rails-initialization-guides
Few corrections in Rails Initialization Guides
|
|/ |
|
|\
| |
| | |
Fix inconsistent behavior from String#first/#last
|
|/
|
|
|
|
|
| |
While calling String#first or String#last with zero or a Fixnum < the
string's length returns a new string, a Fixnum >= the string's length
returns the string itself. This inconsistency can lead to inadvertent
mutation of a string.
|
|\
| |
| | |
when a destroyed record is duped, it is no longer ´destroyed?`.
|
|/ |
|
|\
| |
| | |
remove warning while running TEST CASES
|
|/
|
|
| |
`warning: ambiguous first argument; put parentheses or even spaces`
|
|\ |
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| | |
Per discussion at https://github.com/rails/rails/issues/14645#issuecomment-40499409
|
| |
| |
| |
| | |
This was changed in https://github.com/rails/rails/pull/13415/files
|
| | |
|
| |
| |
| | |
`reaping_frequency` is used in Active Record `reap_frequency` is not
|
| |
| |
| |
| |
| |
| | |
Including replacing a few "smart quotes" with regular quotes (' and "),
for consistency.
[ci skip]
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| |
| |
| | |
For consistency with all other documentation, point to where these core
extensions are defined, not where the example code comes from.
[ci skip]
|
| | |
|