| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Make `PERMITTED_TYPES` private
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The constant `PERMITTED_TYPES` is only used by the private method
`serialize_argument` and it already has the `# :nodoc:` annotation as
the other constants in the class.
Complements e899e22
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | | |
eugeneius/rm_ensure_from_with_transaction_returning_status
Remove ensure from with_transaction_returning_status
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The test added in 12b0b26df7560ab5199ba830586864085441508f passes even
without this code since 9b8c7796a9c2048208aa843ad3dc477dffa8bdee, as the
call to `id` in `remember_transaction_record_state` now triggers a
`sync_with_transaction_state` which discards the leftover state from the
previous transaction.
This issue had already been fixed for `save!`, `destroy` and `touch` in
caae79a385ce112245262a17414bcd96bea013c2, but continued to affect `save`
because the call to `rollback_active_record_state!` in that method would
increment the transaction level before `add_to_transaction` could clear
it, preventing the fix from working correctly.
As `rollback_active_record_state!` was removed entirely in
48007d5390db47fc1223f57c8e7ab3ebb7c3a3d7, this code is no longer needed.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | | |
albertoalmagro/include-big-decimal-as-supported-type
Document missing supported types [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This commit adds missing types to the supported types list, which
was extended in #30941
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Follow up a741208f80dd33420a56486bd9ed2b0b9862234a.
Since a741208, `Decimal#serialize` which is superclass of `Money` type
is no longer no-op, so it consistently serialize/deserialize a value as
a decimal even if schema default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Related 34cc301f03aea2e579d6687a9ea9782afc1089a0.
`QueryAttribute#value_for_database` calls only `type.serialize`, and
`Decimal#serialize` is a no-op unlike other attribute types.
Whether or not `serialize` will invoke `cast` is undefined in our test
cases, but it actually does not work properly unless it does so for now.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
albertoalmagro/use-assert-not-instead-of-refute"
This reverts commit ab5d5c95ec51c63d58d7e75694af748f165e2228, reversing
changes made to ef4f5ef69b5a50c897bbb17f6b36b729dff12e6c.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Prefer assert_not instead of refute [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
As mentioned in the contributing to Ruby on Rails guides,
we should prefer `assert_not` instead of `refute`. And the
best place to start giving example are our bug report templates..
See: https://github.com/rails/rails/blame/master/guides/source/contributing_to_ruby_on_rails.md#L256
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix typo for Action Cable Overview doc
[Eileen M. Uchitelle]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
Clarify the validation of present associations
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I think that it is not clear what means that _an association is
present_. Add that it is checking that the foreign key is not empty and
that the referenced object exists to clarify it.
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | | |
Docs: Update Development Dependencies Install
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* Move all the testing related stuff to the contributing guide and
redirect the reader to this guide once the installation process
is finished as running tests is the logical next step.
* Group documentation instructions by OS, not by gem
* It eases the installation process and lessen the need to scroll
through the guide
* There's still a list of all additional services required for each
of the gems above the instructions for each OS.
* Also update a bit the instructions
* Update some package names
* Add `yarn` to the package list for Arch Linux and FreeBSD
* Use `dnf` instead of `yum` for Fedora and CentOS
* Advise the user to use `brew bundle` on macOS to lessen the
maintenance burden for this OS and ease the process for the user.
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://github.com/rails/rails/pull/30941/files#diff-fc90ec41ef75be8b2259526fe1a8b663L53
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Follow up #34131.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Related to: #34406
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Use `t.index ...` instead.
|
| | | | | | |
|
| | | | | | |
|
| |_|_|/ /
|/| | | |
| | | | |
| | | | | |
Since quoted `Infinity` and `NaN` are valid data for PostgreSQL.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add an :if_not_exists option to create_table
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[fatkodima & Stefan Kanev]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove unused argument `expected_database`
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
This argument was added in fa5a028ed9f, and #34137 but hasn't been used.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Use RuboCop 0.60.0 and remove exclude files for `Style/RedundantFreeze`
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Since https://github.com/rubocop-hq/rubocop/pull/6333 has been
included into RuboCop 0.60.0.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`Webpacker` handles testing / development packs separately by default.
If do not specify `RAILS_ENV`, there is no merit to precompile.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Guard Enums against definitions with blank label names
|
| | |_|_|/
| |/| | | |
|
|/ / / /
| | | |
| | | |
| | | | |
And remove trailing spaces.
|
|\ \ \ \
| | | | |
| | | | | |
Db schema cache dump and clear multi db
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Adds support for multiple databases to `rails db:schema:cache:dump`
and `rails db:schema:cache:clear`.
|
|\ \ \ \
| | | | |
| | | | | |
Always add records to parent of nested transaction
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When a record with transactional callbacks is saved, it's attached to
the current transaction so that the callbacks can be run when the
transaction is committed. Records can also be added manually with
`add_transaction_record`, even if they have no transactional callbacks.
When a nested transaction is committed, its records are transferred to
the parent transaction, as transactional callbacks should only be run
when the outermost transaction is committed (the "real" transaction).
However, this currently only happens when the record has transactional
callbacks, and not when added manually with `add_transaction_record`.
If a record is added to a nested transaction, we should always attach it
to the parent transaction when the nested transaction is committed,
regardless of whether it has any transactional callbacks.
[Eugene Kenny & Ryuta Kamizono]
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Respond /rails/info/properties.json
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Added json format, like this:
{
"Rails version": "6.0.0.alpha",
"Ruby version": "2.5.1-p57 (x86_64-darwin17)",
"RubyGems version": "2.7.6",
"Rack version": "2.0.6",
"JavaScript Runtime": "Node.js (V8)",
"Middleware": ["Rack::Sendfile", "ActionDispatch::Static", "ActionDispatch::Executor", "ActiveSupport::Cache::Strategy::LocalCache::Middleware", "Rack::Runtime", "Rack::MethodOverride", "ActionDispatch::RequestId", "ActionDispatch::RemoteIp", "Sprockets::Rails::QuietAssets", "Rails::Rack::Logger", "ActionDispatch::ShowExceptions", "WebConsole::Middleware", "ActionDispatch::DebugExceptions", "ActionDispatch::Reloader", "ActionDispatch::Callbacks", "ActiveRecord::Migration::CheckPending", "ActionDispatch::Cookies", "ActionDispatch::Session::CookieStore", "ActionDispatch::Flash", "ActionDispatch::ContentSecurityPolicy::Middleware", "Rack::Head", "Rack::ConditionalGet", "Rack::ETag", "Rack::TempfileReaper"],
"Application root": "/path/to/app",
"Environment": "development",
"Database adapter": "sqlite3",
"Database schema version": 0
}
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Amend CVE note and security guide section wordings
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reword first sentence of dep management and CVE section of
security guide. Also, reword and move gemspec notes above deps.
[ci skip]
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Add `connect_src` example to content security policy initializer
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If want to use `webpack-dev-server` with CSP enabled, need to specify
`connect-src`.
Related to: https://github.com/rails/webpacker/commit/cd7ecf4d48496341aecd81c0c2f69fe4e50a7cd4
This is a matter of `webpacker`. But since `webpacker` is now used by
default, to prevent user confusion, I think that better to include an
example of `connect-src.`
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Add CVE note to security guide and gemspecs
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
eugeneius/inspect_with_non_primary_key_id_attribute
Fix inspect with non-primary key id attribute
|