aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Do not delegate `AR::Base#empty?` to `all`Sean Griffin2016-05-022-7/+1
| | | | | | | | | | Unlike `one?` and `none?`, `empty?` has interactions with methods outside of enumerable. It also doesn't fit in the same vein. `Topic.any?` makes sense. `Topic.empty?` does not, as `Topic` is not a container. Fixes #24808 Close #24812
* Merge pull request #24810 from willnet/fix-actioncable-readmeप्रथमेश Sonpatki2016-05-021-1/+1
|\ | | | | [ci skip] Fix ActionCable README
| * [ci skip] Fix ActionCable READMEwillnet2016-05-021-1/+1
|/ | | | default worker pool size was changed from 100 to 4 at #24376
* Merge pull request #24807 from kamipo/add_nodoc_to_schema_creationVipul A M2016-05-021-1/+1
|\ | | | | Add `:nodoc:` to `schema_creation` [ci skip]
| * Add `:nodoc:` to `schema_creation` [ci skip]Ryuta Kamizono2016-05-021-1/+1
|/ | | | | | | `schema_creation` is not public API. https://github.com/rails/rails/blob/v5.0.0.beta4/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb#L121 https://github.com/rails/rails/blob/v5.0.0.beta4/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L78
* Merge pull request #24713 from tomkadwill/fix_counter_cache_incrementSean Griffin2016-04-303-0/+14
|\ | | | | | | | | Fix counter_cache double increment bug Close #24183
| * Fix counter_cache double increment bugTom Kadwill2016-04-283-0/+14
| |
* | Replace ActionDispatch::LoadInterlock with ActionDispatch::Executor in ↵willnet2016-04-304-5/+5
| | | | | | | | | | | | | | guides [ci skip] Guides should be updated because ActionDispatch::LoadInterlock was replaced with ActionDispatch::Executor at #23807.
* | Fix initial value effects for sum along to ruby 2.4Kenta Murata2016-04-302-5/+85
| | | | | | | | Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | Merge pull request #24801 from y-yagi/fix_incorrect_module_nameJon Moss2016-04-301-1/+1
|\ \ | | | | | | fix incorrect module name [ci skip]
| * | fix incorrect module name [ci skip]yuuji.yaginuma2016-05-011-1/+1
|/ /
* | Merge pull request #24798 from mrkjlchvz/mc-grammarVipul A M2016-05-010-0/+0
|\ \ | | | | | | Fix grammar. [ci skip]
| * | Fix grammar.Mark2016-05-011-1/+1
| | |
* | | Merge pull request #24791 from maclover7/jm-rm-ar-rails-mentionRafael França2016-04-302-1/+5
|\ \ \ | | | | | | | | Replace `Rails.version.to_f` with Active Record
| * | | Replace `Rails.version.to_f` with Active RecordJon Moss2016-04-302-1/+5
| | | | | | | | | | | | | | | | | | | | Rails should not be explicity mentioned within Active Record, since railties and the Rails ecosystem is not required for use.
* | | | Merge pull request #24777 from tomkadwill/action_pack_typos_3Vipul A M2016-04-302-5/+5
|\ \ \ \ | | | | | | | | | | Fix actionpack typos [ci skip]
| * | | | Fix actionpack typos [ci skip]Tom Kadwill2016-04-302-5/+5
| | | | |
* | | | | add #24385 to 5.0 release notes [ci skip]yuuji.yaginuma2016-04-291-0/+7
| |/ / / |/| | |
* | | | rm unused requireVipul A M2016-04-291-1/+0
| | | | | | | | | | | | | | | | Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | | | Extract `add_sql_comment!` methodRyuta Kamizono2016-04-293-20/+13
| | | | | | | | | | | | | | | | | | | | | | | | Refactor of #22911. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | | | Treat blank comments as no comment for indexesRyuta Kamizono2016-04-293-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | Follow up of 1683410. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | | | Migrations: move version-finding responsibilityyui-knk2016-04-292-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `ActiveRecord::Migration` needn't know about migration version compatibility lookup. Delegate it to the Compatibility module. Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | | | restores the regexp used in String#blank?Xavier Noria2016-04-291-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit undoes 54243fe. Reason: Further investigation has shown the benefit is not so clear generally speaking. There is a long discussion and several benchmarks in the PR #24658 if you are interested in the details.
* | | | Chomp: prefer String#chomp where we can for a clarity boostlvl0nax2016-04-293-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | Closes #24766, #24767 Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
* | | | AS::Duration changelog polishJeremy Daer2016-04-291-15/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the updated changelog from the first merge: 7254517 References #22806, #24762. [ci skip]
* | | | Merge pull request #24788 from connorshea/patch-1Jon Moss2016-04-291-52/+52
|\ \ \ \ | | | | | | | | | | Update configuring.md with colons and periods
| * | | | Update configuring.md with colons and periodsConnor Shea2016-04-291-52/+52
|/ / / / | | | | | | | | Some configuration options started with a capital letter indicating the beginning of a sentence, which didn't makes sense without the colons. Similarly, some were missing periods at the end of their descriptions. [ci skip]
* | | | Merge pull request #24787 from connorshea/patch-1Rafael França2016-04-292-3/+3
|\ \ \ \ | | | | | | | | | | Patch 1
| * | | | Consistent spelling of "gzipped" [ci skip]Connor Shea2016-04-291-1/+1
| | | | |
| * | | | Fix typos in asset_pipeline.md [ci skip]Connor Shea2016-04-291-2/+2
|/ / / / | | | | | | | | Per discussion in #24786.
* | | | Merge pull request #24786 from vipulnsward/document-gzip-assetsRichard Schneeman2016-04-292-0/+13
|\ \ \ \ | | | | | | | | | | Document config.assets.gzip flag.
| * | | | Document config.assets.gzip flag. Follow up of ↵Vipul A M2016-04-292-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/sprockets-rails/pull/342. [ci skip]
* | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-04-298-25/+31
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/configuring.md
| * | | | | s/statment/statement/Vipul A M2016-04-241-1/+1
| | | | | |
| * | | | | be specific when the debug_exception_response_format to :apiVipul A M2016-04-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | | Mention default values for `debug_exception_response_format` in configuring ↵Prathamesh Sonpatki2016-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | guide [ci skip]
| * | | | | `debug_exception_format` is set to :api by default for API apps only, not ↵Prathamesh Sonpatki2016-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for normal apps. [ci skip]
| * | | | | [ci skip] Aline results of code examples in commentsyui-knk2016-04-201-2/+2
| | | | | |
| * | | | | s/determins/determines/Vipul A M2016-04-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | | - Be consistent in providing file locations of schema, model and initializerVipul A M2016-04-131-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | | - Make sure we end sentencesVipul A M2016-04-131-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Change from "The Task" to "The Update Task" as referred elsewhere [ci skip]
| * | | | | [ci skip] Add some missing commasPrathamesh Sonpatki2016-04-121-2/+2
| | | | | |
| * | | | | [ci skip] Typo fix. `loggs` -> `logs`Prathamesh Sonpatki2016-04-121-1/+1
| | | | | |
| * | | | | - Fix typo in config guide, from config.logger sectionVipul A M2016-04-101-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Make bulleted lists, end properly [ci skip]
| * | | | | s/Thoughtbot/thoughtbot/Vipul A M2016-04-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/thoughtbot/presskit/blob/master/README.md#name for name capitalization. [ci skip]
| * | | | | [ci skip] Fix formatting of code snippet in Action Cable guidePrathamesh Sonpatki2016-04-051-7/+8
| | | | | |
| * | | | | [ci skip] Update code used for filtering passwords in the configuring guidePrathamesh Sonpatki2016-04-051-1/+1
| | | | | |
* | | | | | Merge pull request #24776 from prathamesh-sonpatki/aj-release-notesKasper Timm Hansen2016-04-292-1/+22
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Active Job: Add note about ability to configure adapters on per job basis in CHANGELOG and release notes
| * | | | | Active Job: Add note about ability to configure adapters on per job basis in ↵Prathamesh Sonpatki2016-04-292-1/+22
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | CHANGELOG and release notes. [ci skip]
* | | | | Merge pull request #24762 from Envek/solid_durations_2Andrew White2016-04-294-11/+47
|\ \ \ \ \ | | | | | | | | | | | | [FIX] Change 1.week to create 1 week durations instead of 7 days durations.