aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #34573 from WoH/firefox-right-click-bugRafael França2018-12-057-6/+100
|\ \ | |/ |/| Prevent non-primary mouse button clicks from triggering click events
| * Prevent unintended mouse keys from firing click eventsWoH2018-12-057-6/+100
| | | | | | | | | | Firefox fires click events on left-, right- and scroll-wheel (any non-primary mouse key) clicks while other browsers don't.
* | Merge pull request #34194 from staugaard/staugaard/actioncable_unauthorizedRafael França2018-12-059-10/+46
|\ \ | | | | | | Stop trying to reconnect on unauthorized cable connections
| * | Stop trying to reconnect on unauthorized cable connectionsMick Staugaard2018-12-059-10/+46
| | |
* | | Improve deprecation message for enqueue returning falseRafael Mendonça França2018-12-055-1/+49
|/ / | | | | | | | | | | And make sure new applications in Rails 6.0 has this config enabled. Also, improve test coverage and add a CHANGELOG entry.
* | Merge pull request #34626 from gmcgibbon/sqlite_pluck_quotingRyuta Kamizono2018-12-063-0/+12
|\ \ | | | | | | Fix join table column quoting with SQLite.
| * | Fix join table column quoting with SQLite.Gannon McGibbon2018-12-053-0/+12
| | |
* | | Merge pull request #33992 from kirs/enqueue-return-falseRafael França2018-12-055-1/+56
|\ \ \ | | | | | | | | Make AJ::Base#enqueue return false if the job wasn't enqueued
| * | | Make AJ::Base#enqueue return false if the job wasn't enqueuedKir Shatrov2018-10-285-1/+56
| | | |
* | | | Merge pull request #34621 from colby-swandale/update-bundler-2Rafael França2018-12-051-1/+1
|\ \ \ \ | |_|/ / |/| | | Update bundler to 2.0.0.pre.2
| * | | update bundler to 2.0.0.pre.2Colby Swandale2018-12-051-1/+1
| | | |
* | | | Merge pull request #34591 from gmcgibbon/new_delivery_jobEileen M. Uchitelle2018-12-0512-23/+179
|\ \ \ \ | | | | | | | | | | Add MailDeliveryJob for unified mail delivery
| * | | | Add MailDeliveryJob for unified mail deliveryGannon McGibbon2018-12-0412-23/+179
| | | | | | | | | | | | | | | | | | | | | | | | | Add `MailDeliveryJob` for delivering both regular and parameterized mail. Deprecate using `DeliveryJob` and `Parameterized::DeliveryJob`.
* | | | | Fix unstable ↵yuuji.yaginuma2018-12-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `test_serialized_attribute_works_under_concurrent_initial_access` test Since bd62389307e138ee0f274a9d62697567a3334ea0, isolate test of `test_serialized_attribute_works_under_concurrent_initial_access` fails. ``` $ ./bin/test -w test/cases/serialized_attribute_test.rb -n test_serialized_attribute_works_under_concurrent_initial_access Using sqlite3 Run options: -n test_serialized_attribute_works_under_concurrent_initial_access --seed 32129 # Running: E Error: SerializedAttributeTest#test_serialized_attribute_works_under_concurrent_initial_access: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such table: ``` If duplicate an unloaded model, it seems that method invocation for that class is not guaranteed. Use the original class to avoid it.
* | | | | Merge pull request #34620 from ↵Yuji Yaginuma2018-12-052-3/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | ysksn/use_safe_navigation_operator_for_railsguides_generator_constructor Use String for direction of RailsGuides::Generator#new
| * | | | | Use safe nav operator when calling RailsGuides::Generator.newYosuke Kabuto2018-12-052-3/+3
|/ / / / / | | | | | | | | | | | | | | | Use String for direction of RailsGuides::Generator
* | | | | Merge pull request #34617 from blahed/colorize-unpermitted-paramsRafael França2018-12-041-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Colorize the unpermitted params log message
| * | | | | colorize the unpermitted params log messageblahed2018-12-031-1/+1
| | | | | |
* | | | | | Merge pull request #34563 from sambostock/improve-test-helper-guidesGannon McGibbon2018-12-041-0/+50
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Add advanced test helpers docs to guides
| * | | | | Add advanced test helpers docs to guidesSam Bostock2018-12-041-0/+50
|/ / / / / | | | | | | | | | | | | | | | [ci skip]
* | | | | Merge pull request #34612 from ↵Rafael França2018-12-041-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | utilum/bigdecimal_raises_on_comma_in_string_argument Another Ruby 2.6 BigDecimal compatibility issue
| * | | | | Another Ruby 2.6 BigDecimal compatibility issueutilum2018-12-041-1/+1
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch modifies XmlMini::Parsing["decimal"] to handle a string that contains an invalid number. Since [ruby/ruby@a0e438c#diff-6b866d482baf2bdfd8433893fb1f6d36R144](https://github.com/ruby/ruby/commit/a0e438cd3c28d2eaf4efa18243d5b6edafa14d88#diff-6b866d482baf2bdfd8433893fb1f6d36R144) this case raises an `ArgumentError`. `String.to_f` returns 0.0 if there is not a valid number at the start of the argument, so current behavior is conserved. See https://travis-ci.org/rails/rails/jobs/463180341#L6264 Related: #34600, #34601
* | | | | Merge pull request #34560 from gmcgibbon/fix_decorate_leak_on_serial_attr_testRafael França2018-12-041-0/+4
|\ \ \ \ \ | | | | | | | | | | | | Fix attribute decoration leak on serialized attribute test
| * | | | | Fix attribute decoration leak on serialized attribute testGannon McGibbon2018-11-291-0/+4
| | | | | |
* | | | | | Merge pull request #34616 from gmcgibbon/route_symbol_noteRafael França2018-12-041-0/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add note about symbols vs strings
| * | | | | | Add note about symbols vs stringsGannon McGibbon2018-12-041-0/+2
| | | | | | |
* | | | | | | Fix announcement draft formatting [ci skip]Rafael Mendonça França2018-12-041-2/+2
| | | | | | |
* | | | | | | Add release link to the announcement [ci skip]Rafael Mendonça França2018-12-041-3/+7
| | | | | | |
* | | | | | | Improve the task to generate the release summaryRafael Mendonça França2018-12-041-5/+10
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now it accepts the base release to be compared with. [ci skip]
* | | | | | Merge pull request #34605 from alfie-max/disable_enum_scopesRafael França2018-12-043-2/+18
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | option to disable all scopes that `ActiveRecord.enum` generates
| * | | | | option to disable scopes that `ActiveRecord.enum` generates by defaultAlfred Dominic2018-12-043-2/+18
|/ / / / /
* | | | | Merge pull request #34609 from kamipo/delete_all_on_collection_proxyRyuta Kamizono2018-12-045-6/+23
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Ensure that `delete_all` on collection proxy returns affected count
| * | | | | Ensure that `delete_all` on collection proxy returns affected countRyuta Kamizono2018-12-045-6/+23
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike the `Relation#delete_all`, `delete_all` on collection proxy doesn't return affected count. Since the `CollectionProxy` is a subclass of the `Relation`, this inconsistency is probably not intended, so it should return the count consistently.
* | | | | Merge pull request #34607 from gmcgibbon/clear_scope_on_deleteRyuta Kamizono2018-12-044-4/+72
|\ \ \ \ \ | |/ / / / |/| | | | Reset scope after collection delete
| * | | | Reset scope after collection deleteGannon McGibbon2018-12-044-4/+72
|/ / / / | | | | | | | | | | | | | | | | Reset scope after delete on collection association to clear stale offsets of removed records.
* | | | Merge pull request #34596 from bogdanvlviv/imporve-parallel-testing-guideGannon McGibbon2018-12-031-10/+9
|\ \ \ \ | | | | | | | | | | Improve parallel testing guide [ci skip]
| * | | | Improve parallel testing guide [ci skip]bogdanvlviv2018-12-031-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fix formatting - Don't repeat "Active Record automatically handles creating and migrating a new database for each worker to use." - Tell that AR loads the schema to a database for each process(Related to #33479) - Clarify that `parallelize_teardown` is executed for each process
* | | | | Merge pull request #34602 from guizmaii/masterRafael França2018-12-031-1/+2
|\ \ \ \ \ | | | | | | | | | | | | Pass the `connection` to the `@instrumenter.instrument` method call
| * | | | | Pass the `connection` to the `@instrumenter.instrument` method calljules Ivanic2018-12-031-1/+2
| | | | | |
* | | | | | Merge pull request #34601 from evexoio/34600-test_should_return_nil_as_averageRyuta Kamizono2018-12-031-2/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix NumericData.average test on 2.6.0-dev
| * | | | | | Fix NumericData.average test on ruby 2.6Abdallah Samman2018-12-031-2/+6
| |/ / / / /
* / / / / / Address "warning: shadowing outer local variable - parts"Ryuta Kamizono2018-12-034-7/+8
|/ / / / / | | | | | | | | | | | | | | | And hide the `READ_QUERY` internal constant.
* | | | | Merge pull request #34597 from utilum/assigned_but_unused_variable_birdYuji Yaginuma2018-12-031-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Assigned but unused variable - bird
| * | | | | Assigned but unused variable - birdutilum2018-12-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | See: https://travis-ci.org/rails/rails/jobs/462233144#L1384
* | | | | | Merge pull request #34598 from ↵Rafael França2018-12-021-0/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | rmacklin/add-missing-authorship-to-changelog-entry Add missing authorship to ActionCable changelog entry
| * | | | | Add missing authorship to ActionCable changelog entryRichard Macklin2018-12-021-0/+2
|/ / / / / | | | | | | | | | | | | | | | | | | | | I accidentally forgot to add the author line to my changelog entry from 2bb4fdef5efc70327c018e982ff809a29ac6708b
* | | | | Merge pull request #34585 from marceloperini/marceloperini/33795Yuji Yaginuma2018-12-031-0/+1
|\ \ \ \ \ | | | | | | | | | | | | add require 'database/setup' in activestorage/test/service/s3_service_test.rb
| * | | | | add require 'database/setup' in activestorage/test/service/s3_service_test.rbMarcelo Perini Veloso2018-12-011-0/+1
| |/ / / /
* | | | | Merge pull request #34595 from albertoalmagro/remove-unnecessary-variableRyuta Kamizono2018-12-031-11/+2
|\ \ \ \ \ | | | | | | | | | | | | Remove unnecessary variable route
| * | | | | Remove unnecessary variable routeAlberto Almagro2018-12-021-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The variable `route` was only allocated to hold an object that was immediately returned. This patch removes that variable.
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-23 23:40:15 +0000