aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Cache the value of `changed_attributes` when calling `changes_applied`Sean Griffin2014-08-221-1/+20
| | | | | | | `changes_applied` calles `changes`, which will call `changed_attributes` multiple times in a loop. This method actually performs work now, so we should cache the results while looping over it when we know it cannot change.
* Merge pull request #16598 from seuros/masterMatthew Draper2014-08-231-0/+1
|\ | | | | [ActionMailer] require activejob railtie
| * [ActionMailer] require activejob railtieAbdelkader Boudih2014-08-221-0/+1
| |
* | Merge pull request #15932 from joseluistorres/issue-11957-uuidsRafael Mendonça França2014-08-223-1/+17
|\ \ | | | | | | adding the exception RecordNotFound to UUID find #11957
| * | adding the exception RecordNotFound to UUID findJoseLuis Torres2014-08-213-1/+17
| | |
* | | Merge pull request #16645 from sgrif/sg-perf-regressionRafael Mendonça França2014-08-221-8/+0
|\ \ \ | | | | | | | | Don't calculate in-place changes twice
| * | | Don't calculate in-place changes twiceSean Griffin2014-08-221-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | Now that `changed_attributes` includes in place changes, we don't need to override these methods in Active Record. Partially fixes the performance regression caused by #16189
* | | | Merge pull request #16641 from cristianbica/aj-backburner-enqueue-laterRafael Mendonça França2014-08-222-5/+6
|\ \ \ \ | | | | | | | | | | Implemented enqueue_at for ActiveJob's Backburner adapter
| * | | | Implemented enqueue_at for ActiveJob's Backburner adapterCristian Bica2014-08-222-5/+6
| | | | |
* | | | | Merge pull request #16642 from cristianbica/aj-doc-queue-name-prefixZachary Scott2014-08-221-2/+23
|\ \ \ \ \ | |_|/ / / |/| | | | Active Job Guide: Example of config queue_name_prefix [ci skip]
| * | | | Active Job guide: Add info about queue_name prefix and clarity supporter ↵Cristian Bica2014-08-221-2/+23
| |/ / / | | | | | | | | | | | | features
* | | | Merge pull request #16622 from matthewd/default-debugMatthew Draper2014-08-232-3/+3
|\ \ \ \ | | | | | | | | | | Don't fight against ourselves for the default log level
| * | | | Don't fight against ourselves for the default log levelMatthew Draper2014-08-222-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we want to always default to :debug, let's just do that. At which point the production.rb entry can become an "uncomment to change" instead.
* | | | | Merge pull request #16626 from adomokos/replacing-each-with-reduceSantiago Pastorino2014-08-221-3/+1
|\ \ \ \ \ | |_|/ / / |/| | | | Replacing an each with reduce
| * | | | Using `each_with_object` instead of `reduce`Attila Domokos2014-08-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | This way no new object allocation is taking place. Thanks @jeremy for the suggestion!
| * | | | Replacing an each with reduceAttila Domokos2014-08-211-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The functionality has not changed, but the code is more elegant by using `reduce` instead of `each`. This way no accumulator needs to be declared, no explicit return is needed.
* | | | | Merge pull request #16560 from robin850/rbx-duration-eqlRafael Mendonça França2014-08-223-2/+16
|\ \ \ \ \ | | | | | | | | | | | | Define the Duration#instance_of? method
| * | | | | Define the Duration#instance_of? methodRobin Dupret2014-08-183-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Duration is extending from ProxyObject which extends itself from BasicObject, the Duration object doesn't respond to the #instance_of? method. Thus, the #method_missing hook get triggered, delegating the method to its `value` attribute. However, Rubinius' #eql? definition relies on #instance_of?, thus this will equal to true with a Fixnum (since its `value` attribute is a Fixnum) while it should not. The previous behavior was wrong anyway, no matter the implementation.
* | | | | | Merge pull request #16633 from tgxworld/prefer_log_message_through_blockYves Senn2014-08-221-4/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Pass logging message through block.
| * | | | | | Pass logging message through block.Guo Xiang Tan2014-08-221-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance
* | | | | | | Merge pull request #16634 from tgxworld/missing_spaceZachary Scott2014-08-221-1/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Missing space. [CI SKIP]
| * | | | | | Missing space. [CI SKIP]Guo Xiang Tan2014-08-221-1/+1
|/ / / / / /
* | | | | | Merge pull request #11859 from zzak/nested_model_forms_guideZachary Scott2014-08-221-1/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | See AR::Associations for greater detail in Nested Model Forms Guide [ci skip]
| * | | | | | add nested_model_forms to guides/documents.yaml [wip] [ci skip]Zachary Scott2014-08-221-1/+4
|/ / / / / /
* | | | | | Merge branch 'jonatack-patch-8'Zachary Scott2014-08-221-2/+6
|\ \ \ \ \ \
| * | | | | | Follow up on #16408Jon Atack2014-08-221-2/+6
|/ / / / / / | | | | | | | | | | | | | | | | | | [skip ci]
* | | | | | [ci skip] Running AR tests guide [Fixes GH-15891]Zachary Scott2014-08-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Patch by @bcjordan
* | | | | | Merge pull request #16630 from ↵Zachary Scott2014-08-221-0/+12
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | tomkadwill/added_has_and_belongs_to_many_scope_documentation [ci skip] Added documentation for has_and_belongs_to_many scope parameter
| * | | | | | [ci skip] Added documentation for has_and_belongs_to_many scope parameterTom Kadwill2014-08-221-0/+12
|/ / / / / /
* | | | | | Merge pull request #16629 from rails/revert-16438-input-placeholder-i18nJeremy Kemper2014-08-215-214/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Revert "Add I18n support for `:placeholder` HTML option is passed to for...
| * | | | | | Revert "Add I18n support for `:placeholder` HTML option is passed to form ↵Jeremy Kemper2014-08-215-214/+0
|/ / / / / / | | | | | | | | | | | | | | | | | | fields"
* | | | | | Merge pull request #16604 from saarons/clean-remote-ip-middlewareJeremy Kemper2014-08-213-53/+61
|\ \ \ \ \ \ | | | | | | | | | | | | | | ActionDispatch::RemoteIp accept IPAddr matches for trusted proxies
| * | | | | | Refactor ActionDispatch::RemoteIpSam Aarons2014-08-213-53/+61
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored IP address checking in ActionDispatch::RemoteIp to rely on the IPAddr class instead of the unwieldly regular expression to match IP addresses. This commit keeps the same api but allows users to pass IPAddr objects to config.action_dispatch.trusted_proxies in addition to passing strings and regular expressions. Example: # config/environments/production.rb config.action_dispatch.trusted_proxies = IPAddr.new('4.8.15.0/16')
* | | | | | fix grammar [ci skip]Vijay Dev2014-08-221-1/+1
| | | | | |
* | | | | | fix server names [ci skip]Vijay Dev2014-08-221-1/+1
|/ / / / / | | | | | | | | | | Per feedback in https://github.com/rails/rails/commit/af63e4a2546629c3fb2d53cffb7d4ea0e8663f68#commitcomment-7477636
* | | | | ActiveJob -> Active Job [ci skip]Xavier Noria2014-08-213-3/+3
| | | | | | | | | | | | | | | | | | | | See http://guides.rubyonrails.org/api_documentation_guidelines.html#wording
* | | | | applies API guidelines to new AM docsXavier Noria2014-08-212-32/+32
| |/ / / |/| | |
* | | | Merge pull request #16621 from Calyhre/patch-1Rafael Mendonça França2014-08-211-0/+3
|\ \ \ \ | | | | | | | | | | Update documentation, Add change to ActionView Notable changes
| * | | | Add change to ActionView Notable changes [ci skip]Charley D2014-08-211-0/+3
|/ / / /
* | | | Merge pull request #16271 from alol/action-view-overview-guide-tweaksVijay Dev2014-08-221-11/+11
|\ \ \ \ | | | | | | | | | | Small Action View Overview guide grammar and readability tweaks
| * | | | Small Action View Overview edits [ci skip]Alan Oliver2014-07-241-11/+11
| | | | | | | | | | | | | | | | | | | | Some small grammar and readability edits
* | | | | Merge pull request #16204 from jonatack/patch-7Vijay Dev2014-08-211-12/+14
|\ \ \ \ \ | | | | | | | | | | | | Fix minor typos and improve grammar and code formatting
| * | | | | Grammar passJon Atack2014-08-191-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Add improvements from @eileencodes [skip ci]
* | | | | | Merge pull request #16617 from tomkadwill/added_has_one_scope_documentationZachary Scott2014-08-211-0/+11
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Added documentation for has_one scope parameter
| * | | | | | [ci skip] Added documentation for has_one scope parameterTom Kadwill2014-08-211-0/+11
| | | | | | |
* | | | | | | Merge pull request #16615 from tgxworld/guide_fixZachary Scott2014-08-211-3/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [ci skip] Grammar fixes for upgrade guide from 4.0 to 4.1
| * | | | | | | Guide fix. [CI SKIP]Guo Xiang Tan2014-08-221-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Related: https://github.com/rails/rails/pull/16607
* | | | | | | | Make text consistent in help text of rails server and console commands.Vijay Dev2014-08-212-13/+13
|/ / / / / / /
* | | | | | | Merge pull request #16612 from loganhasson/masterZachary Scott2014-08-211-5/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [ci skip] Clarify Action Mailer/Active Job usage note
| * | | | | | | [ci skip] Clarify Action Mailer/Active Job usage noteLogan Hasson2014-08-211-5/+5
| |/ / / / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 09:56:41 +0000