| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Using url helper method of engine in example code,
include `Engine.routes.url_helpers` is required to use helper method of engine.
|
|\
| |
| | |
Don't publicize Kernel core extensions
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a reaction to a [bug] we hit in web-console. The cause of it was
a `Kernel` extension called `#console` that was public and was fighting
over Railties with console block to be run on `rails console`. We solved
it by making the method private. We did that through `module_function`
so `::Kernel.console` can be invoked even in `BasicObject`.
I'm proposing to make most of the core Active Support `Kernel`
extensions `module_function` as well. Those are currently public and we
are polluting every `Object` public interface with them.
```ruby
>> Object.new.respond_to? :silence_warnings
=> true
>> Object.new.respond_to? :with_warnings
=> true
>> Object.new.respond_to? :enable_warnings
=> true
>> Object.new.respond_to? :suppress
=> true
``
Some extensions like `Kernel#class_eval` should be public, but most of
them don't really need to be.
[bug]: https://github.com/rails/web-console/issues/184
|
|\ \
| | |
| | | |
Add documentation about `ActiveModel::Errors#[]` method to describe how it works [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
hotlink to the source and results for AWDwR tests
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove jquery-rails gem from generator if --skip-sprockets is true
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
on sprockets environment
- Remove jquery-rails if --skip-sprockets is true
Fixes #23431
|
|\ \ \
| | | |
| | | | |
Update assertion on redis in generated Gemfile
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Redis now included in Gemfile but commented out. This change was made in
91864439c7aebb6ca710831aac6781903a433904 and is causing the test
failure.
See https://travis-ci.org/rails/rails/jobs/106994913#L1025
|
|\ \ \
| | | |
| | | | |
Pass api only option to rails rails:update task to update only based on api Apps
|
| | | |
| | | |
| | | |
| | | | |
Fixes #23470
|
| | | |
| | | |
| | | |
| | | | |
All grown up and shit!
|
| | | |
| | | |
| | | |
| | | | |
So no need to have it on by default in the Gemfile.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
So it can properly show stats for an app with 1,000,000+ LOC
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 293bd95c3e77275193130bc14c986348aae8b0e2.
This broke the header :<
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Remove commented out code in `ci/travis.rb` [ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/innodb_supports_fulltext_and_spatial_indexes
InnoDB supports FULLTEXT and Spatial Indexes [ci skip]
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
https://dev.mysql.com/doc/refman/5.7/en/innodb-fulltext-index.html
https://dev.mysql.com/doc/refman/5.7/en/creating-spatial-indexes.html
|
|\ \ \ \
| | | | |
| | | | | |
Active Record supports MySQL >= 5.0
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Currently some features uses `information_schema` (e.g. foreign key
support). `information_schema` introduced since MySQL 5.0.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Document the fact that Action Cable does not require a multi-threaded app server
|
| | |_|/ /
| |/| | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
SQLite 2 support has been dropped [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove unused dependency
|
| | |_|/ /
| |/| | |
| | | | | |
railties uses method_source, activesupport does not. I assume code was refactored and the dependency wasn't removed.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Defer Arel attribute lookup to the model class
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This still isn't as separated as I'd like, but it at least moves most of
the burden of alias mapping in one place.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Fix line filters running tests from multiple runnables.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Because of the expanding whitelist for test filters, this test ended up
running the tests on lines 4 and 9 in the post test even though the path
wasn't right.
Happened incidentally because the same line numbers were used in both
account and post test.
Add the .rb line so the file is required correctly and the filters are
applied.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`derive_regexp` was written with the assumption that we were run from a
blank slate — that if the filter didn't match we might as well return it
because it was nil.
This isn't the case because minitest calls `run` on every runnable. Which
is any subclass of Minitest::Runnable, such as ActiveSupport::TestCase,
ActionDispatch::IntegrationTest as well as any inheriting from those.
Thus after the first `run` we'd have put in a composite filter in
`options[:filter]` making the next `run` create a linked list when it
failed to match the regexp and put the composite filter as the head.
Every runnable would accumulate more and more of the same filters,
which effectively acted like an expanding whitelist and we ran tests
from other runnables.
Clog the accumulation by returning nil if there's no filter to derive
a regexp from.
Note: we pass a seed in the tests because Minitest shuffles the runnables
to ensure the whitelist is expanded enough that the failure is triggered.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Add dummy apple icon files
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously Safari would try to load these files when you visit
localhost:3000. That created two exceptions in the log. It also caused
the exception notifier to send them out.
In response to #23427
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
prathamesh-sonpatki/improve-pg-version-old-error-message
Improve pg version old error message and mention this change in release notes.
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Remove json gem dependency
|
|/ / / /
| | | |
| | | | |
All modern Rubies ship JSON as part of stdlib. Using the gem actually hurts multi-platform support due to build difficulties on Windows.
|
|\ \ \ \
| | | | |
| | | | | |
Put some space for non-assets requests in development mode
|
| |/ / /
| | | |
| | | |
| | | | |
- Fixes #23428.
|
|\ \ \ \
| | | | |
| | | | | |
update supported version of PostgreSQL in docs [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up to #23434
|
| | | | | |
|