aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix broken assert_generates when extra keys are being checked.Jamis Buck2006-10-163-1/+7
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add 'unloadable', a method used to mark any constant as requiring an unload ↵Nicholas Seckar2006-10-153-17/+103
| | | | | | after each request. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Tidy up the markup on the bundled error pages. Closes #6379. [Tim Lucas]Michael Koziarski2006-10-153-60/+28
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5306 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix has_many :through to add the appropriate conditions when going through ↵Rick Olson2006-10-153-2/+29
| | | | | | an association using STI. Closes #5783. [Jonathan Viney] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5305 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* remove an obsolete #dup call. avoid double negatives, to make the code ↵Jamis Buck2006-10-152-10/+11
| | | | | | easier to understand and explain git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Undo accidental commitNicholas Seckar2006-10-141-42/+16
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5303 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Rename overlapping test namesNicholas Seckar2006-10-142-17/+43
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* make sure filters in subclasses with :only or :except conditions are treated ↵Jamis Buck2006-10-142-3/+42
| | | | | | like skip_filter calls git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5301 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Replace KCODE checks with String#chars for truncate. Closes #6385 [Manfred ↵Michael Koziarski2006-10-143-9/+6
| | | | | | Stienstra] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5300 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* make sure the String::Access methods return strings, and not multibyte Char ↵Jamis Buck2006-10-132-5/+32
| | | | | | instances git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* automatically add primary key to #select_limited_ids_list order by clause ↵Rick Olson2006-10-134-1/+12
| | | | | | for databases that require order columns in the distinct statements (postgresql) [Rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* fix select_limited_ids_list issues in postgresql, retain current behavior in ↵Rick Olson2006-10-135-7/+27
| | | | | | other adapters [Rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* add test for select_limited_ids_list that passes in mysql/sqlite and fails ↵Rick Olson2006-10-131-0/+15
| | | | | | in postgresql git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5290 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make page caching respect the format of the resource that is being requested ↵Marcel Molina2006-10-123-3/+26
| | | | | | even if the current route is the default route so that, e.g. posts.rss is not transformed by url_for to '/' and subsequently cached as '/index.html' when it should be cached as '/posts.rss'. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use String#chars in TextHelper::excerpt. Closes #6386 [Manfred Stienstra]Michael Koziarski2006-10-124-52/+31
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make core_ext/string/access.rb multibyte safe. Closes #6388 [Manfred Stienstra]Michael Koziarski2006-10-123-5/+8
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make String#chars slicing behaviour consistent with String. Closes #6387 ↵Michael Koziarski2006-10-123-4/+8
| | | | | | [Manfred Stienstra] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5286 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Restore eager condition interpolation, document it's differences [Rick]Rick Olson2006-10-114-4/+17
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Install named routes into ActionView::Base instead of proxying them to the ↵Nicholas Seckar2006-10-112-5/+5
| | | | | | view via helper_method. Closes #5932. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Compare to 0 rather than call zero? to handle nil.Jeremy Kemper2006-10-111-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Wrap save! in a transaction. Closes #6324.Jeremy Kemper2006-10-102-3/+7
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed default 404.html and 500.htmls to remove extreme ugliness and added ↵David Heinemeier Hansson2006-10-103-10/+90
| | | | | | error language fit for humans [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix typoNicholas Seckar2006-10-091-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5278 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Update to latest Prototype and script.aculo.us trunk versionsThomas Fuchs2006-10-0910-370/+316
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5276 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* improve example in migrations docs, closes #6370Jeremy Kemper2006-10-091-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fix relative URL root matching problemsJamis Buck2006-10-093-4/+15
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5272 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Don't rollback in teardown unless a transaction was started. Don't start a ↵Jeremy Kemper2006-10-093-5/+33
| | | | | | transaction in create_fixtures if a transaction is started. Closes #6282. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* PostgreSQL: db:test:purge closes open database connections first. Closes #6236.Jeremy Kemper2006-10-092-0/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* r5540@ks: jeremy | 2006-10-08 23:05:30 -0700Jeremy Kemper2006-10-093-74/+86
| | | | | | | | | | | #5949 r5541@ks: jeremy | 2006-10-08 23:07:08 -0700 Fix filter skipping in controller subclasses. r5557@ks: jeremy | 2006-10-08 23:11:24 -0700 Update changelog. Closes #5949, references #6297, references #6299. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5268 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Add #delete support to has_many :through associations. Closes #6049 [Martin ↵Rick Olson2006-10-093-0/+53
| | | | | | Landers] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* learn to clean up after myselfRick Olson2006-10-091-4/+0
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5266 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Reverted old select_limited_ids_list postgresql fix that caused issues in ↵Rick Olson2006-10-093-3/+8
| | | | | | mysql. Closes #5851 [Rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Removes the ability for eager loaded conditions to be interpolated, since ↵Rick Olson2006-10-099-29/+28
| | | | | | there is no model instance to use as a context for interpolation. #5553 [turnip@turnipspatch.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5264 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed test:uncommitted on Windows (backslash issue) (closes #4999) ↵David Heinemeier Hansson2006-10-092-2/+4
| | | | | | [paul@paulbutcher.com] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5263 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (closes #6234)David Heinemeier Hansson2006-10-091-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5262 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed migration creation to work with namespaced models, so script/generate ↵David Heinemeier Hansson2006-10-092-0/+5
| | | | | | model Gallery::Image will use create_table :gallery_images #6327 [BobSilva] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5261 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed rename_table on SQLite tables with indexes defined (closes #5942) ↵David Heinemeier Hansson2006-10-092-6/+39
| | | | | | [brandon@opensoul.org] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (closes #6040)David Heinemeier Hansson2006-10-091-0/+24
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5259 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added timeout option to SQLite3 configurations to deal more gracefully with ↵David Heinemeier Hansson2006-10-095-1/+11
| | | | | | SQLite3::BusyException, now the connection can instead retry for x seconds to see if the db clears up before throwing that exception (closes #6126) [wreese@gmail.com] Added default timeout setting of 5 seconds to SQLite3 database.yml configurations [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5258 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Docfix (closes #5143)David Heinemeier Hansson2006-10-091-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added update_attributes! which uses save! to raise an exception if a ↵David Heinemeier Hansson2006-10-093-1/+46
| | | | | | validation error prevents saving (closes #6192) [jonathan] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Deprecated add_on_boundary_breaking (use validates_length_of instead) ↵David Heinemeier Hansson2006-10-094-18/+16
| | | | | | (closes #6292) [BobSilva] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Doc fixes (closes #6325)David Heinemeier Hansson2006-10-091-1/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* render_text may optionally append to the response body. render_javascript ↵Jeremy Kemper2006-10-093-4/+34
| | | | | | appends by default. This allows you to chain multiple render :update calls by setting @performed_render = false between them (awaiting a better public API). git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Rename test assertion to prevent shadowing. Closes #6306.Nicholas Seckar2006-10-092-1/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* one render per testJeremy Kemper2006-10-091-16/+36
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that NumberHelper#number_to_delimiter should respect precision of ↵David Heinemeier Hansson2006-10-093-3/+20
| | | | | | higher than two digits (closes #6231) [phallstrom] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that caches_action breaks with file extensions (closes #6257) [Catfish]David Heinemeier Hansson2006-10-092-1/+8
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Fixed that FormHelper#radio_button didn't respect an :id being passed in ↵David Heinemeier Hansson2006-10-093-2/+10
| | | | | | (closes #6266) [evansj] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Added an html_options hash parameter to javascript_tag() and ↵David Heinemeier Hansson2006-10-094-4/+26
| | | | | | update_page_tag() helpers #6311 [tzaharia] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de