aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [ci skip] Recommend testing information displayed over object storedKadu Ribeiro2018-09-271-1/+1
| | | | | | Since `assigns` is not placed by default with Rails, we suggested to test if the right information was displayed instead of suggesting to test if the right object was stored in the template.
* Merge pull request #33826 from tgturner/activejob-retry-attemptsEileen M. Uchitelle2018-09-091-1/+3
|\ | | | | retry_on argument `attempts` clarification
| * clarifies documentation around the attempts arugment to retry_onGraham Turner2018-09-091-1/+3
| |
* | Merge pull request #33825 from bogdanvlviv/follow-up-33637-and-33770Eileen M. Uchitelle2018-09-094-15/+16
|\ \ | | | | | | Follow up #33637 and #33770
| * | Fix `ActiveRecord::DatabaseConfigurations`'s docsbogdanvlviv2018-09-092-6/+6
| | |
| * | Fix explanation of `ActiveRecord::Base.configurations.configs_for` in the ↵bogdanvlviv2018-09-091-6/+7
| | | | | | | | | | | | | | | | | | | | | CHANGELOG Since #33770 `#configs_for` changed method signature and it isn't supposed to work with a passed block.
| * | Fix sqlite3 url config in "Configuring Rails Applications" guidebogdanvlviv2018-09-091-3/+3
| | | | | | | | | | | | | | | See `ConnectionUrlResolver#database_from_path` in `activerecord/lib/active_record/connection_adapters/connection_specification.rb`
* | | Add missing `perform_enqueued_jobs` to error logging testyuuji.yaginuma2018-09-091-1/+1
| |/ |/| | | | | Without `perform_enqueued_jobs`, job are not executed and assertion is not done.
* | Consistently use `visitor.compile`Ryuta Kamizono2018-09-092-5/+5
| |
* | Revert a writer for `BindParam#value`Ryuta Kamizono2018-09-091-1/+1
| | | | | | | | | | | | The writer was added during Arel refactoring to pass Active Record tests at 7a29220. That is no longer used since 846832a.
* | Use `visitor.compile` instead of constructing by connection itselfRyuta Kamizono2018-09-093-7/+3
| |
* | `supports_xxx?` returns whether a feature is supported by the backendRyuta Kamizono2018-09-088-44/+32
|/ | | | Rather than a configuration on the connection.
* reflect c03bba4 in CHANGELOGsXavier Noria2018-09-082-0/+13
|
* Merge pull request #33817 from schneems/schneems/dig-simpleRichard Schneeman2018-09-073-6/+9
|\ | | | | Don’t allocate array on no args
| * Don’t allocate array on no argsschneems2018-09-073-6/+9
| | | | | | | | | | | | | | | | | | | | When no dependencies are present to be digested there is no reason to build an array just to turn around and turn it back into a string. The dependencies array is not mutated in this method so we can use the same empty array across all invocations. Total allocated: 791402 bytes (7294 objects) Total allocated: 777442 bytes (7132 objects) (791402 - 777442) / 791402.0 # => 1.76 % speed improvement
* | trace autoloads, and document hints for troubleshootingXavier Noria2018-09-073-4/+101
|/ | | | Closes #32885.
* Merge pull request #33804 from yskkin/num_stringRyuta Kamizono2018-09-084-4/+14
|\ | | | | Fix non_numeric_string?
| * Fix non_numeric_string?Yoshiyuki Kinjo2018-09-074-4/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, dirty checking was not right for the following case: ``` model.int_column = "+5" model.float_column = "0.5E+1" model.decimal_column = "0.5e-3" ``` It is enough to see whether leading character is a digit for avoiding invalid numeric expression like 'wibble' to be type-casted to 0, as this method's comment says. Fixes #33801
* | Merge pull request #33615 from ↵Rafael França2018-09-072-3/+63
|\ \ | | | | | | | | | | | | Larochelle/i18n_full_message_with_nested_attributes `ActiveModel.full_message` interaction with `index_errors`
| * | Call human_attribute_name with a string instead of a symboleMartin Larochelle2018-08-162-2/+2
| | |
| * | `ActiveModel.full_message` interaction with `index_errors`Martin Larochelle2018-08-142-3/+63
| | |
* | | Merge pull request #33756 from piecehealth/prEileen M. Uchitelle2018-09-075-2/+122
|\ \ \ | | | | | | | | Add `inspection_masks` to make values of sensitive database columns w…
| * | | Configuration item `config.filter_parameters` could also filter out ↵Zhang Kang2018-09-075-2/+122
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sensitive value of database column when call `#inspect` * Why Some sensitive data will be exposed in log accidentally by calling `#inspect`, e.g. ```ruby @account = Account.find params[:id] payload = { account: @account } logger.info "payload will be #{ payload }" ``` All the information of `@account` will be exposed in log. * Solution Add a class attribute filter_attributes to specify which values of columns shouldn't be exposed. This attribute equals to `Rails.application.config.filter_parameters` by default. ```ruby Rails.application.config.filter_parameters += [:credit_card_number] Account.last.insepct # => #<Account id: 123, credit_card_number: [FILTERED] ...> ```
* | | Formatting CHANGELOGs [ci skip]Ryuta Kamizono2018-09-076-28/+35
| | | | | | | | | | | | Fixing code block rendering, indentation, backticks, etc.
* | | Use canonical name for block localyuuji.yaginuma2018-09-072-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | `spec` is the same variable name as gemspec generated by bundler, and its intention is easier to understand than a one-letter variable. https://github.com/bundler/bundler/blob/00fd58eaa69015092ee272c4cb5aa92a5e7ee45c/lib/bundler/templates/newgem/newgem.gemspec.tt#L11 This is follow up on 1c59b4840c58097186022f68427c46e0046c5d0d. `spec` is already in use there.
* | | Merge pull request #33808 from itsbagpack/fix-access-safety-buffer-sliceAaron Patterson2018-09-063-3/+20
|\ \ \ | | | | | | | | Maintain html_safe? on sliced HTML safe strings
| * | | Update CHANGELOG for SafetyBuffer slice accessYumin Wong2018-09-061-0/+7
| | | | | | | | | | | | | | | | Co-authored-by: no-itsbackpack <no-itsbackpack@github.com>
| * | | Use assert_predicate insteadYumin Wong2018-09-061-2/+2
| | | | | | | | | | | | | | | | Co-authored-by: no-itsbackpack <no-itsbackpack@github.com>
| * | | SafeBuffer should maintain safety upon getting a slice via a range if ↵Yumin Wong2018-08-312-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | original buffer was safe. Co-Authored-By: no-itsbackpack <no-itsbackpack@github.com>
* | | | Merge pull request #33810 from schneems/schneems/doc-output-bufferRichard Schneeman2018-09-062-0/+19
|\ \ \ \ | | | | | | | | | | Document ActionView::OutputBuffer
| * | | | [ci skip] Doc ActionView::OutputBufferschneems2018-09-062-3/+17
| | | | |
| * | | | [ci skip] Clarify CaptureHelper#capture functionschneems2018-09-061-0/+5
| |/ / /
* | | | Merge pull request #33809 from fidalgo/improve-remove-column-documentationRichard Schneeman2018-09-061-0/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Improve remove_column documentation
| * | | | [ci skip] Improve remove_column documentationPaulo Fidalgo2018-09-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since when we remove one column it will also remove the associated indexes, we must ensure this behaviour is properly documented. In this commit we add a line to the documentation mentioning this behaviour.
* | | | | Merge pull request #33807 from olimart/patch-4Rafael França2018-09-061-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix typo in i18n_railtie.rb [ci skip]
| * | | | | Fix typo in i18n_railtie.rbOlivier2018-09-061-1/+1
|/ / / / /
* | | | | Fix test case to ensure default connection id is filledRyuta Kamizono2018-09-071-2/+2
| | | | | | | | | | | | | | | | | | | | Follow up of #33798.
* | | | | Merge pull request #33805 from schneems/schneems/faster-file-storeRichard Schneeman2018-09-061-6/+10
|\ \ \ \ \ | | | | | | | | | | | | Faster File Store
| * | | | | Faster File Storeschneems2018-09-061-6/+10
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | Memory before 1826584.8 memory after: 1797795.6 difference: 1.58% memory (speed) savings. When the key is not longer than the limit we can avoid allocating two strings and an array.
* | | | | Generate a gem that can't be pushed to Rubygems.org by defaultRafael Mendonça França2018-09-061-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | This will avoid gems that are made to be private to be pushed to public repositories.
* | | | | Merge pull request #33574 from ↵Rafael França2018-09-063-4/+14
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | lsylvester/change-i18n-defaults-behaviour-to-match-i18n-1.1.0 update I18n fallbacks configuration to be compatible with i18n 1.1.0
| * | | | | update I18n fallbacks configuration to be compatible with i18n 1.1.0Lachlan Sylvester2018-08-233-4/+14
| | | | | |
* | | | | | Merge pull request #33798 from got2be/actioncable-redis-client-nameRafael França2018-09-063-3/+30
|\ \ \ \ \ \ | | | | | | | | | | | | | | ActionCable: add id option to redis adapter config
| * | | | | | ActionCable: add id option to redis adapter configIlia Kasianenko2018-09-053-3/+30
| | | | | | |
* | | | | | | Merge pull request #32405 from yhirano55/use_turbolinks_in_guideRafael França2018-09-066-32/+54
|\ \ \ \ \ \ \ | |_|_|_|_|_|/ |/| | | | | | Use Turbolinks in Rails guides
| * | | | | | Use Turbolinks in Rails guidesYoshiyuki Hirano2018-04-236-32/+54
| | | | | | |
* | | | | | | Merge pull request #33799 from ↵Ryuta Kamizono2018-09-063-0/+43
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/deprecate_unused_methods_in_database_limits Deprecate most methods which were never used in `DatabaseLimits`
| * | | | | | | Deprecate most methods which were never used in `DatabaseLimits`Ryuta Kamizono2018-09-053-0/+43
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `DatabaseLimits` and those methods were introduced at 3809c80, but most methods were never used and never tested from the beginning (except `table_alias_length`, `index_name_length`, and `in_clause_length` (since 66c09372)). There is no reason to maintain unused those methods for about 8 years.
* | | | | | | Unlock ffi versionRafael Mendonça França2018-09-052-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ffi has a security issue on versions before 1.9.24 so it is better to upgrade even if that occasionally cause failures in some contributors machines.
* | | | | | | Upgrade all the gemsRafael Mendonça França2018-09-051-75/+70
| | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-19 00:43:02 +0000