| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Since `assigns` is not placed by default with Rails, we suggested to
test if the right information was displayed instead of suggesting to
test if the right object was stored in the template.
|
|\
| |
| | |
retry_on argument `attempts` clarification
|
| | |
|
|\ \
| | |
| | | |
Follow up #33637 and #33770
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
CHANGELOG
Since #33770 `#configs_for` changed method signature and it isn't
supposed to work with a passed block.
|
| | |
| | |
| | |
| | |
| | | |
See `ConnectionUrlResolver#database_from_path` in
`activerecord/lib/active_record/connection_adapters/connection_specification.rb`
|
| |/
|/|
| |
| | |
Without `perform_enqueued_jobs`, job are not executed and assertion is not done.
|
| | |
|
| |
| |
| |
| |
| |
| | |
The writer was added during Arel refactoring to pass Active Record
tests at 7a29220.
That is no longer used since 846832a.
|
| | |
|
|/
|
|
| |
Rather than a configuration on the connection.
|
| |
|
|\
| |
| | |
Don’t allocate array on no args
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When no dependencies are present to be digested there is no reason to build an array just to turn around and turn it back into a string.
The dependencies array is not mutated in this method so we can use the same empty array across all invocations.
Total allocated: 791402 bytes (7294 objects)
Total allocated: 777442 bytes (7132 objects)
(791402 - 777442) / 791402.0 # => 1.76 % speed improvement
|
|/
|
|
| |
Closes #32885.
|
|\
| |
| | |
Fix non_numeric_string?
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For example, dirty checking was not right for the following case:
```
model.int_column = "+5"
model.float_column = "0.5E+1"
model.decimal_column = "0.5e-3"
```
It is enough to see whether leading character is a digit for avoiding
invalid numeric expression like 'wibble' to be type-casted to 0, as
this method's comment says.
Fixes #33801
|
|\ \
| | |
| | |
| | |
| | | |
Larochelle/i18n_full_message_with_nested_attributes
`ActiveModel.full_message` interaction with `index_errors`
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add `inspection_masks` to make values of sensitive database columns w…
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
sensitive value of database column when call `#inspect`
* Why
Some sensitive data will be exposed in log accidentally by calling `#inspect`, e.g.
```ruby
@account = Account.find params[:id]
payload = { account: @account }
logger.info "payload will be #{ payload }"
```
All the information of `@account` will be exposed in log.
* Solution
Add a class attribute filter_attributes to specify which values of columns shouldn't be exposed.
This attribute equals to `Rails.application.config.filter_parameters` by default.
```ruby
Rails.application.config.filter_parameters += [:credit_card_number]
Account.last.insepct # => #<Account id: 123, credit_card_number: [FILTERED] ...>
```
|
| | |
| | |
| | |
| | | |
Fixing code block rendering, indentation, backticks, etc.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`spec` is the same variable name as gemspec generated by bundler, and its
intention is easier to understand than a one-letter variable.
https://github.com/bundler/bundler/blob/00fd58eaa69015092ee272c4cb5aa92a5e7ee45c/lib/bundler/templates/newgem/newgem.gemspec.tt#L11
This is follow up on 1c59b4840c58097186022f68427c46e0046c5d0d. `spec` is already in use there.
|
|\ \ \
| | | |
| | | | |
Maintain html_safe? on sliced HTML safe strings
|
| | | |
| | | |
| | | |
| | | | |
Co-authored-by: no-itsbackpack <no-itsbackpack@github.com>
|
| | | |
| | | |
| | | |
| | | | |
Co-authored-by: no-itsbackpack <no-itsbackpack@github.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
original buffer was safe.
Co-Authored-By: no-itsbackpack <no-itsbackpack@github.com>
|
|\ \ \ \
| | | | |
| | | | | |
Document ActionView::OutputBuffer
|
| | | | | |
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Improve remove_column documentation
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since when we remove one column it will also remove the associated
indexes, we must ensure this behaviour is properly documented.
In this commit we add a line to the documentation mentioning this
behaviour.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix typo in i18n_railtie.rb [ci skip]
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up of #33798.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Faster File Store
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
Memory before 1826584.8 memory after: 1797795.6 difference: 1.58% memory (speed) savings.
When the key is not longer than the limit we can avoid allocating two strings and an array.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This will avoid gems that are made to be private to be pushed to public
repositories.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
lsylvester/change-i18n-defaults-behaviour-to-match-i18n-1.1.0
update I18n fallbacks configuration to be compatible with i18n 1.1.0
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
ActionCable: add id option to redis adapter config
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|_|_|_|_|/
|/| | | | | | |
Use Turbolinks in Rails guides
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
kamipo/deprecate_unused_methods_in_database_limits
Deprecate most methods which were never used in `DatabaseLimits`
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`DatabaseLimits` and those methods were introduced at 3809c80, but most
methods were never used and never tested from the beginning (except
`table_alias_length`, `index_name_length`, and `in_clause_length` (since
66c09372)).
There is no reason to maintain unused those methods for about 8 years.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
ffi has a security issue on versions before 1.9.24 so it is better to
upgrade even if that occasionally cause failures in some contributors
machines.
|
| | | | | | | |
|