aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* move scope_level to a method on the scope objectAaron Patterson2014-08-131-7/+20
| | | | now we don't have to have a hard coded key
* Finally! None of our tests are order_dependent!Akira Matsuda2014-08-141-5/+0
|
* only look up scope level onceAaron Patterson2014-08-131-6/+7
| | | | avoid hash lookups and remove depency on the instance
* only test `prefix` onceAaron Patterson2014-08-131-2/+4
| | | | we don't need to repeat if statements
* pass consistent parameters to canonical_action?Aaron Patterson2014-08-131-5/+5
| | | | | now we only have to look up @scope[:scope_level] once per call to canonical_action? and we don't have a variable named "flag"
* fewer operations on the options hashAaron Patterson2014-08-132-11/+11
| | | | | since we pass `as` down, then we won't have to do an insert / delete dance with the options hash
* this should be accessing the hash, not calling a methodAaron Patterson2014-08-131-1/+1
|
* UnexpectedErrors may reference exceptions that can't be dumpedAaron Patterson2014-08-131-0/+17
| | | | | | UnexpectedError exceptions wrap the original exception, and the original exception may contain a reference to something that can't be marshal dumped which will cause the process to die.
* Merge pull request #16408 from aditya-kapoor/add-doc-ERB-escapeZachary Scott2014-08-131-0/+15
|\ | | | | [ci skip] add note about the ERB escape in generator docs
| * [ci skip] add note about the ERB escape in generator docsAditya Kapoor2014-08-141-0/+15
| |
* | Merge pull request #16493 from aditya-kapoor/correct-cache-store-docSantiago Pastorino2014-08-131-1/+1
|\ \ | | | | | | [ci skip] correct default cache store class
| * | [ci skip] correct default cache store classAditya Kapoor2014-08-131-1/+1
| | |
* | | Missing ActiveSupport require for calling String#firstAkira Matsuda2014-08-141-0/+1
| | |
* | | use :test delivery method for `base_test.rb`Yves Senn2014-08-132-6/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This solves errors like: ``` BaseTest#test_you_can_register_multiple_observers_to_the_mail_object_that_both_get_informed_on_email_delivery: Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 25 /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/net/smtp.rb:541:in `initialize' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/net/smtp.rb:541:in `open' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/net/smtp.rb:541:in `tcp_socket' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/net/smtp.rb:551:in `block in do_start' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/timeout.rb:91:in `block in timeout' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/timeout.rb:101:in `call' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/timeout.rb:101:in `timeout' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/net/smtp.rb:550:in `do_start' /Users/senny/.rbenv/versions/2.1.2/lib/ruby/2.1.0/net/smtp.rb:520:in `start' /Users/senny/Projects/rails/.bundle/gems/mail-2.6.1/lib/mail/network/delivery_methods/smtp.rb:112:in `deliver!' /Users/senny/Projects/rails/.bundle/gems/mail-2.6.1/lib/mail/message.rb:2136:in `do_delivery' /Users/senny/Projects/rails/.bundle/gems/mail-2.6.1/lib/mail/message.rb:232:in `block in deliver' /Users/senny/Projects/rails/actionmailer/lib/action_mailer/base.rb:528:in `block in deliver_mail' /Users/senny/Projects/rails/activesupport/lib/active_support/notifications.rb:164:in `block in instrument' /Users/senny/Projects/rails/activesupport/lib/active_support/notifications/instrumenter.rb:20:in `instrument' /Users/senny/Projects/rails/activesupport/lib/active_support/notifications.rb:164:in `instrument' /Users/senny/Projects/rails/actionmailer/lib/action_mailer/base.rb:526:in `deliver_mail' /Users/senny/Projects/rails/.bundle/gems/mail-2.6.1/lib/mail/message.rb:232:in `deliver' /Users/senny/Projects/rails/actionmailer/test/base_test.rb:598:in `block (2 levels) in <class:BaseTest>' /Users/senny/Projects/rails/actionmailer/test/base_test.rb:801:in `mail_side_effects' /Users/senny/Projects/rails/actionmailer/test/base_test.rb:593:in `block in <class:BaseTest>' ``` where the `:smtp` delivery method was leaked over to other test cases.
* | | actionmailer_tests_are_order_dependent!Akira Matsuda2014-08-131-0/+5
|/ /
* | Merge pull request #16491 from akshay-vishnoi/doc-changesYves Senn2014-08-134-5/+5
|\ \ | | | | | | [ci skip] fix spelling of overridden
| * | [ci skip] fix spelling of overrideAkshay Vishnoi2014-08-134-5/+5
| | |
* | | Railties tests are order_independent! Hopefully.Akira Matsuda2014-08-131-4/+0
| | |
* | | Fix Railties tests that were order dependentAkira Matsuda2014-08-131-0/+10
| | |
* | | AS tests are now order_independent!Akira Matsuda2014-08-131-5/+0
| | |
* | | Reset ActiveSupport::Dependencies.mechanism to make tests order independentAkira Matsuda2014-08-131-6/+10
| | |
* | | Duplicated method in the test helperAkira Matsuda2014-08-131-7/+0
| | |
* | | AM, AP, AV, and AMo tests are already order_independent!Akira Matsuda2014-08-134-20/+0
| | |
* | | Merge pull request #16489 from tomkadwill/updating_options_to_new_styleYves Senn2014-08-131-1/+1
|\ \ \ | | | | | | | | [ci skip] Updated where scope documentation to conform to new style
| * | | [ci skip] Updated where scope to conform to new styleTom Kadwill2014-08-131-1/+1
| | | |
* | | | `index_exists?` with `:name` checks specified columns.Yves Senn2014-08-133-7/+30
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Yves Senn & Matthew Draper] The column check was embodied in the defaul index name. If the :name option was used, the specified columns were not verified at all. Given: ``` assert connection.index_exists?(table_name, :foo_id, :name => :index_testings_on_yo_momma) ``` That index could have been defined on any field, not necessarily on `:foo_id`.
* | | :bomb:Rafael Mendonça França2014-08-121-1/+1
| | |
* | | Merge pull request #16476 from akshay-vishnoi/doc-changesRafael Mendonça França2014-08-122-2/+2
|\ \ \ | | | | | | | | [ci skip] use "based on" or "based off of"
| * | | use 'based on' instead of 'based off' [ci skip]Akshay Vishnoi2014-08-122-2/+2
| |/ /
* / / Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-129-8/+12
|/ /
* | CHANGELOG entry for TestCase.i_suck_and_my_tests_are_order_dependent! fixAkira Matsuda2014-08-121-0/+6
| |
* | Remove old setup from AS test caseCarlos Antonio da Silva2014-08-121-5/+0
| | | | | | | | | | This was added back in Rails 3 on c4a6109286909c394e8c5bfc471a1eb9de245d2b, and is not being used anymore.
* | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-128-4/+34
| | | | | | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* | Merge pull request #16472 from y-yagi/patch-1Carlos Antonio da Silva2014-08-121-1/+1
|\ \ | | | | | | [ci skip] Fix broken url in plugins guide
| * | [ci skip] Fix broken url in plugins guideyuuji.yaginuma2014-08-121-1/+1
|/ /
* | Merge pull request #16456 from ↵Santiago Pastorino2014-08-112-1/+8
|\ \ | | | | | | | | | | | | lsylvester/improve-active-record-error-message-on-update_columns-for-destroyed-records Change error message in update_columns for destroyed objects
| * | update error message to reflect that the record could have been destroyedlsylvester2014-08-112-1/+8
|/ /
* | Merge pull request #16300 from ↵Godfrey Chan2014-08-101-1/+5
|\ \ | | | | | | | | | | | | vast/mention-changes-to-nil-serialization-in-upgrading-from-3.2 Mention changes to `nil` handling in serialized attributes
| * | [ci skip] Clarify the "Serialized Attributes" sectionVasily Polovnyov2014-07-261-1/+2
| | | | | | | | | | | | | | | Mention that the change in nil handling for serialized attributes affects custom coders.
| * | [ci skip] Mention the change in nil handling for serialized attributesVasily Polovnyov2014-07-261-0/+3
| | | | | | | | | | | | in "Upgrading from Rails 3.2 to Rails 4.0"
* | | Merge pull request #16453 from reshleman/re-cleanup-guides-guidelinesZachary Scott2014-08-101-12/+10
|\ \ \ | | | | | | | | Cleanup Guides Guidelines [ci skip]
| * | | Cleanup Guides Guidelines [ci skip]Robert Eshleman2014-08-101-12/+10
|/ / / | | | | | | | | | | | | | | | * Copy editing for clarity in several locations * Rename "Titles" section to "Headings" * Fix incorrect anchor in link to API Documentation Guidelines for filenames
* | | Merge pull request #16451 from y-yagi/patch-2Zachary Scott2014-08-101-2/+2
|\ \ \ | | | | | | | | [ci skip] Fix sample code in engines guide
| * | | [ci skip] Fix sample code in engines guideyuuji.yaginuma2014-08-101-2/+2
|/ / /
* | | Merge pull request #16441 from ↵Santiago Pastorino2014-08-091-4/+4
|\ \ \ | | | | | | | | | | | | | | | | tomkadwill/activerecord_associations_options_param [ci skip] Changed options to +options+ for rdoc
| * | | [ci skip] Changed options to +options+ for rdocTom Kadwill2014-08-091-4/+4
| | | |
* | | | Merge pull request #16440 from tgxworld/pass_log_in_blockSantiago Pastorino2014-08-091-4/+6
|\ \ \ \ | | | | | | | | | | Pass block for logging.
| * | | | Pass block for logging.Guo Xiang Tan2014-08-091-4/+6
| | | | | | | | | | | | | | | | | | | | This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
* | | | | Merge pull request #16439 from voxxit/patch-1Santiago Pastorino2014-08-091-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Using delegated connection method
| * | | | | Using delegated connection methodJoshua Delsman2014-08-081-1/+1
| | |/ / / | |/| | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-08 05:22:52 +0000