aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | | | | | | | | Add a commented, failing test for using a habtm in a has many through ↵Jon Leighton2010-10-125-55/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | association. I want to refactor how aliasing works first.
| * | | | | | | | | | | | | | | | | Add test_has_many_through_has_one_through_with_has_many_source_reflectionJon Leighton2010-10-122-1/+19
| | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | Adding test_has_many_through_has_one_with_has_many_through_source_reflection ↵Jon Leighton2010-10-125-3/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and modifying ThroughAssociationScope to make it work correctly.
| * | | | | | | | | | | | | | | | | Rename some tests for consistencyJon Leighton2010-10-121-3/+3
| | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | Add test_has_many_through_has_one_throughJon Leighton2010-10-122-2/+17
| | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | Support has_one through assocs as the source associationJon Leighton2010-10-127-20/+71
| | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | A load of tests that need to be writtenJon Leighton2010-10-121-0/+63
| | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | Refactoring to remove duplication introduced by the last commitJon Leighton2010-10-101-160/+145
| | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | Add support for nested through associations in JoinAssociation. Hence ↵Jon Leighton2010-10-0911-94/+175
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Foo.joins(:bar) will work for through associations. There is some duplicated code now, which will be refactored.
| * | | | | | | | | | | | | | | | | Merge branch 'master' into nested_has_many_throughJon Leighton2010-10-0690-1040/+990
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | Refactoring JoinDependency and friends. This improves the code (IMO) ↵Jon Leighton2010-10-0610-209/+356
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | including adding some explanatory comments, but more importantly structures it in such a way as to allow a JoinAssociation to produce an arbitrary number of actual joins, which will be necessary for nested has many through support. Also added 3 tests covering functionality which existed but was not previously covered.
| * | | | | | | | | | | | | | | | | | A failing test for a nested has many through association loaded via ↵Jon Leighton2010-10-051-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Foo.joins(:bar)
| * | | | | | | | | | | | | | | | | | Fix the tests (I have actually verified that these are also the 'right' ↵Jon Leighton2010-10-036-24/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes, rather than just making the tests pass again)
| * | | | | | | | | | | | | | | | | | Add support for table aliasing, with a test that needs aliasing in order to ↵Jon Leighton2010-10-027-15/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | work correctly. This test incidentally provides a more complicated test case (4 inner joins, 2 using polymorphism).
| * | | | | | | | | | | | | | | | | | Integrate nested support into ThroughAssociationScope, using my concept of ↵Jon Leighton2010-10-025-59/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | generating a 'chain' of reflections to be joined. It seems to work at the moment, all existing tests are passing. There may be further complications as we add more test cases for nested associations, though.
| * | | | | | | | | | | | | | | | | | Started implementing nested :through associations by using the existing ↵Jon Leighton2010-10-014-32/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | structure of ThroughAssociationScope rather than layering a module over the top
| * | | | | | | | | | | | | | | | | | Prevent ↵Jon Leighton2010-09-301-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test_has_many_through_a_has_many_through_association_on_through_reflection failing for me due to ordering of the results
| * | | | | | | | | | | | | | | | | | Merge branch 'master' into nested_has_many_through_2Jon Leighton2010-09-30166-849/+1536
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | | Initial nested_has_many_through support [#1152]Bodaniel Jeanes2010-09-2610-15/+220
| | | | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | | remove to from to to :)Vijay Dev2011-03-161-1/+1
| |_|_|_|_|_|_|_|_|_|_|_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | Add link to mailing-listNicolas Cavigneaux2011-03-161-1/+1
| | | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | Remove incorrect comment that a default value of NULL cannot be set with ↵Manuel Meurer2011-03-161-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change_column_default.
* | | | | | | | | | | | | | | | | | | doc :anchor option for #match in routesGabriel Horner2011-03-151-0/+7
| |_|_|_|_|_|_|_|_|_|_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-03-1412-38/+40
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | | | | be be -> beXavier Noria2011-03-141-1/+1
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | move the tips about :allow_(nil|blank) near their explanations, also no need ↵Xavier Noria2011-03-141-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | to say these are options for all validators if they are not
| * | | | | | | | | | | | | | | | | | Adjust unique constraint comment to include info about the RecordNotUnique ↵Anders Elfving2011-03-131-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | exception
| * | | | | | | | | | | | | | | | | | Change ActionView::ViewPathSet to ActionView::PathSetManuel Meurer2011-03-131-4/+4
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | Removed double textsLars Smit2011-03-131-13/+0
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | remove some blanksPaco Guzman2011-03-112-4/+4
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | Minor formatting changes and remove a commentMike Gehard2011-03-101-6/+7
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | update plugin urls to reflect official maintainersVijay Dev2011-03-104-5/+5
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | Added note re: functional tests and HTTP methods.David Aaron Fendley2011-03-091-0/+2
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | expose ActionMailer::MailHelper in the RDocDiego Carrion2011-03-091-0/+1
| | | | | | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | | | | | Add a note to discourage users from using presence validators with ↵Jeff Kreeftmeijer2011-03-091-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | allow_(nil|blank)
* | | | | | | | | | | | | | | | | | | silence @dummy_path not defined warningsJack Dempsey2011-03-141-0/+1
| | | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | use parens and silence ambiguous args warningsJack Dempsey2011-03-142-18/+18
| | | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | Remove invalid testAndrew White2011-03-131-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test fails on PostgreSQL when trying to load the records as the comments_count field is not included in the GROUP BY clause.
* | | | | | | | | | | | | | | | | | | Revert "It should be possible to use ActiveSupport::DescendantTracker ↵José Valim2011-03-131-9/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | without getting ActiveSupport::Dependencies for free." This reverts commit 46f6a2e3889bae420589f429b09722a37dbdf18d. Caused failures on CI. rake test:isolated on activesupport directory show them.
* | | | | | | | | | | | | | | | | | | Refactor length validationSantiago Pastorino2011-03-122-6/+6
| | | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | length validation for fixnumsAndriy Tyurnikov2011-03-122-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | | | | | | | | | | | | | | | Fixed a bug when empty? was called on a grouped Relation that wasn't loadedChris Oliver2011-03-122-1/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [#5829 state:resolved] Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
* | | | | | | | | | | | | | | | | | | Prevent callbacks in child classes from being executed more than once.Rolf Timmermans2011-03-132-1/+31
| | | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | | It should be possible to use ActiveSupport::DescendantTracker without ↵Rolf Timmermans2011-03-131-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | getting ActiveSupport::Dependencies for free.
* | | | | | | | | | | | | | | | | | | Add additional text to NotImplementedErrors [#6328 state:resolved]Mike Gehard2011-03-123-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | | | | | | | | | | | | | | | adds a couple of missing AS dependenciesRolf Timmermans2011-03-122-0/+3
| |_|_|_|_|_|_|_|_|_|_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | Just define methods directly on the class rather than use the moduleAaron Patterson2011-03-111-14/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | indirection. clever--
* | | | | | | | | | | | | | | | | | do not automatically add format to routes that end in a slashAaron Patterson2011-03-112-1/+52
| | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | Add missing require 'thread' to BufferedLogger.José Valim2011-03-111-0/+1
| | | | | | | | | | | | | | | | | |
* | | | | | | | | | | | | | | | | | Add require 'date' to use Date.today in plugin template MIT-LICENSESamuel Kadolph2011-03-121-0/+1
| | | | | | | | | | | | | | | | | |