aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Tidy up error.rb codeSubba Rao Pasupuleti2010-08-031-5/+1
| | | | | | | | | | | | | | | | | | [#5288 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | order query is already a string, no need to to_sAaron Patterson2010-08-031-2/+2
| | |
* | | Stub is_a? not instance_of? hereSantiago Pastorino2010-08-031-1/+1
| | |
* | | Freeze options so we raise an error when people modify it in place.José Valim2010-08-032-3/+5
| | |
* | | validates_length_of should not change the options hash in place. [#5283 ↵José Valim2010-08-031-4/+7
| | | | | | | | | | | | state:resolved]
* | | Failing test for validates_length_of, when both too_short and too_long ↵rohit2010-08-031-0/+14
| | | | | | | | | | | | | | | | | | messages are set [#5283 state:open] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Avoid potentially expensive inspect call in router. [#4491 state:resolved]Samuel Lebeau2010-08-031-3/+6
| | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Refactor log-tailer to depend on File#eof? rather than File#mtimeCurtis Cablegram2010-08-031-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | [#5220 state:resolved] Eliminate 1 instance variable and 1 local variable. Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Change log-tailer to properly track multi-byte characters.Curtis Cablegram2010-08-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | When end-of-line is represented within a file as "\r\n", it is represented in memory as a single "\n". This patch eliminates the discrepancy between size on disk and size in memory. Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Remove or fix non-working examples and add a few tests to Dirty [#5185 ↵Tore Darell2010-08-032-12/+87
| | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | adding test cases for ActiveModel::ErrorsNeeraj Singh2010-08-031-0/+65
| | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Dynamic finder method like scoped_by_* create methods so thatNeeraj Singh2010-08-031-0/+6
| | | | | | | | | | | | | | | | | | | | | method_missing is not hit next time. Adding a test for this scenario. Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Making Active Record base_test.rb thinner by moving testsNeeraj Singh2010-08-035-534/+545
|/ / | | | | | | | | | | | | | | | | | | | | | | to relevant files. Number of assertions before refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Number of assertions after refactoring: 2391 tests, 7579 assertions, 0 failures, 0 errors Signed-off-by: José Valim <jose.valim@gmail.com>
* | Merge remote branch 'docrails/master' into 3-0-stableXavier Noria2010-08-0326-497/+707
|\ \
| * | Correcting the documentation which wrongly states that each dynamic finder ↵Neeraj Singh2010-08-021-7/+4
| | | | | | | | | | | | | | | | | | | | | creates method on the class. Only dynamic finders using <tt>scoped_by_*</tt> creates new methods.
| * | Adding to AR::Base documentation about dynamically scopeded_by queryNeeraj Singh2010-08-022-11/+19
| | | | | | | | | | | | User.scoped_by_user_name('David')
| * | ensuring that description does not exceed 100 columnsNeeraj Singh2010-08-0219-138/+205
| | |
| * | updating documentation to ensure line does not exceed 100 columnsNeeraj Singh2010-08-022-94/+136
| | |
| * | ensuring that documentation does not exceed 100 columnsNeeraj Singh2010-08-013-194/+282
| | |
| * | ensuring that documentation does not exceed 100 columnsNeeraj Singh2010-07-311-51/+65
| | |
| * | adding the missing closing tagNeeraj Singh2010-07-311-1/+1
| | |
| * | fixing documentation just a little bitNeeraj Singh2010-07-312-22/+16
| | |
| | * skip the before_type_cast_on_datetime test entirely for mysql2Brian Lopez2010-08-021-17/+18
| | |
| | * move reload after touchBrian Lopez2010-08-021-1/+1
| | |
| | * reload the owner model after updateBrian Lopez2010-08-021-0/+1
| | |
| | * Merge branch 'master' into mysql2Brian Lopez2010-08-0230-56/+291
| | |\ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Bring returning back to ease migration. Remove duplicated logic. Eager loading an association should not change the count of children fix loading of different elements in array then int and string [#5036 state:resolved] Tidy up previous commit. test and fix collection_singular_ids= with string primary keys [#5125 state:resolved] Handle edge cases in the previous patch. Improved how AppGenerator generates the application name. It now detects the current app name whenever possible. This means that renaming the residing directory will not effect the app name generated by AppGenerator. ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 state:resolved] Add missing require in ActiveSupport::HashWithIndifferentAccess [#5189 state:resolved] Add an internal (private API) after_touch callback. [#5271 state:resolved] added failing touch propagation test Makes rails destroy scaffold don't duplicate routes.draw do |map| |map| when using the deprecated syntax Failing test to check for route file corruption if legacy map parameter is used. [#5263 state:open] Corrected the rake test:units and test:functionals description [#5251 state:committed] Use AS::OrderedHash when trusting in the order of the hash Fix label form helper to use I18n and html options, without the need of 'nil' text param:
* | | Bring returning back to ease migration.José Valim2010-08-022-0/+44
| | |
* | | Remove duplicated logic.José Valim2010-08-021-7/+9
| | |
* | | Eager loading an association should not change the count of childrenNeeraj Singh2010-08-026-0/+42
| | | | | | | | | | | | | | | | | | [#4971 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | fix loading of different elements in array then int and string [#5036 ↵Josef Reidinger2010-08-022-3/+15
| | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Tidy up previous commit.José Valim2010-08-023-18/+16
| | |
* | | test and fix collection_singular_ids= with string primary keys [#5125 ↵Robert Pankowecki2010-08-024-3/+46
| | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Handle edge cases in the previous patch.José Valim2010-08-021-1/+2
| | |
* | | Improved how AppGenerator generates the application name. It now detects the ↵Fred Wu2010-08-022-1/+29
| | | | | | | | | | | | | | | | | | | | | | | | current app name whenever possible. This means that renaming the residing directory will not effect the app name generated by AppGenerator. [#5225 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 ↵Alex Le2010-08-023-6/+22
| | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Add missing require in ActiveSupport::HashWithIndifferentAccess [#5189 ↵Chris Hoffman2010-08-021-0/+1
| | | | | | | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Merge branch 'master' of github.com:rails/railsJosé Valim2010-08-022-1/+16
|\ \ \
| * | | Makes rails destroy scaffold don't duplicate routes.draw do |map| |map| when ↵Santiago Pastorino2010-08-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | using the deprecated syntax [#5263 state:committed]
| * | | Failing test to check for route file corruption if legacy map parameter is ↵rohit2010-08-021-0/+15
| | | | | | | | | | | | | | | | used. [#5263 state:open]
* | | | Add an internal (private API) after_touch callback. [#5271 state:resolved]José Valim2010-08-025-19/+24
| | | |
* | | | added failing touch propagation testJakub Kuźma2010-08-022-0/+19
|/ / / | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | | Corrected the rake test:units and test:functionals description [#5251 ↵Prashant P. Shah2010-08-011-1/+1
| | | | | | | | | | | | | | | | | | state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | Use AS::OrderedHash when trusting in the order of the hashSantiago Pastorino2010-08-011-2/+3
| | |
* | | Fix label form helper to use I18n and html options, without the need of ↵Carlos Antonio da Silva2010-08-012-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'nil' text param: Before: f.label :title, nil, :class => 'title' After : f.label :title, :class => 'title' [#5267 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
| | * typoBrian Lopez2010-08-021-1/+1
| | |
| | * update tests for mysql2 supportBrian Lopez2010-08-0217-26/+467
| |/ |/|
* | Makes form_helper use overriden model accessorsSantiago Pastorino2010-08-012-3/+20
| | | | | | | | [#3374 state:committed]
* | explains Array.wrap directly, rather by comparison with Kernel#Array which ↵Xavier Noria2010-08-012-4/+48
| | | | | | | | is too obscure, leaves the comparison to document the differences, and adds a comparison with the related idiom that uses the splat operator
* | DHH forgot to remove JS, CSS in generated index.html [#5261 state:resolved]Johan Lundström2010-07-311-23/+0
| | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | fixes typoXavier Noria2010-07-311-1/+1
| |