aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* _will_change! method is not needed any more [ci skip]Roberto Miranda2014-11-201-5/+0
| | | ref #15674
* Merge pull request #17683 from tgxworld/improvements_to_active_job_guideRafael Mendonça França2014-11-201-10/+12
|\ | | | | [CI SKIP] Improvements to Active Job guide.
| * [CI SKIP] Improvements to Active Job guide.Guo Xiang Tan2014-11-201-10/+12
| |
* | Merge pull request #17669 from SamSaffron/optimise_memorySean Griffin2014-11-201-1/+6
|\ \ | | | | | | PERF: avoid string allocations
| * | PERF: avoid string allocationsSam2014-11-201-1/+6
| | |
* | | synchronize code and docs for `timestamps` and `add_timestamps`.Yves Senn2014-11-206-10/+22
| |/ |/| | | | | | | | | | | | | This makes the following changes: * warn if `:null` is not passed to `add_timestamps` * `timestamps` method docs link to `add_timestamps` docs * explain where additional options go * adjust examples to include `null: false` (to prevent deprecation warnings)
* | Some valid block calls in templates caused syntax errorsAkira Matsuda2014-11-203-2/+7
| | | | | | | | Now ActionView accepts <%= foo(){ %> and <%= foo()do %> :golf:
* | Merge pull request #17575 from shikshachauhan/make-habtm-consistentRafael Mendonça França2014-11-192-1/+11
|\ \ | | | | | | Allow class_name option in habtm to be consistent with other association...
| * | Allow habtm class_name option to be consistent with other associationsshiksha2014-11-132-1/+11
| | |
* | | Fix shell quote on the release taskRafael Mendonça França2014-11-191-1/+1
| | |
* | | Reintroduce cache with testsSean Griffin2014-11-193-14/+56
| | |
* | | Add tests for `TypeMap#fetch` and push up to `TypeMap`Sean Griffin2014-11-193-5/+20
| | | | | | | | | | | | | | | | | | | | | It doesn't make sense for the subclass to implement this method, and not have it on the parent. We can also DRY up the implementation of `#lookup` to be defined in terms of fetch, which will give us a single point of entry
* | | Merge pull request #17677 from StevenNunez/patch-1Rafael Mendonça França2014-11-191-1/+0
|\ \ \ | | | | | | | | Remove bullet point to unwritten/unreferenced section
| * | | Remove bullet point to unwritten/unreferenced sectionSteven Nunez2014-11-191-1/+0
|/ / /
* | | That last test was incorrect... ☕Sean Griffin2014-11-191-10/+0
| | |
* | | Revert "PERF: optimise type lookup to avoid invoking procs"Sean Griffin2014-11-192-32/+8
| | | | | | | | | | | | This reverts commit da99a2a2982d35f670ad9647463e09bfe9032b70.
* | | Introduce test to demonstrate regression caused by da99a2a2Sean Griffin2014-11-191-0/+10
| | |
* | | Merge pull request #17662 from ↵Rafael Mendonça França2014-11-192-1/+9
|\ \ \ | | | | | | | | | | | | | | | | dtaniwaki/support-symbol-foreign-key-column-to-delete Support symbol foreign key to delete
| * | | Support symbol foreign key to deletedtaniwaki2014-11-192-1/+9
| | | |
* | | | Merge pull request #17672 from radar/date-select-spaceRafael Mendonça França2014-11-191-1/+1
|\ \ \ \ | | | | | | | | | | Add space in :start_year description for date_select
| * | | | Add space in :start_year description for date_selectRyan Bigg2014-11-191-1/+1
|/ / / /
* | | | Duplicated Hash key :promptAkira Matsuda2014-11-191-1/+1
| | | |
* | | | Improve the performance of reading attributesSean Griffin2014-11-1812-18/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We added a comparison to "id", and call to `self.class.primary_key` a *lot*. We also have performance hits from `&block` all over the place. We skip the check in a new method, in order to avoid breaking the behavior of `read_attribute`
* | | | pull the preloader allocation in to a factory methodAaron Patterson2014-11-181-1/+5
| | | |
* | | | Speed up integer casting from DBSean Griffin2014-11-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't have the check the range when the value is coming from the DB, so override type_cast_from_database to short-circuit the extra work. The difference is huge but the absolute gain is quite small. That being said this is a hotspot and it showed up on the radar when benchmarking discourse.
* | | | Make sure assert_select can assert body tagRafael Mendonça França2014-11-186-13/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f93df52845766216f0fe36a4586f8abad505cac4, reversing changes made to a455e3f4e9dbfb9630d47878e1239bc424fb7d13. Conflicts: actionpack/lib/action_controller/test_case.rb actionview/lib/action_view/test_case.rb
* | | | Remove needless call to `key?` when building attributesSean Griffin2014-11-181-2/+4
| | | | | | | | | | | | | | | | This appears to be a performance hotspot, see #17655.
* | | | LazyAttributeHash is privateSean Griffin2014-11-181-1/+1
| | | |
* | | | Remove call to `key?` in `LazyAttributeHash#[]`Sean Griffin2014-11-181-5/+1
| | | | | | | | | | | | | | | | Performance improvement, as well as improved code clarity
* | | | Merge pull request #17665 from javiervidal/fixing_documentationRafael Mendonça França2014-11-181-1/+1
|\ \ \ \ | | | | | | | | | | Ruby on Rails 3.0 Release Notes: fix broken link
| * | | | Ruby on Rails 3.0 Release Notes: fix broken linkJavier Vidal2014-11-181-1/+1
|/ / / /
* | | | Merge pull request #17660 from rishijain/update_docs_11Xavier Noria2014-11-181-2/+2
|\ \ \ \ | | | | | | | | | | fixed minor typos in RELEASE doc [ci skip]
| * | | | fixed minor typos in RELEASE doc [ci skip]Rishi Jain2014-11-181-2/+2
| |/ / /
* | | | Merge pull request #17658 from SamSaffron/optimise_memoryXavier Noria2014-11-181-1/+3
|\ \ \ \ | |/ / / |/| | / | | |/ | |/| PERF: stop allocating the string "id" over and over
| * | PERF: stop allocating the string "id" over and overSam2014-11-181-1/+3
| | |
* | | Revert "[PERF] Speed up integer type casting from DB"Godfrey Chan2014-11-171-4/+1
| | | | | | | | | | | | | | | | | | This reverts commit 6f7910a and 52c70d4. Query params are type cased through the same method, so this approach doesn't work.
* | | :nail_care: Put escape clause first, keeps @sgrif happy :grin:Godfrey Chan2014-11-171-1/+2
| | | | | | | | | | | | See comment on 6f7910a
* | | [PERF] Speed up integer type casting from DBGodfrey Chan2014-11-171-1/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't have the check the range when the value is coming from the DB, so override type_cast_from_database to short-circuit the extra work. type_cast_from_database (small) 3437507.5 (±29.2%) i/s - 14223135 in 4.996973s type_cast_from_database (large) 3158588.7 (±28.3%) i/s - 13265628 in 4.992121s type_cast (small) 481984.8 (±14.2%) i/s - 2352012 in 5.005694s type_cast (large) 477331.8 (±14.2%) i/s - 2332824 in 5.012365s Comparison: type_cast_from_database (small): 3437507.5 i/s type_cast_from_database (large): 3158588.7 i/s - 1.09x slower type_cast (small): 481984.8 i/s - 7.13x slower type_cast (large): 477331.8 i/s - 7.20x slower The difference is huge but the absolute gain is quite small. That being said this is a hotspot and it showed up on the radar when benchmarking discourse.
* | Remove the unused second argument to `substitute_at`Sean Griffin2014-11-1711-25/+12
| | | | | | | | Oh hey, we got to remove some code because of that!
* | rm `reorder_bind_params`Sean Griffin2014-11-179-25/+7
| | | | | | | | | | | | Arel handles this for us automatically. Updated tests, as BindParam is no longer a subclass of SqlLiteral. We should remove the second argument to substitute_at entirely, as it's no longer used
* | Force table creation in testsSean Griffin2014-11-171-2/+2
| | | | | | | | | | | | If something causes the teardown block to not get run (errors, interrupting test runs), we have to manually delete them, which is a pain.
* | Generate new applications with the right rails-dom-testing versionRafael Mendonça França2014-11-171-2/+4
| |
* | Use GitHub, not my local fork :sweat_smile:Rafael Mendonça França2014-11-171-1/+1
| |
* | document_root_element need to be publicRafael Mendonça França2014-11-173-9/+10
| |
* | Merge pull request #17647 from tgxworld/fix_typoAbdelkader Boudih2014-11-171-1/+1
|\ \ | | | | | | Fix typo. [ci skip]
| * | Fix typo.Guo Xiang Tan2014-11-171-1/+1
|/ /
* | Improve the performance of quoting table names on PGSean Griffin2014-11-171-4/+15
| | | | | | | | | | | | This caused a pretty major performance regression for 4.2, as this is a hotspot for query construction. We're still slightly slower than 4.1, but it's much less significant.
* | Add StackProf to the test group for 2.1Sean Griffin2014-11-171-0/+4
| | | | | | | | Makes life easier for people profiling on master.
* | Remove pointless `private`Sean Griffin2014-11-171-2/+0
| | | | | | | | This class no longer has any private methods
* | Merge pull request #17643 from SamSaffron/select_all_perfSean Griffin2014-11-172-8/+32
|\ \ | | | | | | PERF: optimise type lookup to avoid invoking procs
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 04:31:14 +0000