Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Modifies belong_to touch callback to touch old associations also #9091 | Adam Gamble | 2013-03-14 | 3 | -10/+34 |
| | |||||
* | + Add test for auto timestamps update of both old & new parent records | PikachuEXE | 2013-03-14 | 2 | -0/+38 |
| | |||||
* | Merge pull request #9711 from vipulnsward/moar_cleanups | Steve Klabnik | 2013-03-13 | 4 | -6/+5 |
|\ | | | | | MOAR cleanups of unused variables. | ||||
| * | MOAR cleanups. | Vipul A M | 2013-03-14 | 4 | -6/+5 |
|/ | |||||
* | Add extra clarifying line in docs. [ci skip] | Steve Klabnik | 2013-03-13 | 1 | -0/+1 |
| | |||||
* | Fix docs: response -> request. | Steve Klabnik | 2013-03-13 | 1 | -2/+2 |
| | | | | Even though I read it carefully, my brain tricked me. :cry: | ||||
* | Merge pull request #9698 from garethrees/request_documentation | Steve Klabnik | 2013-03-13 | 1 | -0/+16 |
|\ | | | | | Add documentation to ActionDispatch::Request | ||||
| * | Add documentation to ActionDispatch::Request | Gareth Rees | 2013-03-13 | 1 | -0/+16 |
| | | |||||
* | | Merge pull request #9690 from trevorturk/upgrade-notes | Rafael Mendonça França | 2013-03-13 | 1 | -0/+26 |
|\ \ | | | | | | | Rails 4 upgrade notes about clashing named route selection changes | ||||
| * | | Document change to clashing named route selection from journey commit 98a9802a | Trevor Turk | 2013-03-12 | 1 | -0/+26 |
| | | | |||||
* | | | Merge pull request #9699 from rubys/scaffold_password_digest | Carlos Antonio da Silva | 2013-03-13 | 11 | -14/+90 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for generate scaffold password:digest * adds password_digest attribute to the migration * adds has_secure_password to the model * adds password and password_confirmation password_fields to _form.html * omits password from index.html and show.html * adds password and password_confirmation to the controller * adds unencrypted password and password_confirmation to the controller test * adds encrypted password_digest to the fixture | ||||
| * | | | Add support for generate scaffold password:digest | Sam Ruby | 2013-03-13 | 11 | -14/+90 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | * adds password_digest attribute to the migration * adds has_secure_password to the model * adds password and password_confirmation password_fields to _form.html * omits password entirely from index.html and show.html * adds password and password_confirmation to the controller * adds unencrypted password and password_confirmation to the controller test * adds encrypted password_digest to the fixture | ||||
* | | | Move some railties changelog entries to the top [ci skip] | Carlos Antonio da Silva | 2013-03-13 | 1 | -20/+21 |
| | | | |||||
* | | | Merge pull request #9700 from senny/6513_integration_test_headers | Andrew White | 2013-03-13 | 5 | -65/+206 |
|\ \ \ | | | | | | | | | rework passing headers and env variables in integration tests | ||||
| * | | | `Http::Headers` respects dotted env vars, symbols, headers with numbers. | Yves Senn | 2013-03-13 | 2 | -11/+33 |
| | | | | |||||
| * | | | allow headers and env to be passed in `IntegrationTest`. | Yves Senn | 2013-03-13 | 5 | -36/+119 |
| | | | | | | | | | | | | | | | | Closes #6513. | ||||
| * | | | refactor, `Http::Headers` stores headers in env notation | Yves Senn | 2013-03-13 | 2 | -29/+42 |
| | | | | | | | | | | | | | | | | | | | | Also: cleanup, use consistent syntax for `Http::Header` and test. | ||||
| * | | | Http::Headers respects headers that are not prefixed with HTTP_ | Yves Senn | 2013-03-13 | 3 | -7/+30 |
|/ / / | |||||
* | | | Merge pull request #9694 from ↵ | Carlos Antonio da Silva | 2013-03-13 | 1 | -1/+1 |
|\ \ \ | |_|/ |/| | | | | | | | | vipulnsward/change_from_each_to_each_value_in_http_params Change from each to each_value in http/parameters since we don't use key | ||||
| * | | Change from each to each_value in http/parameters since we don't use key | Vipul A M | 2013-03-13 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #9696 from senny/typo_in_changelog | Andrew White | 2013-03-13 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | fix typo in Active Record CHANGELOG [ci skip] | ||||
| * | | | fix typo in Active Record CHANGELOG [ci skip] | Yves Senn | 2013-03-13 | 1 | -1/+1 |
|/ / / | |||||
* | | | Add regression tests for #9678 | Andrew White | 2013-03-13 | 1 | -0/+16 |
| | | | | | | | | | | | | | | | The bug with `ActiveSupport::TimeZone.parse` described in #9678 was unwittingly fixed in 005d910 so add some tests to prevent regression. | ||||
* | | | removing out of date comment. ↵ | Aaron Patterson | 2013-03-12 | 1 | -3/+0 |
| | | | | | | | | | | | | :heart::heart::heart::heart::heart::heart::heart::heart::heart::heart::heart::heart: @pixeltrix | ||||
* | | | drop memory consumption and startup speed by switching to define_method | Aaron Patterson | 2013-03-12 | 1 | -23/+28 |
| | | | |||||
* | | | Merge pull request #9687 from stouset/patch-1 | Rafael Mendonça França | 2013-03-12 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Also quote extension name in disable_extension | ||||
| * | | | Also quote extension name in disable_extension | Stephen Touset | 2013-03-12 | 1 | -1/+1 |
|/ / / | | | | | | | A patch was committed recently which quoted the extension name in the SQL for `enable_extension`. But the same wasn't done for `disable_extension`. | ||||
* | | | Stop calling "super" twice in Rails::Server#app | Carlos Antonio da Silva | 2013-03-12 | 1 | -1/+4 |
| | | | | | | | | | | | | Cache the value of "super" in a variable and use it instead. | ||||
* | | | Remove manual "return true" from AS::TZ match method | Carlos Antonio da Silva | 2013-03-12 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #9676 from neerajdotname/9567-destroy-should-call-destroy-all | Rafael Mendonça França | 2013-03-12 | 1 | -2/+3 |
|\ \ \ | |/ / |/| | | dependent: :destroy should call destroy_all | ||||
| * | | dependent: :destroy should call destroy_all | Neeraj Singh | 2013-03-11 | 1 | -2/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit https://github.com/rails/rails/pull/9668 shows warning when `delete_all` is invoked with `:dependent` option `:destroy`. Unfortunately invoking `Post.destroy_all` invokes `post.comments.delete_all` as part of `has_many` callbacks. This commit ensures that instead `post.comments.destroy_all` is invoked and in the process no warning is generated. See issue #9567 for details . | ||||
* | | | Merge pull request #9615 from mmb/copy_table_binary_sqlite | Carlos Antonio da Silva | 2013-03-12 | 3 | -2/+23 |
|\ \ \ | | | | | | | | | | | | | | | | | Pass column to quote when copying a sqlite table. To make quote escape binary data correctly it needs the column passed in. | ||||
| * | | | Pass column to quote when copying a sqlite table. | Matthew M. Boedicker | 2013-03-11 | 3 | -2/+23 |
| | |/ | |/| | | | | | | | To make quote escape binary data correctly it needs the column passed in. | ||||
* | | | Merge pull request #9681 from vipulnsward/fix_typo_in_module_name | Carlos Antonio da Silva | 2013-03-12 | 4 | -7/+7 |
|\ \ \ | |/ / |/| | | Fix typo in DependenciesTestHelpers module name | ||||
| * | | Fix typo in DependenciesTestHelpers module name | Vipul A M | 2013-03-12 | 4 | -7/+7 |
| | | | |||||
* | | | Fix typo [ci skip] | Carlos Antonio da Silva | 2013-03-11 | 1 | -1/+1 |
| |/ |/| | |||||
* | | promotes change_column_null to the migrations API | Xavier Noria | 2013-03-11 | 2 | -0/+27 |
| | | |||||
* | | quick pass over the RDoc of schema_statements.rb [ci skip] | Xavier Noria | 2013-03-11 | 1 | -122/+190 |
| | | |||||
* | | documents how to DROP DEFAULT [ci skip] | Xavier Noria | 2013-03-11 | 1 | -3/+7 |
| | | |||||
* | | Merge pull request #9668 from neerajdotname/9567-delete-all-warning | Xavier Noria | 2013-03-11 | 1 | -0/+9 |
|\ \ | | | | | | | Show warning message if delete_all is firing callbacks | ||||
| * | | Show warning message if delete_all is firing callbacks | Neeraj Singh | 2013-03-11 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | `post.comments.delete_all` will fire callbacks if :dependent option is :destroy . It will be fixed in Rails 4.1 . In the meantime display a warning . Look at #9567 for details . | ||||
* | | | Replace assert_(no_)match args from regexps to strings to remove warnings | Carlos Antonio da Silva | 2013-03-11 | 1 | -40/+40 |
| | | | | | | | | | | | | | | | | | | Using regexps as arguments without parentheses end up raising: warning: ambiguous first argument; put parentheses or even spaces | ||||
* | | | Skip fetching path if the iteration is going to be skipped | Carlos Antonio da Silva | 2013-03-11 | 1 | -2/+2 |
| | | | |||||
* | | | There's no need to install test group in travis | Santiago Pastorino | 2013-03-11 | 2 | -2/+2 |
| | | | |||||
* | | | Move benchmark-ips to test group | Santiago Pastorino | 2013-03-11 | 1 | -2/+2 |
| | | | |||||
* | | | Use platforms instead of conditionals in Gemfile | Santiago Pastorino | 2013-03-11 | 1 | -4/+7 |
| | | | |||||
* | | | Merge pull request #9666 from sikachu/master-fix-test_test_failure | Rafael Mendonça França | 2013-03-11 | 1 | -1/+17 |
|\ \ \ | | | | | | | | | Make sure that the test case is run under test env | ||||
| * | | | Make sure that the test case is run under test env | Prem Sichanugrist | 2013-03-11 | 1 | -1/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | * Unset $RAILS_ENV that got set by abstract_unit to trigger the default. * split out environment setting since Ruby 1.9.3 doesn't support inline ENV setting. | ||||
* | | | | Mention that debugging can be slow. | Steve Klabnik | 2013-03-11 | 1 | -0/+2 |
|/ / / | | | | | | | | | | | | | | | | https://github.com/rails/rails/pull/3180\#issuecomment-14705821 has mention of rendering going from 1-2ms to 4 seconds with this on, which seems reasonable: debugging is slow. | ||||
* | | | default the reaping frequency to 10 seconds | Aaron Patterson | 2013-03-11 | 1 | -1/+1 |
| | | |