| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Don't blindly call blame_file! on exceptions in ActiveSupport::Dependes::Loadable
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
ActiveSupport::Dependencies::Loadable
It is possible under some environments to receive an Exception that is
not extended with Blamable (e.g. JRuby).
ActiveSupport::Dependencies::Loadable#load_dependency blindly call
blame_file! on the exception which throws it's own NoMethodError
exception and hides the original Exception.
This commit fixes #9521
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove column restrictions for `#count`, let the database raise if the SQL is invalid.
|
| | | | | | |
|
|/ / / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
wangjohn/chnges_for_automatic_inverse_associations
Documentation and cleanup of automatic discovery of inverse associations
|
| | |/ /
| |/| |
| | | |
| | | |
| | | | |
of using +inverse_of: false+ option. Changing the documentation and
adding a CHANGELOG entry for the automatic inverse detection feature.
|
|\ \ \ \
| | | | |
| | | | | |
fixed typo in action_view template
|
| |/ / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Testing CheckPending middleware
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Time.at allows passing a single Time argument which is then converted
to an integer. The conversion code since 1.9.3r429 explicitly checks
for an instance of Time so we need to override it to allow DateTime
and ActiveSupport::TimeWithZone values.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Update Getting Started Guide - Strong Parameter [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
modified: guides/source/getting_started.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 257fa6897d9c85da16b7c9fcb4ae3008198d320e, reversing
changes made to 94725b81f5588e4b0f43222c4f142c3135941b4b.
The build failed
https://travis-ci.org/rails/rails/builds/7883546
|
|\ \ \ \
| | | | |
| | | | | |
Improve performance of ActiveRecord::Relation#blank?
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is an SQL improvement to ActiveRecord::Relation#blank?. Currently,
it calls `to_a` on the Relation, which loads all records in the
association, and calls `blank?` on the loaded Array. There are other
ways, however, to check the emptiness of an association that are far
more performant. `#empty?`, `#exists?` and `#any?` all attach a `LIMIT
1` to the SQL query before firing it off, which is a nice query
improvement. `#blank?` should do the same!
Bonus performance improvements will also happen for `#present?`, which
merely calls the negation of `#blank?`
Signed-off-by: David Celis <me@davidcel.is>
|
|\ \ \ \
| | | | |
| | | | | |
Ignore activemodel/log/ folder
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix some typos [ci skip]
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Docfix: Use public interface instead of setting instance variables
|
|/ / / / /
| | | | |
| | | | | |
Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor.
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Rather than raising ThrowResult when construct_limited_ids_conditions comes up empty, set the relation to NullRelation and rely on its results.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
up empty, set the relation to NullRelation and rely on its results.
This will help avoid errors like 2fcafee250ee2, because in most cases NullRelation will do the right thing. Minor bonus is avoiding the use of exceptions for flow control.
|
| | | | |
| | | | |
| | | | |
| | | | | |
#calculate(:count)
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
table's columns.
|
| | | | |
| | | | |
| | | | |
| | | | | |
failing to construct_limited_ids_condition.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
As we have moved to rails/docrails from lifo/docrails
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Changing links to guides.
We are not worried for old versions as GitHub is
handling the redirects.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
railties/test/application/loading_test.rb
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Add info about contributing to docs to CONTRIBUTING.md
|
|/ / / /
| | | |
| | | |
| | | | |
Encourage more people to contribute to Rails docs by mentioning it in the contribution guide.
|
|\ \ \ \
| | | | |
| | | | | |
Fixing build for not checking migration
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Need to pass parameters
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fixes #10432 add_column not creating array columns in PostgreSQL
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When then PostgreSQL visitor was [added](https://github.com/rails/rails/commit/6b7fdf3bf3675a14eae74acc5241089308153a34)
`add_column` was no longer receiving the column options directly. This
caused the options to be lost along the way.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
activerecord/test/cases/adapters/postgresql/bytea_test.rb
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix mismatching variable names when using an underscore
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The ERBTracker template digest helper class was using a regex to match
render calls and it was incorrectly not matching against variables with
underscores in the name. This caused it to use the wrong regex match data
to populate the template dependency. Because underscore is a valid
character for a variable, this fixes the ERBTracker to match it properly.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Refactor ActionDispatch::Http::Parameters#normalize_encode_params
|