| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Because merging the association scope was removed.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`merge! association.scope(nullify: false)` is expensive but most methods
do not need the merge.
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
Update Guides to use macOS instead of Mac OS X [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Remove the top-level `HashWithIndifferentAccess` contant
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This constant was kept for the sake of backward compatibility; it
is still available under `ActiveSupport::HashWithIndifferentAccess`.
Furthermore, since Ruby 2.5 (https://bugs.ruby-lang.org/issues/11547)
won't support top level constant lookup, people would have to update
their code anyway.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Do not run `git init` in dummy application
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Improve `create_table force: true`
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Extra `data_source_exists?(table_name)` is unneeded if
`drop_table(table_name, if_exists: true)` directly.
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Add assertion to polymorphic_routes_test.rb
|
| | | | | | | |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The assertion will ensure that the behavior doesn't regress.
assert_equal "/projects", polymorphic_path("projects")
Remove FIXME related to polymorphic_url behavior.
polymorphic_url with Symbol or String works equally.
Example:
default_url_options[:host] = "example.com"
polymorphic_url(:projects) # => "http://example.com/projects"
polymorphic_url("projects") # => "http://example.com/projects"
Related to 37d4415a7b433fcb987b1c6a5b51bf2d8efc5d5e
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add missing module namespacing wrapper
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
refs: #28011
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Unfreeze interpolated string because it's unnecessary.
|
|/ / / / / / |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove deprecate passing string to `:if` and `:unless` conditional options [ci skip]
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
Follow up to #27608
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Change engines guide to demonstrate maintained forum
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Change Rails engine guide to references a maintained project
Thredded instead of the abandoned project Forem. I chose
Thredded as Forem's closing note (below) suggests the choice.
https://github.com/rubysherpas/forem/blob/rails4/README.md
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Remove `:doc:` for `NumericalityValidator` [ci skip]
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The `:doc:` was added in cdb9d7f but `NumericalityValidator` is already
`:nodoc:` class. `:doc:` is unneeded.
https://github.com/rails/rails/blob/master/activemodel/lib/active_model/validations/numericality.rb#L3
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix typo in I18n Guide [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix doc in Multibyte::Chars [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Change ActiveModel::Validation to ActiveModel::Validations in comments
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove redundant namespaces from sample code of `deprecated_method_wa…
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix a tests of AR::ValueTooLong when using OracleAdapter
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Indicate units of 'limit' in 'Integer' error message.
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
mtsmfm/fix-generator-command-for-nested-rails-engine-take-2
Fix generator command for nested (namespaced) rails engine (take 2)
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Rewrite https://github.com/rails/rails/pull/27550
085546df45 was reverted (b6ffb5efcb) because it change the return of `namespaced_path` from String to Array.
----------------
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove unused DdlHelper in ForeignKeyTest
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use ActiveRecord `bigint` type, not SQL literal bigint
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Oracle database itself does not have `bigint` SQL type, then it gets `ORA-00902: invalid datatype`.
It can be addressed by using ActiveRecord `bigint` type
because Oracle enhanced adapter recognizes ActiveRecord `bigint` type
and transfer it to its equivalent SQL type `NUMBER(19)`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Should keep the primary key column order
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes CI failure caused by #27961.
https://travis-ci.org/rails/rails/jobs/201472146#L2390-L2409
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Not ants were harmed! 🐜 [ci skip]
|
|/ / / / / / |
|