aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Add note on defaults block optionBrandon Weaver2016-12-141-0/+8
| | | | | | | | | | | | | | | When I was looking for how to default the entire routes file to JSON I could only find the postfix option. It was mentioned on IRC that you could do this with a block as well and I had not found it in the documentation.
* | | | | Merge pull request #27388 from maclover7/jm-argvEileen M. Uchitelle2016-12-192-0/+17
|\ \ \ \ \ | | | | | | | | | | | | `ARGV.shift` before calling Rails generators
| * | | | | `ARGV.shift` before calling Rails generatorsJon Moss2016-12-172-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gems like rspec-rails depend on `ARGV` being shifted, and `scaffold` (for example) not being the first item in `ARGV`. This should allow rspec-rails to be passing on Rails master.
* | | | | | Merge pull request #27400 from kamipo/remove_useless_test_supports_primary_keyEileen M. Uchitelle2016-12-191-6/+0
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Remove useless `test_supports_primary_key`
| * | | | | Remove useless `test_supports_primary_key`Ryuta Kamizono2016-12-191-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `supports_primary_key?` method is defined in `AbstractAdapter` so does not raise any errors.
* | | | | | `protected` here doesn't protect anythingAkira Matsuda2016-12-191-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | there aren't any instance method defined in this class
* | | | | | Merge pull request #27401 from kamipo/consolidate_duplicated_elsif_branchMatthew Draper2016-12-191-6/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Consolidate duplicated elsif branch
| * | | | | Consolidate duplicated elsif branchRyuta Kamizono2016-12-191-6/+1
|/ / / / /
* | | | | fields: support attributes not on model.Kasper Timm Hansen2016-12-182-0/+37
| | | | | | | | | | | | | | | | | | | | Ensure the support works like form_with.
* | | | | [ci skip] fields don't output ids by default anymore.Kasper Timm Hansen2016-12-181-2/+2
| | | | |
* | | | | form_with: allow methods outside the model.Kasper Timm Hansen2016-12-183-16/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Has the handy effect of making the initial examples in the form_with docs work too. Had to do some finagling such that form_with's without a scope didn't wrap their names in braces ala `[title]`.
* | | | | [ci skip] Replace remote with local in form_with doc.Kasper Timm Hansen2016-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | Remote is gone, long live local.
* | | | | Make attributes output in html opt-in.Kasper Timm Hansen2016-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By using `except` any option provided to `form_with` would become an html attribute unless explicitly opted out. This proved annoying when adding new internal keys in the options hash and seeing them pop up in the html output. Prevent this by inverting the `except` to `slice` out the keys we want to allow becoming html attributes, like id and class.
* | | | | Merge pull request #27396 from bianjp/fix-kindlerbXavier Noria2016-12-184-13/+10
|\ \ \ \ \ | | | | | | | | | | | | Fix rake guides:generate:kindle error
| * | | | | Fix rake guides:generate:kindle errorBian Jiaping2016-12-184-13/+10
|/ / / / /
* | | | | Merge pull request #27366 from utilum/avoid_fixnum_warningMatthew Draper2016-12-181-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix Fixnum deprecated warning in Ruby 2.4+
| * | | | | Fix Fixnum deprecated warning in Ruby 2.4+utilum2016-12-161-1/+1
| | |/ / / | |/| | |
* | | | | Merge pull request #27329 from kamipo/simplify_unsigned_regexEileen M. Uchitelle2016-12-172-3/+2
|\ \ \ \ \ | | | | | | | | | | | | Simplify the regex for `unsigned?` method
| * | | | | Simplify the regex for `unsigned?` methodRyuta Kamizono2016-12-112-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`.
* | | | | | Merge pull request #27339 from utilum/puts_adapterEileen M. Uchitelle2016-12-171-0/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Improve clarity of AJ tests output
| * | | | | | Output adapter being tested.utilum2016-12-121-0/+1
| | | | | | |
* | | | | | | How to disable scaffolds.scss in generators.md (#27383)Eike Send2016-12-171-1/+9
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * How to disable scaffolds.scss in generators.md * Improves workflow customization text in generators.md
* | | | | | Merge pull request #27393 from elpic/masterप्रथमेश Sonpatki2016-12-171-0/+6
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Add missing option on number helper
| * | | | | Add missing option on numbers helperPablo Ifran2016-12-171-0/+6
|/ / / / / | | | | | | | | | | | | | | | | | | | | The `delimiter_pattern` option was not present on the documentaion of the helper.
* | | | | Merge pull request #27387 from MSP-Greg/masterRafael França2016-12-164-8/+8
|\ \ \ \ \ | | | | | | | | | | | | Change ActiveModel::Type::Helpers to :nodoc: [ci skip]
| * | | | | Change ActiveModel::Type::Helpers to :nodoc: [ci skip]MSP-Greg2016-12-164-8/+8
| | | | | |
* | | | | | Merge pull request #27386 from kevinhughes27/add-generator-command-line-arg-docsRafael França2016-12-161-0/+20
|\ \ \ \ \ \ | | | | | | | | | | | | | | Docs Command Line Arguments for Generators
| * | | | | | [ci skip] add a section explaining command line arguments for generatorsKevin Hughes2016-12-161-0/+20
| | | | | | |
* | | | | | | Merge pull request #27375 from kirs/fixture-error-messageRafael França2016-12-163-4/+20
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Throw friendly error message when fixture is not a hash
| * | | | | | | Throw friendly error message when fixture is not a hashKir Shatrov2016-12-153-4/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid.
* | | | | | | | Bump coffee-script-source to fix bugeileencodes2016-12-161-1/+1
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Coffee script 1.12.1 was released and contained a bug where coffee script was undefined. 1.12.1 was yanked and 1.12.2 was released. This bumps coffee-script-source so that CI Railties tests pass. See: https://github.com/jashkenas/coffeescript/issues/4403
* | | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-12-161-1/+1
|\ \ \ \ \ \ \
| * | | | | | | Remove mention of SafeErb gem [ci skip]Prathamesh Sonpatki2016-11-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Followup of https://github.com/rails/rails/pull/27086
* | | | | | | | Merge pull request #27368 from matthewd/doubled-callbacksMatthew Draper2016-12-162-18/+77
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | Support double-yield inside an around callback
| * | | | | | | Support double-yield inside an around callbackMatthew Draper2016-12-152-18/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's questionable whether this is a good thing -- it forces any later/ inner callback to handle multiple invocations, along with the actual wrapped action. But it worked prior to 871ca21f6a1d65c0ec78cb5a9641411e2210460b, so we shouldn't break it unintentionally.
* | | | | | | | Merge pull request #27341 from richardmonette/fix-querycache-nil-dupRafael França2016-12-155-5/+34
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | fix QueryCache nil dup
| * | | | | | | | fix QueryCache nil dupRichard Monette2016-12-155-5/+34
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog
* | | | | | | | Merge pull request #27367 from georgeclaghorn/local-form-withKasper Timm Hansen2016-12-152-4/+10
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Avoid invalid attribute on local forms generated by `form_with`
| * | | | | | | | Avoid invalid attribute on local forms generated by `form_with`George Claghorn2016-12-152-4/+10
| | |_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes that the following ERB template would result in invalid HTML output: <%= form_with model: Post.new, local: true do |form| %> <% end %> Specifically, the resulting form tag would have a spurious `remote` attribute: <form remote="false" ...>
* / | | | | | | Add missing spaces to button_tag api doc [ci skip] (#27369)Andreas Maierhofer2016-12-151-1/+1
|/ / / / / / /
* | | | | | | Merge pull request #27358 from utilum/27347Jon Moss2016-12-141-0/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Mention JS Runtime dependency in dev dependencies guide [ci skip].
| * | | | | | | Mention JS Runtime dependency in dev dependencies guide [ci skip].utilum2016-12-141-0/+4
| | | | | | | |
* | | | | | | | Merge pull request #27354 from Shopify/fix-constantize-and-prepended-modulesRafael França2016-12-144-1/+16
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix constantize edge case involving prepend, autoloading and name conflicts
| * | | | | | | | Fix constantize edge case involving prepend, autoloading and name conflictsJean Boussier2016-12-144-1/+16
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the following situation: ```ruby class Bar end module Baz end class Foo prepend Baz end class Foo::Bar end ``` Running `Inflector.constantize('Foo::Bar')` would blow up with a NameError. What is happening is that `constatize` was written before the introduction of prepend, and wrongly assume that `klass.ancestors.first == klass`. So it uses `klass.ancestors.inject` without arguments, as a result a prepended module is used in place of the actual class.
* | | | | | | | Merge pull request #27353 from mtsmfm/remove-unused-methodEileen M. Uchitelle2016-12-141-4/+0
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Remove unused method `namespaced_file_path`
| * | | | | | | Remove unused method `namespaced_file_path`Fumiaki MATSUSHIMA2016-12-141-4/+0
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` $ git grep namespaced_file_path railties/lib/rails/generators/named_base.rb: def namespaced_file_path railties/lib/rails/generators/named_base.rb: @namespaced_file_path ||= namespaced_class_path.join("/") ```
* | | | | | | Merge pull request #27350 from y-yagi/use_appropriate_type_for_rc_optionKasper Timm Hansen2016-12-141-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | use appropriate type for `rc` option
| * | | | | | | use appropriate type for `rc` optionyuuji.yaginuma2016-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning. ``` Expected boolean default value for '--rc'; got "~/.railsrc" (string) ```
* | | | | | | | Missing require "active_support/testing/constant_lookup"Akira Matsuda2016-12-141-0/+1
| | | | | | | |
* | | | | | | | Merge pull request #27349 from y-yagi/fix_ruby_warning_in_ruby_2_4Rafael França2016-12-132-2/+2
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | fix new warning in ruby 2.4
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 04:12:08 +0000