aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add CHANGELOG entry for #3578 [ci skip]Rafael Mendonça França2012-08-212-0/+10
|
* Merge pull request #3578 from amatsuda/remove_j_alias_for_json_escapeRafael Mendonça França2012-08-211-7/+0
|\ | | | | Remove j alias for ERB::Util.json_escape
| * Remove j alias for ERB::Util.json_escapeAkira Matsuda2011-11-091-7/+0
| |
* | Remove app building setup/teardown for remote ip railtie testsCarlos Antonio da Silva2012-08-211-14/+0
| | | | | | | | | | These tests rely on "make_basic_app", which is a faster version that does not need to create the whole app directory structure.
* | Set eager load option in "make_basic_app" for railties testsCarlos Antonio da Silva2012-08-211-0/+1
| | | | | | | | Avoid output with config option not set when running some tests.
* | Merge pull request #7225 from rails/eager_loadJosé Valim2012-08-2133-109/+215
|\ \ | | | | | | Improve eager load on Rails
| * | add Rack::Lock for webrickAaron Patterson2012-08-211-0/+9
| | |
| * | Deprecate config.threadsafe!José Valim2012-08-214-22/+20
| | |
| * | Get rid of config.preload_frameworks in favor of config.eager_load_namespacesJosé Valim2012-08-2123-52/+80
| | | | | | | | | | | | | | | | | | | | | The new option allows any Ruby namespace to be registered and set up for eager load. We are effectively exposing the structure existing in Rails since v3.0 for all developers in order to make their applications thread-safe and CoW friendly.
| * | Make ActiveSupport::Autoload localJosé Valim2012-08-213-30/+45
| | | | | | | | | | | | | | | | | | | | | Previously, ActiveSupport::Autoload was global and reserved for usage inside Rails. This pull request makes it local, fixes its test (they were not being run because its file was named wrongly) and make it part of Rails public API.
| * | Remove allow_concurrency as a flagJosé Valim2012-08-215-12/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The flag was mainly used to add a Rack::Lock middleware to the stack, but the only scenario the lock is desired is in development. If you are deploying on a not-threaded server, the Rack::Lock does not provide any benefit since you don't have concurrent accesses. On the other hand, if you are on a threaded server, you don't want the lock, since it defeats the purpose of using a threaded server. If there is someone out there, running on a thread server and does want a lock, it can be added to your environment as easy as: `use Rack::Lock`
| * | Allow users to choose when to eager_load the application or not.José Valim2012-08-219-8/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the eager load behavior was mostly coupled to config.cache_classes, however this was suboptimal since in some environments a developer may want to cache classes but not necessarily load them all on boot (for example, test env). This pull request also promotes the use of config.eager_load set to true by default in production. In the majority of the cases, this is the behavior you want since it will copy most of your app into memory on boot (which was also the previous behavior). Finally, this fix a long standing Rails bug where it was impossible to access a model in a rake task when Rails was set as thread safe.
* | | Merge pull request #6499 from lazylester/patch-1Carlos Antonio da Silva2012-08-211-1/+1
|\ \ \ | | | | | | | | | | | | Clarify and correct the description for the --full option of the plugin_new generator. [ci skip]
| * | | Clarify and correct the description for the --full option of the plugin_new ↵lazylester2012-08-211-1/+1
| | | | | | | | | | | | | | | | generator
* | | | Use a model without counter cache to test read-only attributesRafael Mendonça França2012-08-211-9/+10
| |/ / |/| |
* | | Merge pull request #5210 from Pliny/masteriRafael Mendonça França2012-08-218-2/+36
|\ \ \ | | | | | | | | | | | | Fix for #5200
| * | | reset_counters() was crashing when there were multiple belongs_to ↵Dave Desrochers2012-08-218-2/+36
| | | | | | | | | | | | | | | | | | | | | | | | associations with the same foreign key. This closes #5200.
* | | | Add CHANGELOG entry for #7410Rafael Mendonça França2012-08-211-0/+5
|/ / /
* | | Merge pull request #7410 from sandeepravi/default_options_helper_valueRafael Mendonça França2012-08-212-0/+13
|\ \ \ | | | | | | | | | | | | | | | | option_tags coerced to "" instead of nil Closes #7404
| * | | option_tags coerced to "" instead of nilSandeep2012-08-212-0/+13
| | | |
* | | | Merge pull request #7409 from kennyj/refactor_activerecord_resultRafael Mendonça França2012-08-213-18/+4
|\ \ \ \ | |/ / / |/| | | Refactor AR::Result or inherits. Because we have redundant codes about column_types.
| * | | Refactor AR::Result or inherits. Because we have redundant codes aboutkennyj2012-08-223-18/+4
|/ / /
* | | Merge pull request #7408 from yahonda/sqlmode_mysqlCarlos Antonio da Silva2012-08-212-6/+8
|\ \ \ | | | | | | | | | | | | | | | | Change mysql tests for strict mode disabled to work with new sql_mode default in MySQL 5.6.6-m9. Since this MySQL version, the sql_mode default value is `NO_ENGINE_SUBSTITUTION`.
| * | | Rename to test_mysql_strict_mode_disabled_dont_override_global_sql_modeYasuo Honda2012-08-222-6/+8
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Reason since MySQL 5.6.6-m9 the `sql_mode` default value is `NO_ENGINE_SUBSTITUTION`. This default parameter change is out of control from Rails. This test verifies Rails not overriding the default `@@GLOBAL.sql_mode` value by checking if `@@GLOBAL.sql_mode` is the same as `@@SESSION.sql_mode`.
* | | Merge pull request #7406 from janko-m/documentation_fixesRafael Mendonça França2012-08-212-45/+45
|\ \ \ | | | | | | | | Fixed some documentation mistakes
| * | | Fix documentation mistakesJanko Marohnić2012-08-212-45/+45
| | | |
* | | | Merge pull request #7000 from kennyj/fix_6697-3Rafael Mendonça França2012-08-218-11/+31
|\ \ \ \ | | | | | | | | | | Use instance_accessor: false instead of instance_writer.
| * | | | Use instance_accessor: false instead of instance_writer.kennyj2012-08-218-11/+31
|/ / / /
* | | | Add CHANGELOG entry for #6986Rafael Mendonça França2012-08-211-0/+5
| | | |
* | | | Merge pull request #6986 from kennyj/fix_6975Rafael Mendonça França2012-08-212-5/+29
|\ \ \ \ | | | | | | | | | | | | | | | Fix #6975. Round usec when writing timestamp attribute.
| * | | | Round usec when writing timestamp attribute.kennyj2012-08-212-5/+29
|/ / / /
* | | | Minor refactoring in Active Record model schema methodsCarlos Antonio da Silva2012-08-211-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | * Use each_key instead of generating intermediate keys array. * Use each_with_object instead of inject to build hash. * Use ternary to return instead of if + assignment.
* | | | removing dead codeAaron Patterson2012-08-201-19/+7
| | | |
* | | | define singleton methods rather than adding and removing methodsAaron Patterson2012-08-201-45/+32
| | | |
* | | | remove dead codeAaron Patterson2012-08-201-78/+36
| | | |
* | | | initialize instance variables for transactions to remove conditionalsAaron Patterson2012-08-202-8/+7
| | | |
* | | | This method is useless without a block, so remove testAaron Patterson2012-08-201-11/+9
| | | |
* | | | remove unused variableAaron Patterson2012-08-201-1/+1
| | | |
* | | | initialize instance variables to avoid conditionalsAaron Patterson2012-08-201-2/+7
| | | |
* | | | fix whitespace errorsAaron Patterson2012-08-201-2/+2
| | | |
* | | | Revert "removes unused optional argument in AS::Dependencies::Loadable#load"Xavier Noria2012-08-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This argument is there because that's the signature of Kernel#load. This reverts commit bf3fa34ed0aa33bca3aac9c96165662fe864a7b4.
* | | | removes unused optional argument in AS::Dependencies::Loadable#loadXavier Noria2012-08-201-1/+1
| | | |
* | | | Merge pull request #7401 from frodsan/fix_environments_punctuationCarlos Antonio da Silva2012-08-207-12/+12
|\ \ \ \ | | | | | | | | | | Fix punctuation in config templates [ci skip]
| * | | | fix punctuation in config templatesFrancesco Rodriguez2012-08-207-12/+12
|/ / / /
* | | | Make sure :via works with mountPratik Naik2012-08-202-2/+12
| | | |
* | | | Merge pull request #7396 from tomykaira/cleanup_testRafael Mendonça França2012-08-201-11/+11
|\ \ \ \ | |/ / / |/| | | Access @rs only through attr_accessor
| * | | Access @rs only through attr_accessortomykaira2012-08-201-11/+11
|/ / /
* | | removes the second argument of the AS const_missing hookXavier Noria2012-08-191-8/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby does not pass the nesting to const_missing (unfortunately). That second argument was there in case that changed, Yehuda sent a patch to MRI http://bugs.ruby-lang.org/issues/2740 but there is not much movement there and Matz told me in Amsterdam there was no immediate plan to pass the nesting. So let's go back to implement what happens now, and if in the future we get the nesting then we will adapt this. Double-checked this with Mr Katz.
* | | Remove private verify readonly attr methodCarlos Antonio da Silva2012-08-191-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method was added to be shared between update_attribute and update_column in 50725cec397d4fa0ecf1dda4e6ae845a993f1ba7, but since update_attribute was removed, and update_column has changed to delegate to update_columns, the method is not used anywhere anymore. Also remove "key.to_s" conversion when raising readonly error, since the key is being interpolated.
* | | no need for AS::Dependencies.(hook!|unhook!) to return anything in particularXavier Noria2012-08-191-2/+0
| | |