aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Avoid using heredoc for user warningsGodfrey Chan2014-08-2810-61/+51
| | | | | | | | | | Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long.
* No transaction for a test that creates fixtures in the test bodyAkira Matsuda2014-08-291-0/+1
|
* make it easy to copy & paste the config from deprecation warning.Yves Senn2014-08-281-2/+3
| | | | [ci skip]
* User Model#last to certainly get lastly created dataAkira Matsuda2014-08-281-1/+1
| | | | This test would fail when executed after any test that calls fixtures(:binaries)
* Move model definition to test/models for test order indenendencyAkira Matsuda2014-08-283-29/+15
|
* Move association definition to the model fileAkira Matsuda2014-08-282-2/+1
|
* Be sure that test fixtures satisfy referential integrity before calculatingAkira Matsuda2014-08-281-1/+1
| | | | | | | There exists some other test files that load :minivans fixtures but don't load :speedometers. Loading :speedometers here prevents the following error when this test was run after such test: CalculationsTest#test_should_group_by_association_with_non_numeric_foreign_key: ActiveRecord::RecordNotFound: Couldn't find all Speedometers with 'speedometer_id': (ABC, s1) (found 1 results, but was looking for 2)
* Expectations firstAkira Matsuda2014-08-284-9/+9
|
* Reset RACK_ENV after modified in a test caseAkira Matsuda2014-08-281-0/+1
|
* Rails.root should be a PathnameAkira Matsuda2014-08-281-1/+1
|
* No need to sort testsAkira Matsuda2014-08-283-3/+3
| | | | Dir.glob result must be already sorted anyway
* Test everythingAkira Matsuda2014-08-281-1/+1
| | | | This actually was testing test everything, so why not do it simpler?
* AP test files does no more need to be alphabetically sorted hereAkira Matsuda2014-08-281-4/+1
|
* Ignore SCHEMA queries when asserting no queriesAkira Matsuda2014-08-285-22/+22
|
* Reset schema properly after schema changing testAkira Matsuda2014-08-281-0/+2
|
* Merge pull request #16727 from BanzaiMan/travis-yml-fixRafael Mendonça França2014-08-271-0/+1
|\ | | | | Add language directive to .travis.yml
| * Add language directive to .travis.ymlHiro Asari2014-08-271-0/+1
| | | | | | | | | | | | | | Currently, Travis CI assumes that the project is in Ruby in the absence of the `language` key. This behavior may change in the future. (For example, switch to a "blank" image which *may* be created.)
* | remove useless parameterAaron Patterson2014-08-271-2/+2
| |
* | remove dead codeAaron Patterson2014-08-271-12/+2
|/ | | | | | the ERB has already been compiled to Ruby code by the time we're calling module_eval. Nothing that module eval raises will be caught by a blank `rescue`, so I think we can remove this
* Merge pull request #16544 from schneems/schneems/death-to-dir-globGuillermo Iguaran2014-08-276-20/+13
|\ | | | | Refactor out Dir.glob from ActionDispatch::Static
| * Refactor out Dir.glob from ActionDispatch::Staticschneems2014-08-276-20/+13
|/ | | | | | | | Dir.glob can be a security concern. The original use was to provide logic of fallback files. Example a request to `/` should render the file from `/public/index.html`. We can replace the dir glob with the specific logic it represents. The glob {,index,index.html} will look for the current path, then in the directory of the path with index file and then in the directory of the path with index.html. This PR replaces the glob logic by manually checking each potential match. Best case scenario this results in one less file API request, worst case, this has one more file API request. Related to #16464 Update: added a test for when a file of a given name (`public/bar.html` and a directory `public/bar` both exist in the same root directory. Changed logic to accommodate this scenario.
* Merge pull request #16723 from rubys/mention_assert_select_changesZachary Scott2014-08-271-0/+13
|\ | | | | [ci skip] mention assert_select in release notes
| * [ci skip] mention assert_select in release notesSam Ruby2014-08-271-0/+13
|/
* Merge pull request #16717 from splattael/keygeneratorSantiago Pastorino2014-08-271-1/+1
|\ | | | | Use less iterations for KeyGenerator in tests
| * Use less iterations for KeyGenerator in testsPeter Suschlik2014-08-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | This commit improves performance of cookie tests: Ruby | After | Before ----- | --------:| --------: MRI | 5.03s | 9.28s JRuby | 25.45s | 1648.23s Please note the improvement for JRuby.
* | Merge pull request #16707 from katmutua/masterSantiago Pastorino2014-08-271-3/+3
|\ \ | | | | | | update 4_2_release_notes
| * | [ci skip] Update 4_2_release notesJackie Mutua2014-08-271-3/+3
| | |
* | | Merge pull request #16702 from sgrif/sg-binary-serializedRafael Mendonça França2014-08-273-0/+31
|\ \ \ | | | | | | | | Correctly detect mutation on serialized columns mapping to binary
| * | | Correctly detect mutation on serialized columns mapping to binarySean Griffin2014-08-273-0/+31
| | | | | | | | | | | | | | | | Fixes #16701
* | | | Merge pull request #16722 from yui-knk/fix/guides_association_basics2Rafael Mendonça França2014-08-271-4/+4
|\ \ \ \ | | | | | | | | | | [ci skip] Fix typo of `collection_singular_ids=` method.
| * | | | [ci skip] Fix typo of `collection_singular_ids=` method.yui-knk2014-08-271-4/+4
| | | | |
* | | | | Merge pull request #16721 from yui-knk/fix/guides_association_basicsRafael Mendonça França2014-08-271-4/+4
|\ \ \ \ \ | |/ / / / |/| | | | [ci skip] Fix typo of `collection=` method.
| * | | | [ci skip] Fix typo of `collection=` method.yui-knk2014-08-271-4/+4
|/ / / /
* | | | Merge pull request #16719 from tgxworld/fix_spelling_in_changelogArun Agrawal2014-08-271-1/+1
|\ \ \ \ | | | | | | | | | | Fix spelling. [CI SKIP]
| * | | | Fix spelling. [CI SKIP]Guo Xiang Tan2014-08-271-1/+1
|/ / / /
* | | | fix broken `gem` method with non-String arguments. Closes #16709.Yves Senn2014-08-273-4/+23
| | | | | | | | | | | | | | | | This was caused by #15327.
* | | | minor changelog formatting changes.Yves Senn2014-08-273-9/+11
| | | |
* | | | Merge pull request #16661 from edogawaconan/doc-fixYves Senn2014-08-271-1/+1
|\ \ \ \ | | | | | | | | | | Update documentation to match change in #5942 [ci skip]
| * | | | Update documentation to match change in #5942 [ci skip]edogawaconan2014-08-241-1/+1
| | | | |
* | | | | Merge pull request #16715 from y-yagi/update_4_2_release_notesZachary Scott2014-08-271-1/+1
|\ \ \ \ \ | |_|_|_|/ |/| | | | [ci skip] Modify a web-console PR link for release noted
| * | | | [ci skip] Modify a web-console PR linkyuuji.yaginuma2014-08-271-1/+1
|/ / / /
* | | | Merge pull request #16713 from tomkadwill/documented_eqls_other_paramZachary Scott2014-08-271-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Updated documentation syntax of other parameter for rdoc
| * | | | [ci skip] Updated documentation syntax of other parameter for rdocTom Kadwill2014-08-271-1/+1
|/ / / /
* | | | Merge pull request #16708 from zzak/bcjordan-patch-1Zachary Scott2014-08-261-16/+16
|\ \ \ \ | | | | | | | | | | Adjusted punctuation and grammar for Form Helpers guide [ci skip]
| * | | | Adjusted punctuation and grammar for Form Helpers guide [ci skip]Brian Jordan2014-08-261-16/+16
|/ / / /
* | | | Merge pull request #16705 from tomkadwill/documented_many_block_paramZachary Scott2014-08-261-1/+1
|\ \ \ \ | | | | | | | | | | [ci skip] Updated documentation syntax of block parameter for rdoc
| * | | | [ci skip] Updated documentation syntax of block parameter for rdoc Tom Kadwill2014-08-261-1/+1
| | | | |
* | | | | Merge pull request #16706 from tomkadwill/documented_include_record_paramZachary Scott2014-08-261-1/+1
|\ \ \ \ \ | |_|_|_|/ |/| | | | [ci skip] Updated include to reference record parameter for rdoc
| * | | | [ci skip] Updated include to reference record parameter for rdocTom Kadwill2014-08-261-1/+1
|/ / / /
* | | | Merge pull request #16703 from tomkadwill/documented_any_block_paramZachary Scott2014-08-261-1/+1
|\| | | | | | | | | | | [ci skip] Updated documentation syntax of block parameter for rdoc
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 06:45:22 +0000