aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* assign_nested_attributes_for_collection_association should work with Ruby ↵Franck Verrot2011-07-202-1/+6
| | | | | | 1.9 [Closes #2106] Children attributes can be either String's or Symbol's, so let's check if the object responds to to_i.
* Revert "this fixes a brittle test in fixtures_test.rb which fails when you ↵Aaron Patterson2011-07-201-2/+2
| | | | | | are in a timezone which is ahead of UTC but UTC is in the previous day still." This reverts commit f92cefa95f44bcd550c402a7f5ba914f3bd783cc.
* bigdecimal should be typecast to a float on sqlite3. fixes #2162Aaron Patterson2011-07-203-1/+17
|
* Merge pull request #2159 from ogeidix/masterSantiago Pastorino2011-07-202-1/+8
|\ | | | | Fixed issue #2119: XHR without Accept and Content-Type header gets 500 error
| * Check Accept and Content-Type headers before evaluating them in xhr ↵ogeidix2011-07-192-1/+8
| | | | | | | | | | | | requests. Closes #2119 An xhr request must have an "Accept" or "Content-type" header in order to be considered a request with valid_accept_header.
* | Merge pull request #2165 from joshk/fixtures_test_fixXavier Noria2011-07-201-2/+2
|\ \ | | | | | | Timezone fixtures test correction
| * | this fixes a brittle test in fixtures_test.rb which fails when you are in a ↵Josh Kalderimis2011-07-201-2/+2
| | | | | | | | | | | | timezone which is ahead of UTC but UTC is in the previous day still.
* | | Merge pull request #2136 from judearasu/guides_branchXavier Noria2011-07-202-4/+6
|\ \ \ | |/ / |/| | notextile tag in rails guides generator has been placed with ascii quotes
| * | notextile tag has been placed with ascii quotesJudeArasu2011-07-192-4/+6
| | |
* | | documents the changes to String#blank? in the AS guideXavier Noria2011-07-201-1/+3
| | |
* | | registers the changes to String#blank? in the CHANGELOGXavier Noria2011-07-201-0/+3
| | |
* | | Merge pull request #2164 from dmathieu/missing_requireXavier Noria2011-07-201-0/+1
|\ \ \ | | | | | | | | missing require of string/encoding to have access to encoding_aware?
| * | | missing require of string/encoding to have access to encoding_aware?Damien Mathieu2011-07-201-0/+1
|/ / /
* | | Merge pull request #2146 from dmathieu/blank_binary_encodingXavier Noria2011-07-201-1/+6
|\ \ \ | | | | | | | | fix String#blank? on binary strings
| * | | fix String#blank? on binary strings.Damien Mathieu2011-07-201-1/+6
| | | |
* | | | Merge pull request #2160 from joshk/patch-5Jeremy Kemper2011-07-191-1/+1
|\ \ \ \ | |_|_|/ |/| | | Changed the year of a date used in a test which fails when using 1.8.7
| * | | Changed the year of a date used in a test which fails when using 1.8.7 on a ↵Josh Kalderimis2011-07-191-1/+1
|/ / / | | | | | | | | | 32bit machine (ArgumentError: time out of range)
* | | Merge pull request #2155 from vijaydev/changelogsSantiago Pastorino2011-07-191-0/+2
|\ \ \ | | | | | | | | Adding changelog entry for submit helper change which removed object_name_id generation
| * | | add entry for submit helper change removing object_name_idVijay Dev2011-07-201-0/+2
| | | |
* | | | Merge pull request #2154 from vijaydev/better_mapSantiago Pastorino2011-07-191-1/+1
|\ \ \ \ | |/ / / |/| | | Avoid Symbol#to_proc
| * | | avoid Symbol#to_procVijay Dev2011-07-201-1/+1
|/ / /
* | | Merge pull request #2148 from norman/masterSantiago Pastorino2011-07-191-0/+2
|\ \ \ | |/ / |/| | Explicitly require Active Support dependencies (master)
| * | Explicitly require Active Support dependenciesNorman Clarke2011-07-191-0/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | This fixes errors when using Active Record outside of Rails. In Rails, these files are required by other classes that are always loaded, so this error does not happen. Without core_ext/module/delegation, a NoMethodError is raised because `delegate` remains undefined. Without core_ext/class/attribute_acessors, an ArgumentError is raised because `delegate` does not receive a value for its :to option.
* | Merge pull request #2139 from mcmire/issue_2078_masterSantiago Pastorino2011-07-182-1/+13
|\ \ | | | | | | Fix for #2078 (against master)
| * | ActiveRecord: Fix eager loading so that giving a blank order clause ↵Elliot Winkler2011-07-182-1/+13
| |/ | | | | | | generates valid SQL
* | Merge pull request #2141 from joshk/masterXavier Noria2011-07-184-9/+159
|\ \ | |/ |/| Config files to get Rails on Travis-CI
| * This fixes an issue when bundling to a local path (eg. /vendor/bundle).Josh Kalderimis2011-07-171-6/+2
| | | | | | | | | | If you bundle to a local path bundler is not included in it, so calling "gem 'bundler'" will fail.
| * Added a .travis.yml config and travis specific ci script.Josh Kalderimis2011-07-153-3/+157
| | | | | | | | | | | | | | | | Don't install ruby-debug if running the test suite on Travis, linecache19 is the main offender, very very slow. And do not install pg if Travis is bundling the gems, pg will be setup on Travis soon.
* | Merge pull request #2133 from jstorimer/ensure-status-codes-are-logged-properlyJosé Valim2011-07-182-4/+23
|\ \ | | | | | | Ensure that status codes are logged properly
| * | Ensure that status codes are logged properlyJesse Storimer2011-07-182-4/+23
| | | | | | | | | | | | | | | | | | Needed to move AC::Metal::Instrumentation before AM::Metal::Rescue so that status codes rendered from rescue_from blocks are logged properly.
* | | Merge pull request #2116 from guilleiguaran/fix-environment-generator-actionSantiago Pastorino2011-07-182-2/+10
|\ \ \ | |/ / |/| | Fix Rails::Generators::Actions#environment when env is passed
| * | Fix Rails::Generators::Actions#environment when env is passed. Closes #2110Guillermo Iguaran2011-07-182-2/+10
| | |
* | | Merge pull request #195 from bigfix/active_model_include_serializationJosé Valim2011-07-188-241/+343
|\ \ \ | | | | | | | | ActiveModel support for the :include serialization option
| * | | ActiveModel support for the :include serialization optionJohn Firebaugh2011-07-176-90/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves support for the :include serialization option for serializing associated objects out of ActiveRecord in into ActiveModel. The following methods support the :include option: * serializable_hash * to_json * to_xml Instances must respond to methods named by the values of the :includes array (or keys of the :includes hash). If an association method returns an object that is_a?(Enumerable) (which AR has_many associations do), it is assumed to be a collection association, and its elements must respond to :serializable_hash. Otherwise it must respond to :serializable_hash itself. While here, fix #858, XmlSerializer should not singularize already singular association names.
| * | | Move to_xml tests to xml_serialization_test.rbJohn Firebaugh2011-07-172-143/+133
| | | | | | | | | | | | | | | | | | | | One duplicate was eliminated: test_to_xml_including_methods/ test_methods_are_called_on_object.
| * | | We already have the record; no need to retrieve it againJohn Firebaugh2011-07-171-2/+2
| | | |
| * | | Replace map+compact with selectJohn Firebaugh2011-07-171-1/+1
| | | |
| * | | Add a testJohn Firebaugh2011-07-171-0/+5
| | | |
| * | | serializable_hash(:only => [], :methods => [:foo]) should workJohn Firebaugh2011-07-172-7/+14
| | | |
* | | | Merge pull request #2075 from lawrencepit/match_attribute_methodJosé Valim2011-07-181-6/+27
|\ \ \ \ | | | | | | | | | | Optimization of ActiveModel's match_attribute_method?
| * | | | Made attribute_method_matchers_cache private + docLawrence Pit2011-07-171-3/+13
| | | | |
| * | | | Issue #2075 Optimization of ActiveModel's match_attribute_method?Lawrence Pit2011-07-161-9/+17
| | | | |
| * | | | Optimization of ActiveModel's match_attribute_method?Lawrence Pit2011-07-151-2/+5
| | |_|/ | |/| |
* | | | Merge pull request #2128 from sikachu/master-dynamic_finderJon Leighton2011-07-184-16/+49
|\ \ \ \ | | | | | | | | | | Raise an ArgumentError if user passing less number of argument in the dynamic finder
| * | | | Refactor test case to use anonymous class - Thank you @tenderlovePrem Sichanugrist2011-07-181-13/+8
| | | | |
| * | | | Refactor the code a bit to reduce the duplicationPrem Sichanugrist2011-07-171-17/+8
| | | | |
| * | | | Raise an ArgumentError if user passing less number of argument in the ↵Prem Sichanugrist2011-07-174-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dynamic finder The previous behavior was unintentional, and some people was relying on it. Now the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.) So if you were doing this and expecting the second argument to be nil: User.find_by_username_and_group("sikachu") You'll now get `ArgumentError: wrong number of arguments (1 for 2).` You'll then have to do this: User.find_by_username_and_group("sikachu", nil)
* | | | | make tzinfo a development dependencyAaron Patterson2011-07-181-1/+2
| | | | |
* | | | | Merge pull request #2124 from arunagw/render_partial_invalid_check_fixSantiago Pastorino2011-07-171-2/+1
|\ \ \ \ \ | | | | | | | | | | | | Checking with to_s. As regexp fail with 1.8.7
| * | | | | Checking with to_s. As regexp fail with 1.8.7Arun Agrawal2011-07-181-2/+1
| |/ / / /