Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | always default the SCRIPT_NAME to whatever is on the controller | Aaron Patterson | 2015-07-10 | 1 | -1/+1 |
| | |||||
* | remove useless ivar clearing | Aaron Patterson | 2015-07-10 | 1 | -6/+0 |
| | | | | Since we only work with new instances, these ivars will not be set. | ||||
* | call the `path_parameters=` setter rather than rely on mutations | Aaron Patterson | 2015-07-10 | 1 | -1/+3 |
| | | | | | We should call the setter on `path_parameters` so that we know the hash will only contain the values that we've set. | ||||
* | start collecting `env` mutations | Aaron Patterson | 2015-07-10 | 1 | -5/+3 |
| | | | | | I'd like to put all env mutations together so we can understand how to change this code to call `call` on the controller | ||||
* | Parameters are converted to a query string | Aaron Patterson | 2015-07-10 | 1 | -17/+0 |
| | | | | | Since parameters are converted to a query string, they will automatically be turned in to strings by the query parser | ||||
* | no more HWIA | Aaron Patterson | 2015-07-10 | 1 | -1/+1 |
| | | | | | non_path_parameters is used internally (it never escapes this method) so we should be able to safely use a regular hash. | ||||
* | remove param dup'ing logic | Aaron Patterson | 2015-07-10 | 1 | -8/+0 |
| | | | | | since we are serializing parameters, we don't need to do all the dup checks on each object. | ||||
* | encode / decode parameters before assigning them to the request | Aaron Patterson | 2015-07-10 | 1 | -5/+58 |
| | | | | | | We should roundtrip the parameters through their respective encoders / decoders so that the controller will get parameters similar to what they actually get in a real world situation | ||||
* | Merge pull request #20836 from sikachu/fix-time-zone-test | Rafael Mendonça França | 2015-07-10 | 1 | -0/+1 |
|\ | | | | | Require yaml for time_with_zone isolation test | ||||
| * | Require yaml for time_with_zone isolation test | Prem Sichanugrist | 2015-07-10 | 1 | -0/+1 |
|/ | | | | | Same fix as 109e71d2bb6d2305a091fe7ea96d4f6e9c7cd52d but after mocha got removed in 2f28e5b6417fd4e5d6060983b36262737558b613. | ||||
* | start disconnecting the parameter parser from the instance | Aaron Patterson | 2015-07-10 | 1 | -3/+3 |
| | | | | | pass in the instance variable to start decoupling the meat of the parser from the instance of the middleware | ||||
* | drop a conditional by always assigning | Aaron Patterson | 2015-07-10 | 1 | -6/+5 |
| | | | | | We will always make an assignment to the env hash and eliminate a conditional | ||||
* | Reuse the same test for HWIA reverse_merge! | Rafael Mendonça França | 2015-07-10 | 1 | -3/+1 |
| | |||||
* | Merge pull request #20828 from Sirupsen/hash-indifferent-dup-default-proc | Rafael Mendonça França | 2015-07-10 | 4 | -13/+58 |
|\ | | | | | active_support/indifferent_access: fix not raising when default_proc does | ||||
| * | test/hash: move lonely indifferent hash test | Simon Eskildsen | 2015-07-10 | 2 | -11/+6 |
| | | |||||
| * | active_support/indifferent_hash: dont raise on to_hash when default_proc raises | Simon Eskildsen | 2015-07-10 | 3 | -1/+22 |
| | | |||||
| * | active_support/indifferent_hash: fix cloning default_proc on dup | Simon Eskildsen | 2015-07-10 | 3 | -1/+30 |
| | | |||||
* | | drop runtime conditionals in parameter parsing | Aaron Patterson | 2015-07-09 | 1 | -13/+9 |
| | | | | | | | | | | If we only deal with proc objects, then we can eliminate type checking in the parameter parsing middleware | ||||
* | | Merge pull request #20457 from ronakjangir47/remove_mocha_activesupport | Kasper Timm Hansen | 2015-07-09 | 8 | -65/+87 |
|\ \ | | | | | | | Removed use of mocha in Active Support | ||||
| * | | Removed use of mocha in active_support | Ronak Jangir | 2015-07-10 | 8 | -65/+87 |
| | | | |||||
* | | | Merge pull request #20813 from noniq/locale-argument-for-pluralize-helper | Kasper Timm Hansen | 2015-07-09 | 2 | -2/+22 |
|\ \ \ | | | | | | | | | Allow `pluralize` helper to take a locale. | ||||
| * | | | Allow `pluralize` helper to take a locale. | Stefan Daschek | 2015-07-09 | 2 | -2/+22 |
| | | | | | | | | | | | | | | | | This is already supported in `ActiveSupport::Inflector#pluralize` and `String#pluralize`, so we just forward the locale. | ||||
* | | | | use `Rack::Test::UploadedFile` when uploading files | Aaron Patterson | 2015-07-09 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | We should use rack-test's upload file objects on the test side so that we will be able to correctly generate mime blob posts in the future | ||||
* | | | | set parameters as a query string | Aaron Patterson | 2015-07-09 | 2 | -7/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | We should convert request parameters to a query string, then let the request object parse that query string. This should give us results that are more similar to the real-world | ||||
* | | | | use JSON to communicate between the controller and the tests | Aaron Patterson | 2015-07-09 | 1 | -12/+12 |
| | | | | |||||
* | | | | Merge pull request #20765 from maurogeorge/activejob-exception | Robin Dupret | 2015-07-09 | 1 | -0/+7 |
|\ \ \ \ | |_|/ / |/| | | | Add Deserialization section on guides at ActiveJob Exception [ci skip] | ||||
| * | | | Add Deserialization section on guides at ActiveJob Exception | Mauro George | 2015-07-08 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | build and assign parameters rather than rely on mutations | Aaron Patterson | 2015-07-08 | 2 | -4/+18 |
| | | | | | | | | | | | | | | | | | | | | We should assign parameters to the request object rather than mutate the hash that is returned by `query_parameters` or `request_parameters` | ||||
* | | | | use new constructor. (Oops! :bomb:) | Aaron Patterson | 2015-07-08 | 2 | -2/+2 |
| | | | | |||||
* | | | | assign the cookie hash on request allocation | Aaron Patterson | 2015-07-08 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | | this prevents mutations from being available globally | ||||
* | | | | request objects are no longer recycled | Aaron Patterson | 2015-07-08 | 2 | -16/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | Instead of trying to manually clear out a request object, lets just allocate a new one. The rack ENV is reused and cleaned (still), but the request object is not. | ||||
* | | | | pass the variant as a parameter to more reflect real world apps | Aaron Patterson | 2015-07-08 | 1 | -3/+3 |
| | | | | |||||
* | | | | add a new constructor for allocating test requests | Aaron Patterson | 2015-07-08 | 4 | -29/+31 |
| | | | | |||||
* | | | | make `env` a required parameter | Aaron Patterson | 2015-07-08 | 2 | -7/+7 |
| | | | | |||||
* | | | | pass the starting env and session to build_request | Aaron Patterson | 2015-07-08 | 2 | -4/+4 |
| | | | | |||||
* | | | | remove call to build_request | Aaron Patterson | 2015-07-08 | 1 | -1/+0 |
| | | | | |||||
* | | | | pass the session and env in to the test request | Aaron Patterson | 2015-07-08 | 1 | -4/+8 |
| | | | | |||||
* | | | | let the superclass build the request and response | Aaron Patterson | 2015-07-08 | 11 | -48/+14 |
| | | | | | | | | | | | | | | | | | | | | We should leverage the request / response objects that the superclass has already allocated for us. | ||||
* | | | | Merge pull request #20781 from dubek/collection-cache-explicit | Kasper Timm Hansen | 2015-07-08 | 5 | -9/+47 |
|\ \ \ \ | | | | | | | | | | | Support explicit defintion of resource name for collection caching. | ||||
| * | | | | Support explicit defintion of resouce name for collection caching. | Dov Murik | 2015-07-07 | 5 | -9/+47 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a template includes `# Template Collection: ...` anywhere in its source, that name will be used as the cache name for the partial that is rendered for the collection. This allows users to enable collection caching even if the template doesn't start with `<% cache ... do %>`. Moreover, the `# Template Collection: ...` notation is recognized in all template types (and template types other than ERB can define a resource_cache_call_pattern method to allow the `cache ... do` pattern to be recognized too). | ||||
* | | | | | Merge pull request #20784 from kaspth/great-expectations | Kasper Timm Hansen | 2015-07-08 | 2 | -0/+121 |
|\ \ \ \ \ | | | | | | | | | | | | | Add method call assertions for internal use. | ||||
| * | | | | | Add method call assertions for internal use. | Kasper Timm Hansen | 2015-07-08 | 2 | -0/+121 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `assert_called` and `assert_not_called` to boil down the boilerplate we need to write to assert methods are called certain number of times. | ||||
* | | | | | | remove useless `new` implementation | Aaron Patterson | 2015-07-08 | 1 | -4/+0 |
| | | | | | | |||||
* | | | | | | allocate new responses rather than recycling them | Aaron Patterson | 2015-07-08 | 1 | -12/+5 |
| |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | There is no reason to "recycle" response objects when we can just allocate a new one. | ||||
* | | | | | Merge pull request #20805 from yui-knk/fix/how_to_run_test | Yves Senn | 2015-07-08 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | [ci skip] Add `bundle exec` to Running a Single Test | ||||
| * | | | | | [ci skip] Add `bundle exec` to Running a Single Test | yui-knk | 2015-07-08 | 1 | -1/+1 |
|/ / / / / | |||||
* | | | | | Merge pull request #20803 from TheBlasfem/marking_serialization_class | Rafael Mendonça França | 2015-07-08 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | marking serialization class in Readme | ||||
| * | | | | | marking serialization class | Julio Lopez | 2015-07-07 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge pull request #20804 from TheBlasfem/adding_brackets_to_array_in_docs | Rafael Mendonça França | 2015-07-08 | 1 | -1/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Adding brackets to array in docs | ||||
| * | | | | | | adding brackets to array in docs | Julio Lopez | 2015-07-07 | 1 | -1/+1 |
|/ / / / / / |