| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Follow up to #25240.
|
|\
| |
| | |
Fix a typo in `time_field` [ci skip]
|
| | |
|
|\ \
| |/
|/| |
Added some useful configuration options into configuring.md [ci skip]
|
| |
| |
| |
| |
| | |
Added information about inserting middlewares with indexes. I think this information useful. We can use indexes also for `insert_after` but the behavior is not same and this is not the right place to give full information about all configuration options.
The configuration for I18n fallbacks is important for production environment. Especially using different fallbacks for different locales.
|
|\ \
| | |
| | | |
Trim Action Cable README [ci skip]
|
| | |
| | |
| | |
| | |
| | | |
- Only Action Cable README did not have this section, all of the other
READMEs have this section.
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Remove "Configuration", "Running the server", "Dependencies" and "Deployment"
sections from the Action Cable README as they are already duplicated in the
Action Cable overview guide.
|
|\ \ \
| | | |
| | | | |
[ci skip] Fix link rubyonrails.org/core => http://rubyonrails.org/community
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
[ci skip] Remove Pratik Naik from Rails core team info.
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Fix sqlite3 test failure
|
|/ / /
| | |
| | |
| | | |
Sqlite3 test failure is due to 66ebbc4952f6cfb37d719f63036441ef98149418.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We were declaring in a few tests, which depending of
the order load will cause an error, as the super class could change.
see https://github.com/rails/rails/commit/ac1c4e141b20c1067af2c2703db6e1b463b985da#commitcomment-17731383
|
|\ \ \
| | | |
| | | | |
[skip ci] Fix grammar
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Conflicts:
guides/source/action_cable_overview.md
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Not sure why #25239, but it had good changes, so I'm manually pulling in
the changes.
[Jon Moss, Rajat Bansal]
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#english
|
| | | |
| | | |
| | | |
| | | | |
- Grammar edits.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- config/application.rb no longer has comments about how to specify load paths
or change default locale after
https://github.com/rails/rails/commit/28dcadc0140dfdeb.
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
For consistency.
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
the same.
https://github.com/rails/rails/commit/23b6a9c0fcb8992e18450d6fe0680bf09685b7db
[ci skip]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`ActiveRecord::QueryCache` middlewares were removed with `Executor` addition on d3c9d808e3e242155a44fd2a89ef272cfade8fe8
Removes traces and reference of these from all places.
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
changed quite a bit after Executor middleware addition.
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Add i18n_validation_test
|
| | | | |
| | | | |
| | | | |
| | | | | |
add active record uniqueness validation test for { on: [:create, :update] } condition.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[skip ci] Make header bullets consistent in engines.md
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix debug helper test
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Properly support reloading for Action Cable channels
|
| | |/ / / /
| |/| | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We are currently using `%e` which adds a space before the result if the
digit is a single number. This leads to strings like `February 2, 2016`
which is undesireable. I've opted to replace with 0 padding instead of
removing the padding entirely, to preserve compatibility for those
relying on the fact that the width is constant, and to be consistent
with time formatting.
Fixes #25251.
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
As part of refactoring mutation detection to be more performant, we
introduced the concept of `original_value` to `Attribute`. This was not
overridden in `Attribute::Uninitialized` however, so assigning ot an
uninitialized value and calling `.changed?` would raise
`NotImplementedError`.
We are using a sentinel value rather than checking the result of
`original_attribute.initialized?` in `changed?` because `original_value`
might go through more than one node in the tree.
Fixes #25228
|
|\ \ \ \ \
| | | | | |
| | | | | | |
add missing "as" to Engines doc page [ci skip]
|
|/ / / / /
| | | | |
| | | | | |
it reads a bit awkwardly without it.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently CI is broken due to 56a61e0 and c4cb686. This occurred because
the failures are not present on SQLite which is what I normally run
locally before pushing.
The optimizations to our YAML size were dropping mutations, as
`with_type` didn't set the previous value if it'd already been read
(that method was never really designed to be used with values on
individual objects, it was previously only used for defaults). I'm
questioning whether there's a better place to be handling the exclusion
of the type, but this will fix the failing build.
Additionally, there was a bug in `remove_foreign_key` if you passed it
an options hash containing `to_table`. This now occurs whenever removing
a reference, as we always normalize to a hash.
[Sean Griffin & Ryuta Kamizono]
|
|\ \ \ \
| | | | |
| | | | | |
fix typo [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Collapse all new default initializers into a single file
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Adjusted tests also for this new behavior.
- Based on the discussion in
https://github.com/rails/rails/pull/25184#issuecomment-222454583.
|