| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In Ruby ^ and $ mean start and end of *line*.
A regexp that validates an email should not check if
some line of the string looks like an email, and maybe
be surrounded by the entire Joyce's Ulysses. What the
regexp has to check is if the string itself looks like
an email.
This validator is used only in tests, the ^/$ anchors
implied no risk.
|
| | | | | | |
|
| |_|/ / /
|/| | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add proper description for `Rails.cache.fetch` [ci skip]
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It all started noticing some foo.method({ ... }) method calls
in passing. This is a whole pass modernizing this file.
While some string literals are edited where I touched code,
this pass does not uniformizes quotes. A ton are left untouched
on purposes. We have no defined style.
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | | |
Where appropriatei, prefer the more concise Regexp#match?,
String#include?, String#start_with?, or String#end_with?
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Explain meaning of the code very well and Remove confusion. [ci skip]
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Code like `render(topics) => render("topics/topic")` adds confusion
for the readers. On first impression, that code feels like hash kind
of data, but it's not. So make it more clear and meaningful.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Adds `not_in?` onto Object
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The exclamation mark is not a metacharacter.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Where appropriate prefer the more concise Regexp#match?, String#include?,
String#start_with?, and String#end_with?
|
| | | | | | |
|
| | | | | | |
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Some casual benchmarks showed a 2x factor.
All credit goes to @nurse.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
See the rationale in the documentation included in this patch.
We are going to gradually introduce this predicate in the code base.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
AEAD modes like `aes-256-gcm` provide both confidentiality and data authenticity, eliminating the need to use MessageVerifier to check if the encrypted data has been tampered with.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix incorrect indentation in method comment
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
For consistency mainly.
Also, some have a name that could make the reader think they
enforce the opposite of what they do, because the default is
not visible there.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Enforce minimal web-console version for Rails 5
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I dropped the version constraint in web-console with the idea it will be
easier to upgrade the console between Rails releases. However, issues
like #25899 started popping up.
I'm reintroducing the constraint, but this time, I don't set an upper
limit to the major version. This will keep the web-console in a version
that always works for the current Rails version and can be easily
upgraded to the last one with `bundle update`.
We may need to backport this for Rails 5.0.1.
Fixes #25899.
|
|\ \ \ \
| | | | |
| | | | | |
Bring back support for callable cache key when rendering collection
|
|/ / / / |
|
|\ \ \ \
| |_|/ /
|/| | | |
Remove tab chars before commands to be run
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Fix explain logging with binds
|
| |/ /
| | |
| | |
| | | |
`binds` is an array of a query attribute since Active Record 5.0.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/add_exists_and_update_all_to_collection_proxy
Add `exists?` and `update_all` to `CollectionProxy` for respects an association scope
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
association scope
Fixes #25732.
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
yahonda/remove_set_date_columns_and_modify_attributes_test
Remove Oracle specific tests based on deprecated behaviors
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Refer https://github.com/rsim/oracle-enhanced/pull/845
Remove `set_date_columns` which has been deprecated in Oracle enhanced adapter
- Refer https://github.com/rsim/oracle-enhanced/pull/869
|
|\ \ \
| | | |
| | | |
| | | | |
Setup default session store internally, no longer through an initializer
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
initializer
- By default the session store will be set to cookie store with
application name as session key.
- Older apps are not affected as they will have the session store
initializer generated by Rails in older versions, and Rails will not
overwrite the session store if it is already set or disabled.
- But new apps will not have the initializer, instead the session store
will be set to cookie store by default.
- Based on comment by DHH here - https://github.com/rails/rails/issues/25181#issuecomment-222312764.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
set to activerecord session store
- Use keyword args as it is possible to use them now.
- The error message for activerecord-session_store gem was added in 1807384.
- But it was added for a code path which gets called when we try to
**access** the session store, not when we **set** it.
- So the test expecting the exception started failing because now the
session store is set via railtie again **after** setting it first with
:active_record_store in the test.
- As the error is not raised while setting the store to
:active_record_store, the store gets overwritten by railtie and when
we access it via `session_store` while building the default middleware
stack, the exception is not raised.
- This commit moves the code for raising the exception to the path where
we try to set the store.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
by Rails
- We need to ability to check whether the session store it is set or
not so that we can set it ourselves in an internal initializer.
- We can't rely on return value of `config.session_store` as it can
return `nil` when set to `disabled` and we will accidentally override it
and set to default cookie store.
- So introduced new method which just tells us whether it is set or not.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/move_warning_about_composite_primary_key_to_attribute_methods_primary_key
Move the warning about composite primary key to `AttributeMethods::PrimaryKey`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Actually schema dumper/creation supports composite primary key (#21614).
Therefore it should not show the warning about composite primary key in
connection adapter.
This change moves the warning to `AttributeMethods::PrimaryKey` and
suppress the warning for habtm join table.
Fixes #25388.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix ActionView::Helpers#current_page? with trailing space issue.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://github.com/rails/rails/issues/19472
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Do not `binds.dup` in `connection#to_sql`
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | | |
Because `connection#to_sql` does not mutate `binds`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use `connection#to_sql` for construct an SQL
|
| |/ / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add missing tests for memory store of cache.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fix the calling `merge` method at first in a scope
|