aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #27855 from kevinzwhuang/finder-methods-typo-fixEileen M. Uchitelle2017-01-311-2/+2
|\ | | | | Fix typo about sort in finder_methods.rb
| * Fix grammar typo about sort in finder_methods.rbKevin Huang2017-01-301-2/+2
| |
* | Merge pull request #27857 from kenta-s/add-test-for-variable_size_secure_compareEileen M. Uchitelle2017-01-311-1/+6
|\ \ | | | | | | Add test for `variable_size_secure_compare`
| * | Add test for `variable_size_secure_compare`kenta-s2017-01-311-1/+6
| | |
* | | Merge pull request #27856 from kenta-s/remove-redundant-right-parenthesesप्रथमेश Sonpatki2017-01-311-1/+1
|\ \ \ | |/ / |/| | Remove redundant right parentheses in number_helper [ci skip]
| * | Remove redundant right parentheses in number_helper [ci skip]kenta-s2017-01-311-1/+1
|/ /
* | Merge pull request #27838 from kamipo/reload_destroyed_through_recordRafael França2017-01-312-0/+11
|\ \ | |/ |/| Reload `through_record` that has been destroyed in `create_through_record`
| * Reload `through_record` that has been destroyed in `create_through_record`Ryuta Kamizono2017-01-292-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an alternative of #27714. If `has_one :through` association has set `nil`, `through_record` is destroyed but still remain loaded target in `through_proxy` until `reload` or `reset` explicitly. If `through_proxy` is not reset (remain destroyed (frozen) target), setting new record causes `RuntimeError: Can't modify frozen hash`. To prevent `RuntimeError`, should reload `through_record` that has been destroyed in `create_through_record`.
* | Raise in the initialize not in the executeRafael Mendonça França2017-01-313-13/+12
| |
* | Merge pull request #27824 from kenta-s/raise-an-error-if-no-block-givenRafael França2017-01-313-2/+17
|\ \ | | | | | | Raise an error if FileUpdateChecker#execute is called with no block
| * | Raise an error if FileUpdateChecker#execute is called with no blockkenta-s2017-01-283-2/+17
| | |
* | | Don't mutate raw_source in mailer preview interceptorEugene Kenny2017-01-302-5/+35
| | | | | | | | | | | | | | | | | | | | | | | | The raw_source method is documented as returning the exact value that was used to create the body; mutating it breaks that contract. Additionally, if the value used to create the body is blank, raw_source returns a frozen string which causes the interceptor to raise an error.
* | | Merge pull request #27849 from joevandyk/patch-2Rafael França2017-01-311-1/+2
| | | | | | | | | Specify complete path to AR::LegacyYamlAdapter
* | | Merge pull request #27853 from ↵Rafael França2017-01-311-1/+1
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/add_default_value_to_deliver_later_queue_name_option add default value to `deliver_later_queue_name` option [ci skip]
| * | | add default value to `deliver_later_queue_name` option [ci skip]yuuji.yaginuma2017-01-311-1/+1
| | | |
* | | | Merge pull request #27738 from kenta-s/remove-unused-argument-formatsRafael França2017-01-312-27/+27
|\ \ \ \ | | | | | | | | | | Remove unused argument `formats`
| * | | | Remove unused argument `formats`kenta-s2017-01-202-27/+27
| | | | |
* | | | | Merge pull request #27842 from richseviora/masterRafael França2017-01-312-0/+39
|\ \ \ \ \ | | | | | | | | | | | | Added warning for reserved YAML keywords.
| * | | | | Added warning for reserved YAML keywords.Rich Seviora2017-01-302-0/+39
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | Update i18n.md Addressed Feedback
* | | | | Merge pull request #27647 from Shopify/fully-eagerload-journeyRafael França2017-01-306-1/+45
|\ \ \ \ \ | | | | | | | | | | | | Fully initialize routes before the first request is handled
| * | | | | Fully initialize routes before the first request is handledJean Boussier2017-01-186-1/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `AD::Journey::GTG::Simulator` is lazily built the first time `Journey::Router#find_routes` is invoked, which happens when the first request is served. On large applications with many routes, building the simulator can take several hundred milliseconds (~700ms for us). Triggering this initialization during the boot process reduces the impact of deploys on the application response time.
* | | | | | Merge pull request #27797 from y-yagi/correctly_check_error_messageArthur Nogueira Neves2017-01-306-12/+27
|\ \ \ \ \ \ | | | | | | | | | | | | | | correctly check error message
| * | | | | | correctly check error messageyuuji.yaginuma2017-01-256-12/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_raise` does not check error message. However, in some tests, it seems like expecting error message checking with `assert_raise`. Instead of specifying an error message in `assert_raise`, modify to use another assert to check the error message.
* | | | | | | Avoid lambda scopes when possibleAaron Patterson2017-01-301-3/+1
| |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lambda scopes require a bunch more work. Ideally the `scope` list would be a homogeneous collection. In this case, the reflection knows how to construct the right reflection for this join, so lets just construct that relation rather than instance execing to figure it out later.
* | | | | | Merge pull request #27851 from tenderlove/scope-chainAaron Patterson2017-01-304-57/+47
|\ \ \ \ \ \ | | | | | | | | | | | | | | Deprecate `scope_chain`
| * | | | | | deprecate `scope_chain`Aaron Patterson2017-01-302-5/+17
| | | | | | |
| * | | | | | update comments and call `super`Aaron Patterson2017-01-301-24/+3
| | | | | | |
| * | | | | | remove caching until we prove it is requiredAaron Patterson2017-01-301-7/+3
| | | | | | |
| * | | | | | Fix `scopes` implementation on `PolymorphicReflection`Aaron Patterson2017-01-303-54/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `PolymorphicReflection` needs to be custom for handling scope lambdas
| * | | | | | Implement `scopes` method on each Reflectioneileencodes2017-01-301-5/+47
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Each reflection should be responsible for returning the scopes needed to query against the db.
* | | | | | Merge pull request #27822 from mtsmfm/bump-unicode-versionJeremy Daer2017-01-305-10/+38
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update Unicode Version to 9.0.0
| * | | | | | Update Unicode Version to 9.0.0Fumiaki MATSUSHIMA2017-01-285-10/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9.0.0 was released on June 21, 2016 http://blog.unicode.org/2016/06/announcing-unicode-standard-version-90.html http://www.unicode.org/versions/Unicode9.0.0/ There are some changes about grapheme cluster in Unicode 9.0.0: http://unicode.org/reports/tr29/#Grapheme_Cluster_Boundary_Rules ------------ I noticed that `unpack_graphemes` returns [Other] when the argument is Other ÷ Prepend (it must be [Other, Prepend]). But in [Unicode 8.0.0's Prepend has no characters](http://www.unicode.org/reports/tr29/tr29-27.html#Prepend) so we don't have to backport following patch: ```diff should_break = + if pos == eoc + true ```
* | | | | | | Document with with an example an link to ParameterizedRafael Mendonça França2017-01-301-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also change the class_methods to ClassMethods since the former document the method as an instance method of Parameterized not as a class method.
* | | | | | | :scissors:Rafael Mendonça França2017-01-301-1/+1
| | | | | | |
* | | | | | | No need to advertise in the rdoc documentationRafael Mendonça França2017-01-301-3/+0
| | | | | | |
* | | | | | | Avoid should in test namesRafael Mendonça França2017-01-301-1/+1
| | | | | | |
* | | | | | | Implement respond_to_missing? in the Parameterized::Mailer classRafael Mendonça França2017-01-302-6/+25
| | | | | | |
* | | | | | | Remove unneeded nodocRafael Mendonça França2017-01-301-1/+1
| | | | | | |
* | | | | | | Override the initializers instead of using tapRafael Mendonça França2017-01-301-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We own the class so we can override the initialize.
* | | | | | | Make internal classes internal for the documentationRafael Mendonça França2017-01-301-2/+2
| | | | | | |
* | | | | | | Merge pull request #27784 from y-yagi/add_warnings_option_to_test_runnerRafael França2017-01-304-0/+31
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | add warnings option to test runner
| * | | | | | | add warnings option to test runneryuuji.yaginuma2017-01-244-0/+31
| | | | | | | |
* | | | | | | | Merge pull request #27787 from y-yagi/show_correct_class_name_in_migration_errorRafael França2017-01-302-3/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | show correct class name in migration inherited directly error
| * | | | | | | | show correct class name in migration inherited directly erroryuuji.yaginuma2017-01-242-3/+4
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | Follow up to 249f71a
* | | | | | | | Merge pull request #27847 from jaredbeck/patch-6Rafael França2017-01-301-0/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Docs: Specify return value of `save!`
| * | | | | | | | Docs: Specify return value of `save!`Jared Beck2017-01-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I can never remember if it returns `self` or `true` (seems to be `true`) [ci skip]
* | | | | | | | | Merge pull request #27743 from jordanlewis/simplify-postgres-column-definitionsRafael França2017-01-301-5/+5
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Simplify query in column_definitions() for Postgres
| * | | | | | | | Simplify Postgres query for column_definitions()Jordan Lewis2017-01-301-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | column_definitions() needs to fetch the collation for every column, if present. Previously, it did so using a correlated subquery - a subquery that references results from the outer scope. This patch updates the query to remove the subquery in favor of a simpler and more efficient JOIN clause. Running the two queries through EXPLAIN against Postgres additionally shows that the original form with a correlated subquery requires a Nested Loop Left Join, while the new form with a simple JOIN can use a more efficient Merge Left Join.
* | | | | | | | | Merge pull request #27773 from kirs/serialized-error-attributeRafael França2017-01-305-17/+34
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Report the attribute on ActiveRecord::SerializationTypeMismatch
| * | | | | | | | | Report the attribute on ActiveRecord::SerializationTypeMismatchKir Shatrov2017-01-295-17/+34
| | | | | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 09:05:00 +0000