aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | There's no such moduleAkira Matsuda2017-01-052-8/+8
| | | | | | | |
* | | | | | | | No need to :doc: a public methodAkira Matsuda2017-01-051-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #27485 from cih/hmt-warningAndrew White2017-01-045-0/+38
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Warn when has_many through is defined before through association
| * | | | | | | | Raise error when has_many through is defined before through associationChris Holmes2017-01-045-0/+38
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/issues/26834 This change raises an error if a has_many through association is defined before the through association.
* | | | | | | | Merge pull request #27552 from jarijokinen/fix-default-locale-code-exampleAndrew White2017-01-041-5/+10
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix default locale code example [ci skip]
| * | | | | | | | Add instructions for available_locales [skip ci]Jari Jokinen2017-01-041-5/+10
| | |/ / / / / / | |/| | | | | |
* | | | | | | | Merge pull request #27399 from sinogermany/rails-env-for-empty-string-env-varsRafael Mendonça França2017-01-033-1/+18
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails env for empty string env vars
| * | | | | | | | Rails.env falls back to dev mode when env var is emptyDaniel Deng2017-01-043-1/+18
| | | | | | | | |
* | | | | | | | | Merge pull request #27564 from kamipo/fix_find_by_active_record_base_object-2Rafael França2017-01-032-3/+8
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix `find_by` and `where` consistency
| * | | | | | | | | Fix `find_by` and `where` consistencyRyuta Kamizono2017-01-042-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The alternative of #26213. Currently `find_by` and `where` with AR object return inconsistent result. This is caused by statement cache does not support AR object. Passing to finder method to fix the issue. Fixes #26210.
* | | | | | | | | | Fix configuration test now that Metal#env was removedRafael Mendonça França2017-01-031-1/+1
|/ / / / / / / / /
* | | | | | | | | Revert "Merge pull request #21233 from ↵Rafael Mendonça França2017-01-0325-207/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/disable-referential-integrity-without-superuser-privileges" This reverts commit eeac6151a55cb7d5f799e1ae33aa64a839cbc3aa, reversing changes made to 5c40239d3104543e70508360d27584a3e4dc5baf. Reason: Broke the isolated tests. https://travis-ci.org/rails/rails/builds/188721346
* | | | | | | | | Revert "Merge pull request #27550 from ↵Rafael Mendonça França2017-01-039-29/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API
* | | | | | | | | Merge pull request #27550 from ↵Rafael França2017-01-039-9/+29
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine Fix generator command for nested (namespaced) rails engine
| * | | | | | | | | Fix generator command for nested (namespaced) rails engineFumiaki MATSUSHIMA2017-01-039-9/+29
| | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* | | | | | | | | Merge pull request #27562 from maclover7/jm-as-rm-requireRafael Mendonça França2017-01-031-3/+0
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove unnecessary require statements
| * | | | | | | | | Remove unnecessary require statementsJon Moss2017-01-031-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Should have been removed via 8e43fc5ace8039370f233570863b34821a3be46f.
* | | | | | | | | | Remove deprecated ActionController::Metal.callRafael Mendonça França2017-01-033-17/+11
| | | | | | | | | |
* | | | | | | | | | List full class nameJon Moss2017-01-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Metal#env` --> `ActionController::Metal#env` [ci skip]
* | | | | | | | | | Remove deprecated Metal#envRafael Mendonça França2017-01-032-5/+4
| | | | | | | | | |
* | | | | | | | | | Remove unneeded Deprecation.silenceRafael Mendonça França2017-01-031-3/+1
| | | | | | | | | |
* | | | | | | | | | Merge pull request #27563 from kamipo/fix_typoRafael França2017-01-032-3/+3
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fix typo s/permited/permitted/
| * | | | | | | | | | Fix typo s/permited/permitted/Ryuta Kamizono2017-01-042-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` % git grep -n permited actionview/test/template/url_helper_test.rb:238: def test_button_to_with_permited_strong_params actionview/test/template/url_helper_test.rb:245: def test_button_to_with_unpermited_strong_params activerecord/test/cases/relations_test.rb:1620: def test_update_on_relation_passing_active_record_object_is_not_permited ```
* | | | | | | | | | | Remove test to the db:test:cloneRafael Mendonça França2017-01-031-10/+0
| | | | | | | | | | |
* | | | | | | | | | | Remove deprecated CONTROLLER environment variable for routes taskRafael Mendonça França2017-01-033-49/+29
| | | | | | | | | | |
* | | | | | | | | | | Remove deprecated tasks in railtiesRafael Mendonça França2017-01-032-12/+5
| | | | | | | | | | |
* | | | | | | | | | | Remove deprecated file `rails/rack/debuggerRafael Mendonça França2017-01-032-3/+4
| | | | | | | | | | |
* | | | | | | | | | | Remove deprecated config.serve_static_filesRafael Mendonça França2017-01-033-29/+4
| | | | | | | | | | |
* | | | | | | | | | | Remove deprecated `config.static_cache_control`Rafael Mendonça França2017-01-034-24/+6
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #21233 from ↵Rafael França2017-01-0325-114/+207
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/disable-referential-integrity-without-superuser-privileges Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser privileges
| * | | | | | | | | | Use `SET CONSTRAINTS` for `disable_referential_integrity` without superuser ↵Fumiaki MATSUSHIMA2016-12-0325-114/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | privileges ref: 72c1557254 - We must use `authors` fixture with `author_addresses` because of its foreign key constraint. - Tests require PostgreSQL >= 9.4.2 because it had a bug about `ALTER CONSTRAINTS` and fixed in 9.4.2.
* | | | | | | | | | | Merge pull request #25522 from ↵Rafael França2017-01-033-20/+24
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_select_rows_method_signature_for_consistency Fix `select_rows` method signature for consistency
| * | | | | | | | | | | Fix `select_rows` method signature for consistencyRyuta Kamizono2017-01-043-20/+24
| | |/ / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Related #22973, #24708. `select_all`, `select_one`, `select_value`, and `select_values` method signature is `(arel, name = nil, binds = [])`. But `select_rows` is `(sql, name = nil, binds = [])`.
* | | | | | | | | | | Remove unneeded requires at active recordRafael Mendonça França2017-01-033-5/+0
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #25626 from maclover7/jm-standardize-ac-readmeRafael França2017-01-031-0/+9
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Standardize Action Cable README.md
| * | | | | | | | | | | Standardize Action Cable README.mdJon Moss2016-07-021-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All other Rails components feature this section, Action Cable should have it as well. [ci skip]
* | | | | | | | | | | | Merge pull request #26689 from kamipo/deprecate_passing_name_to_indexesRafael Mendonça França2017-01-037-5/+29
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deprecate passing `name` to `indexes` like `tables`
| * | | | | | | | | | | | Deprecate passing `name` to `indexes` like `tables`Ryuta Kamizono2017-01-047-5/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Passing `name` to `tables` is already deprecated at #21601. Passing `name` to `indexes` is also unused.
* | | | | | | | | | | | | Remove deprecation of using ActiveRecord::Base instance in .updateRafael Mendonça França2017-01-033-6/+5
| | | | | | | | | | | | |
* | | | | | | | | | | | | Remove deprecated db:test:clone* tasksRafael Mendonça França2017-01-032-24/+4
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #27560 from kamipo/fix_test_name_deprecated_to_not_permittedRafael Mendonça França2017-01-031-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix test name `deprecated` to `not_permitted`
| * | | | | | | | | | | | | Fix test name `deprecated` to `not_permitted`Ryuta Kamizono2017-01-031-2/+2
|/ / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 4b6709e818177792735e99a70ec03210c0ac38dc.
* | | | | | | | | | | | | Merge pull request #27559 from maclover7/jm-ar-changelog-grammarJon Moss2017-01-031-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | | Rephrase CHANGELOG.md entry
| * | | | | | | | | | | | Rephrase CHANGELOG.md entryJon Moss2017-01-031-1/+1
| | |/ / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rephrase entry with better sounding English. [ci skip]
* | | | | | | | | | | | Merge pull request #25460 from maclover7/jm-uncachedSean Griffin2017-01-031-0/+21
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| | | | | | | | | | | Add explicit testing for `uncached` vs. `cached`
| * | | | | | | | | | | Add explicit testing for `uncached` vs. `cached`Jon Moss2016-06-211-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a ton of middleware related tests in this file, and it seems like `cached vs. `uncached` is being neglected. Added in a test to confirm the expected behavior.
* | | | | | | | | | | | Generate indexed names in input even when objects are not persistedRafael Mendonça França2017-01-032-6/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you ask to generate multiple nested inputs using: field_for('comments[]', Comment.new) do |c| c.text_field :body Rails should generated the names like `post[comments][][body]`. To make sure we don't have regression the fake models now use the same implementation of `#to_param` as `ActiveRecord::Base` Fixes #26942
* | | | | | | | | | | | Merge pull request #26352 from kamipo/avoid_to_call_set_inverse_instance_twiceArthur Nogueira Neves2017-01-032-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid to call `set_inverse_instance` twice for `has_many` association
| * | | | | | | | | | | | Avoid to call `set_inverse_instance` twice for `has_many` associationRyuta Kamizono2016-12-282-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `create`, `create!`, and `concat` in `has_many` association hits `set_inverse_instance` twice. It is enough to hit only once.
* | | | | | | | | | | | | Merge pull request #25927 from y-yagi/remove_needless_warning_for_hstoreSean Griffin2017-01-031-5/+0
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | remove needless warning for hstore
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-21 22:51:48 +0000