aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #28367 from ptoomey3/ignore-disabled-buttonsAaron Patterson2017-03-273-1/+38
|\ | | | | Prevent ujs event propagation if element disabled when event chain begins
| * Prevent event propogation if element is disabled when event chain begins.Patrick Toomey2017-03-093-1/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The existing UJS event behavior relies on browsers not sending events for various events when an element is disabled. For example, imagine the following: <button type="submit" disabled="disabled">Click me</button> The above button is disabled, so browsers will not trigger a click event and all UJS behavior is prevented. However, imagine a button like this: <button type="submit" disabled="disabled"><strong>Click me</strong></button> The above is treated differently by browsers such as Chrome/Safari. These browsers do not consider the strong tag to be disabled, and will trigger click events. UJS has logic to walk up the DOM to find an associated element subject to UJS behavior. But, this logic does not take into account the disabled status of the element. I originally thought we could simply change the selectors used to match elements to ignore disabled elements. However, UJS disables some elements as part of the event chain. So, an element might match early in the chain and then fail to match later. Instead of changing the selectors I added a callback to the chain that calls `stopEverything` if an element is disabled when the event chain begins.
* | Merge pull request #28541 from ota42y/fix/gemfile_generator_fixEileen M. Uchitelle2017-03-274-2/+30
|\ \ | | | | | | ignore system test gems on Gemfile when execute with --skip-test option
| * | ignore system test gems on Gemfile when execute with --skip-test optionota42y2017-03-274-2/+30
| | |
* | | minor CHANGELOG formatting changes. [ci skip]Yves Senn2017-03-262-4/+2
| | |
* | | add field ids when generating a scaffold form.Yves Senn2017-03-264-7/+20
| | | | | | | | | | | | | | | | | | This is a follow up to a6d065e. When using `form_with` you must supply field ids manually. Since the scaffold generator is using labels we need to make sure that they are linked up properly.
* | | Bump from h3 to h2 tagJon Moss2017-03-251-1/+1
| | | | | | | | | | | | | | | | | | | | | "3 Days before release" should an h2, like the rest of the day headings. All of the steps are h3 tags. [ci skip]
* | | Small grammar fixJon Moss2017-03-251-1/+1
| | | | | | | | | | | | | | | | | | Add apostrophe. [ci skip]
* | | Small grammar fixJon Moss2017-03-251-2/+2
| | | | | | | | | | | | | | | | | | Add necessary commas. [ci skip]
* | | Update middleware listJon Moss2017-03-251-1/+1
| | | | | | | | | | | | | | | | | | Taken from `bin/rails about` run on a v5.1.0.rc1 application. [ci skip]
* | | Upgrade various Rails 5.0 references to 5.1Jon Moss2017-03-254-12/+13
| | | | | | | | | | | | | | | | | | | | | RC1 is out, `5-1-stable` has been created, figured it was time to start updating this stuff :) [ci skip]
* | | Add WIP Rails 5.1 release notes to documents.yamlJon Moss2017-03-251-0/+5
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #28571 from ↵Kasper Timm Hansen2017-03-251-3/+3
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/rename_local_current_user_to_verified_user_guide Rename local variable name `current_user` to `verified_user` [ci skip]
| * | | Rename local variable name `current_user` to `verified_user` [ci skip]yuuji.yaginuma2017-03-251-3/+3
|/ / / | | | | | | | | | Related #28570
* | | Merge pull request #28570 from kamipo/rename_local_current_user_to_verified_userKasper Timm Hansen2017-03-251-2/+2
|\ \ \ | | | | | | | | Rename local variable name `current_user` to `verified_user` [ci skip]
| * | | Rename local variable name `current_user` to `verified_user` [ci skip]Ryuta Kamizono2017-03-251-2/+2
|/ / / | | | | | | | | | | | | Assigning local variable named `current_user` in the condition is confusing.
* | | Revert "Merge pull request #28569 from HarryCollins/patch-1"Kasper Timm Hansen2017-03-251-1/+1
| | | | | | | | | | | | | | | | | | | | | This reverts commit 296d024b4e91c4891ae0b010249193513e63b921, reversing changes made to e341d835070c7ef9990f41e02bbf46536be0aee7. We aren't trying to compare to current_user, we're assigning that variable.
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2017-03-252-4/+4
|\ \ \
| * | | Update Configuring Rails Component guide exampleHendy Tanata2017-03-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | config.time_zone is no longer in included in config/application.rb. See 28dcadc0140dfdebe87d5e691fd709c0a9ae0bae.
| * | | Edits to Systems testing section [ci skip]Vipul A M2017-03-091-3/+3
| | | |
* | | | Merge pull request #28569 from HarryCollins/patch-1Ryuta Kamizono2017-03-251-1/+1
|\ \ \ \ | | | | | | | | | | Update Action Cable README.md - typo fix [ci skip]
| * | | | Update Action Cable README.md - typo fixHarryCollins2017-03-251-1/+1
| | | | |
* | | | | Merge pull request #28568 from y-yagi/fix_doc_format_for_duplicableRyuta Kamizono2017-03-251-6/+6
|\ \ \ \ \ | |/ / / / |/| | | | Fix doc format for `duplicable?` [ci skip]
| * | | | Fix doc format for `duplicable?` [ci skip]yuuji.yaginuma2017-03-251-6/+6
|/ / / /
* | | | Doc cleanup for caching guide [ci skip] (#28556)Vipul A M2017-03-241-4/+4
| | | |
* | | | Merge pull request #28555 from vipulnsward/rm-commentsVipul A M2017-03-241-2/+2
|\ \ \ \ | | | | | | | | | | Remove unnecessary ruby version comments
| * | | | Remove unnecessary ruby version comments [ci skip]Vipul A M2017-03-241-2/+2
|/ / / /
* | | | Merge pull request #28550 from ↵Jon Moss2017-03-231-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | rachel-carvalho/update_browser_compatibility_for_http_verbs Update guide to reflect browser compatibility for HTTP verbs
| * | | | update guide to reflect browser compatibility for HTTP verbs [ci skip]Rachel Carvalho2017-03-231-2/+2
| | | | |
* | | | | Merge pull request #28547 from brchristian/patch-2Jon Moss2017-03-231-1/+7
|\ \ \ \ \ | |/ / / / |/| | | | Additional explanation about cache implementations
| * | | | Additional explanation about cache implementationsbrchristian2017-03-231-1/+7
|/ / / /
* | | | Merge pull request #28532 from maclover7/jm-ruby-241Matthew Draper2017-03-241-4/+4
|\ \ \ \ | | | | | | | | | | Bump Travis ruby version to 2.4.1
| * | | | Bump Travis ruby version to 2.4.1Jon Moss2017-03-221-4/+4
| | | | | | | | | | | | | | | | | | | | https://www.ruby-lang.org/en/news/2017/03/22/ruby-2-4-1-released/
* | | | | Merge pull request #28544 from vipulnsward/fix-on-ruby-masterKasper Timm Hansen2017-03-232-13/+26
|\ \ \ \ \ | | | | | | | | | | | | Fix duplicable? for Rational and Complex on ruby master, since they are now duplicable
| * | | | | Fix duplicable? for Ratiional and Complex on ruby master, since they are now ↵Vipul A M2017-03-232-13/+26
| | | | | | | | | | | | | | | | | | | | | | | | duplicable
* | | | | | Merge pull request #28543 from mtsmfm/move-comment-to-inside-the-methodVipul A M2017-03-231-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Move comment to inside the method [ci skip]
| * | | | | Move comment to inside the method [ci skip]Fumiaki MATSUSHIMA2017-03-231-1/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Because this comment is not document for `supports_ranges?` ref: https://github.com/rails/rails/pull/27636#discussion_r107560081
* | | | | Merge pull request #28540 from kamipo/remove_collection_proxy_uniqRafael França2017-03-231-4/+0
|\ \ \ \ \ | |_|_|/ / |/| | | | Remove `CollectionProxy#uniq`
| * | | | Remove `CollectionProxy#uniq`Ryuta Kamizono2017-03-231-4/+0
|/ / / / | | | | | | | | | | | | | | | | Since #28473 `uniq` is delegated to `records`, so `CollectionProxy#uniq` is unnecessary.
* | | | Merge pull request #28537 from tjschuck/doc_actioncable_reject_unauthed_connxRafael França2017-03-221-5/+5
|\ \ \ \ | | | | | | | | | | Document AC::Connection::Authorization#reject_unauthorized_connection
| * | | | Document AC::Connection::Authorization#reject_unauthorized_connectionT.J. Schuck2017-03-221-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method is repeatedly used throughout the docs (in the [AC::Connection docs](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/actioncable/lib/action_cable/connection/base.rb#L28), the [AC README](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/actioncable/README.md#a-full-stack-example), the [AC Guides](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/guides/source/action_cable_overview.md#connection-setup)), but not actually documented itself and seemingly not supported for public use based on its current `private` status. This actually makes the method public and documents it. The actual behavior that’s documented here is implemented [here](https://github.com/rails/rails/blob/12b684985837bc8ee9ad15c174cf4e07ca82d7c4/actioncable/lib/action_cable/connection/base.rb#L213-L219), via [this rescuing of the UnauthorizedError](https://github.com/rails/rails/blob/3dd1de8ba4d5862b01e7f5dd3878b21fd98b443b/actioncable/lib/action_cable/connection/base.rb#L172). The method is [already tested here](https://github.com/rails/rails/blob/25473baf409185638073fe2f016f4b9dda284e50/actioncable/test/connection/authorization_test.rb#L17-L29).
* | | | | Merge pull request #28534 from claudiob/list-webpackersRafael França2017-03-221-1/+2
|\ \ \ \ \ | | | | | | | | | | | | List options for `rails new --webpack=WEBPACK`
| * | | | | List options for `rails new --webpack=WEBPACK`claudiob2017-03-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you type `rails new -h`, the `--database=DATABASE` options display this useful message: > Preconfigure for selected database (options: mysql/postgresql/sqlite3/oracle/frontbase/ibm_db/sqlserver/jdbcmysql/jdbcsqlite3/jdbcpostgresql/jdbc) However, the `--webpack=WEBPACK` option only displays this: > Preconfigure for app-like JavaScript with Webpack so it's hard to know *which* values are valid for `WEBPACK`. This commit improves the help message to display: > Preconfigure for app-like JavaScript with Webpack (options: react/vue/angular) The implication of this commit is that the list needs to be manually updated whenever rails/webpacker adds support for a new framework. However, I don't imagine this list to change very frequently, and I think that the benefit of display the list to the users is greater than the hustle of updating the list when needed.
* | | | | | No need to have an entry that was included in 5.1 in 5.2Rafael Mendonça França2017-03-221-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Merge pull request #28528 from domcleal/parseerror-const-deprecationRafael França2017-03-225-1/+88
|\ \ \ \ \ \ | | | | | | | | | | | | | | Change AD::ParamsParser::ParseError deprecation so it can be rescued
| * | | | | | Use DeprecatedConstantAccessor for AD::ParamsParser::ParseErrorDominic Cleal2017-03-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #28525
| * | | | | | Add AS::Deprecation::DeprecatedConstantAccessorDominic Cleal2017-03-224-0/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An alternative to DeprecatedConstantProxy which works more transparently with exceptions because it returns the object that the new constant refers to rather than a proxy. This is then compatible with `rescue OldException`.
* | | | | | | Merge pull request #28527 from rst/fix_runner_argv_28515Rafael França2017-03-222-2/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Correctly reset ARGV for "rails runner `CODE' arg arg arg..."
| * | | | | | | Fixup trailing whitespace, per complaints from CodeClimate.Robert Thau2017-03-221-1/+1
| | | | | | | |
| * | | | | | | Correctly reset ARGV for "rails runner `CODE' arg arg arg..."Robert Thau2017-03-222-2/+11
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code itself should not be in the ARGV vector. Fixes #28515
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-15 09:23:39 +0000