| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix regression in has_secure_password.
|
|/
|
|
| |
If the confirmation was blank, but the password wasn't, it would still save.
|
|\
| |
| |
| |
| | |
senny/10782_routes_inspector_deals_with_controller_regexp
`RoutesInspector` deals with routes using regexp as `:controller` option
|
|/ |
|
|\
| |
| | |
Use grep instead of select with === in QueryMethods
|
| |
| |
| |
| | |
pass block directly to grep
|
|\ \
| | |
| | | |
Running isolated tests
|
| | |
| | |
| | |
| | | |
These stopped running don't know when.
But these should be running now.
|
|\ \ \
| | | |
| | | | |
Minor refactor of ActiveRecord::SchemaMigration
|
| | | |
| | | |
| | | |
| | | | |
Base, override table_exists method, and switch to preferred style for class method definitions.
|
|\ \ \ \
| | | | |
| | | | | |
PostgreSQL specific test cleanup
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This branch is composed of #10629 and #10708
Closes #10629
Closes #10708
Fixes #10628
|
| | | | | |
|
| | | | | |
|
|/| | | |
| | | | |
| | | | |
| | | | | |
Fixes bug 10628.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add notice on server boot if binding to 0.0.0.0
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
test cleanup, replace `define_method` and `remove_method` with stubs.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | |
| | | | | |
| | | | | | |
senny/10615_join_should_not_return_readonly_records
using `#joins` does not imply `readonly = true`.
|
| | | | | | |
|
|/ / / / / |
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
test-case for `Array#to_sentence` with `blank?` items.
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
compatability => compatibility
|
| |/ / / |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix some typo in method names, variables
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Because decorators aren't referenced by the application, they won't get
autoloaded. And because we recommend the pattern, it would be irresponsible
to not show how to load them properly.
Fixes #10647.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
docs, adjust the application.rb snippets to match the generated file.
Closes #10449
|
| | | |
| | | |
| | | |
| | | | |
`if defined?(Bundler)` is no longer used in our current application.rb
|
|\ \ \ \
| | | | |
| | | | | |
Fix the `:primary_key` option for `has_many` associations.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When removing records from a `has_many` association it used
the `primary_key` defined on the association.
Our test suite didn't fail because on all occurences of `:primary_key`,
the specified column was available in both tables. This prevented the
code from raising an exception but it still behaved badly.
I added a test-case to prevent regressions that failed with:
```
1) Error:
HasManyAssociationsTest#test_has_many_assignment_with_custom_primary_key:
ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: essays.first_name: UPDATE "essays" SET "writer_id" = NULL WHERE "essays"."writer_id" = ? AND "essays"."first_name" IS NULL
```
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | | |
Closes #10716
|
|/ / / /
| | | |
| | | |
| | | | |
their setup in their constructor now.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
minitest/autorun required minitest/spec and we are avoiding to require
it.
|
|\ \ \ \
| | | | |
| | | | | |
Eliminate minitest warnings
|
| | | | |
| | | | |
| | | | |
| | | | | |
https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6#L15R8
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove code duplication
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Extract tests code out from AR's base_test.rb
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The method got extracted out from AR::Base in commit
d916c62cfc7c59ab6411407a05b946d3dd7535e9, but the tests never did.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
base_test.rb
The method itself got extracted out from ActiveRecored::Base in commit
ceb33f84933639d3b61aac62e5e71fd087ab65ed, but the test code never did.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The methods got moved to core.rb in commit
b2c9ce341a1c907041f55461aefebb0321280cb5, but the tests never did.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Add ActiveModel requirement to application.rb
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently, ActiveModel is only loaded by ActiveRecord. If you skip ActiveRecord, ActiveModel will not be required (or even autoloaded) and including `ActiveModel::Model` into a plain Ruby class will raise `NameError`.
To reproduce this:
- create a new app with `rails new my_app -O`
- create a Ruby class that includes `ActiveModel::Model` in `app/models`
- load up a Rails console and try to do anything with the class :-)
Since ActionPack relies so heavily on the ActiveModel API, this should probably be considered a dependency of the app. Another possibility would be to make it a dependency of ActionController.
|