aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* :nail_care: for migrations guide from #15457 [ci skip]Zachary Scott2014-06-011-7/+8
|
* Merge pull request #15457 from maurogeorge/add-changing-columnsZachary Scott2014-06-011-0/+22
|\ | | | | Create Changing Columns on migrations guides [ci skip]
| * Create Changing Columns on migrations guidesMauro George2014-06-011-0/+22
| | | | | | | | [ci skip]
* | Remove docs regarding grouping multiple values, as we should avoidZachary Scott2014-06-011-18/+1
| | | | | | | | duplicating API reference in guides. Also :scissors: [ci skip]
* | Merge pull request #15459 from maurogeorge/add-total-grouped-itemsZachary Scott2014-06-011-0/+34
|\ \ | | | | | | Add Total of grouped items to Active Record query interface on guides [ci skip]
| * | Add Total of grouped items to AR query interface on guidesMauro George2014-06-011-0/+34
| |/ | | | | | | [ci skip]
* | Merge pull request #15435 from sgrif/sg-rm-serializationYves Senn2014-06-0112-103/+30
|\ \ | | | | | | Remove most code related to serialized properties
| * | Remove most code related to serialized propertiesSean Griffin2014-06-0112-103/+30
|/ / | | | | | | | | | | | | | | | | | | | | Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing
* | Merge pull request #15432 from sgrif/sg-coder-type-castingYves Senn2014-06-014-23/+14
|\ \ | | | | | | Don't change values in `@raw_attributes` during serialization
| * | Don't change values in `@raw_attributes` during serializationSean Griffin2014-06-014-23/+14
| | | | | | | | | | | | | | | | | | During `init_with`, the attributes given to the coder will be placed into `@raw_attributes`. As such, we should read from `@raw_attributes` when encoding, rather than `@attributes`, which has been type cast.
* | | Merge pull request #14881 from robin850/patch-19Yves Senn2014-06-011-5/+8
|\ \ \ | | | | | | | | Swallow bundler exceptions when running tests
| * | | Swallow bundler exceptions when running testsRobin Dupret2014-04-271-5/+8
| | | | | | | | | | | | | | | | Let's avoid useless output when testing stuff related to Bundler.
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-06-014-6/+11
|\ \ \ \
| * | | | document generators hidden_namespacesschneems2014-05-291-0/+5
| | | | |
| * | | | [ci skip] add created_at and updated_at to exampleschneems2014-05-291-2/+2
| | | | |
| * | | | [ci skip] Fix Compiler's Github linkHarshad Sabne2014-05-271-1/+1
| | | | |
| * | | | :scissors:Zachary Scott2014-05-121-3/+3
| | | | |
* | | | | Merge pull request #15456 from jonatack/patch-7Matthew Draper2014-06-011-2/+2
|\ \ \ \ \ | |_|_|/ / |/| | | | config.assets.digests -> config.assets.digest
| * | | | config.assets.digests -> config.assets.digestJon Atack2014-06-011-2/+2
|/ / / / | | | | | | | | | | | | | | | | in Asset Pipeline guide. [skip ci]
* | | | Removed 'Caching with Rails' guide from WIP, this guide isn't ready toZachary Scott2014-05-311-5/+0
| | | | | | | | | | | | | | | | be published and requires more attention. [ci skip]
* | | | Merge pull request #15449 from aditya-kapoor/correct-debug-docRichard Schneeman2014-05-311-5/+1
|\ \ \ \ | | | | | | | | | | [ci skip] correct doc for ActionView::Helpers::DebugHelper
| * | | | [ci skip] correct doc for ActionView::Helpers::DebugHelperAditya Kapoor2014-05-311-5/+1
| | | | |
* | | | | Missing period from AP/CHANGELOG [ci skip]Zachary Scott2014-05-311-1/+1
| | | | |
* | | | | Merge pull request #15448 from akshay-vishnoi/doc_changesCarlos Antonio da Silva2014-05-311-2/+2
|\ \ \ \ \ | |/ / / / |/| | | | [ci skip] Correct output of Hash#symbolize_keys
| * | | | [ci skip] Correct output of Hash#symbolize_keysAkshay Vishnoi2014-05-311-2/+2
| | | | |
* | | | | Merge pull request #15434 from sgrif/sg-clear-cachesYves Senn2014-05-312-3/+27
|\ \ \ \ \ | |/ / / / |/| | | | Clear all caches calculated based on `@columns` when `@columns` changes
| * | | | Clear all caches calculated based on `@columns` when `@columns` changesSean Griffin2014-05-312-3/+27
| | | | |
* | | | | Tiny formatting fix in AS change log [ci skip]Robin Dupret2014-05-311-4/+4
| | | | |
* | | | | Merge pull request #15446 from akshay-vishnoi/doc_changesRobin Dupret2014-05-311-2/+2
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Correct documentation of HashWithIndifferentAccess#dup
| * | | | | [ci skip] Correct documentation of HashWithIndifferentAccess#dupAkshay Vishnoi2014-05-311-2/+2
| | |_|_|/ | |/| | |
* | | | | Merge pull request #15445 from krautcomputing/fix_asset_host_docsZachary Scott2014-05-311-1/+4
|\ \ \ \ \ | |/ / / / |/| | | | Update documentation for setting asset_host to a Proc [ci skip]
| * | | | Update documentation for setting asset_host to a Proc, mention that the ↵Manuel Meurer2014-05-311-1/+4
|/ / / / | | | | | | | | | | | | request parameter might not be supplied [ci skip]
* | | | Merge pull request #15437 from sgrif/sg-missing-test-caseYves Senn2014-05-311-0/+2
|\ \ \ \ | | | | | | | | | | Add missing test case for writing unknown attributes
| * | | | Add missing test case for writing unknown attributesSean Griffin2014-05-301-0/+2
| |/ / /
* | | | Merge pull request #15440 from ilikepi/pr_docs_activesupport_hwia_dupZachary Scott2014-05-301-1/+8
|\ \ \ \ | |/ / / |/| | | HashWithIndifferentAccess#dup doc [ci skip]
| * | | HashWithIndifferentAccess#dup doc [ci skip]James Blanding2014-05-301-1/+8
|/ / / | | | | | | | | | | | | The phrase "exact copy" in the existing docmentation is somewhat misleading.
* | | Merge pull request #15431 from sgrif/sg-bad-serialization-test-casesRafael Mendonça França2014-05-301-53/+17
|\ \ \ | | | | | | | | Update some bad test cases for serialized columns
| * | | Update some bad test cases for serialized columnsSean Griffin2014-05-301-53/+17
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The first case was not testing what the issue mentioned actually was (A subclass of a class with serialized attributes does not serialize when they come from the database). The second case was a bad coder. It would fail if the model was `dup`ed, or if the the model was loaded from the database and then saved again. The third case wasn't testing anything that wasn't covered by the second (and was also a bad coder for the same reasons as the second).
* | | Merge pull request #15427 from sgrif/sg-rename-attribute-ivarsRafael Mendonça França2014-05-3013-44/+44
|\ \ \ | | | | | | | | Rename attribute related instance variables to better express intent
| * | | Rename attribute related instance variables to better express intentSean Griffin2014-05-3013-44/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `@attributes` was actually used for `_before_type_cast` and friends, while `@attributes_cache` is the type cast version (and caching is the wrong word there, but I'm working on removing the conditionals around that). I opted for `@raw_attributes`, because `_before_type_cast` is also semantically misleading. The values in said hash are in the state given by the form builder or database, so raw seemed to be a good word.
* | | | Merge pull request #15354 from sgrif/sg-properties-defaultRafael Mendonça França2014-05-303-6/+19
|\ \ \ \ | | | | | | | | | | Allow specifying a default value in overloaded properties
| * | | | Allow specifying a default value in overloaded propertiesSean Griffin2014-05-303-6/+19
| |/ / /
* | | | Merge pull request #15426 from oggy/doc-3.2.18Zachary Scott2014-05-301-4/+5
|\ \ \ \ | |/ / / |/| | | Update guides to mention 3.2.18. [ci skip]
| * | | Update guides to mention 3.2.18.George Ogata2014-05-301-4/+5
|/ / / | | | | | | | | | And reword things a little to mention the specific patch release less.
* | | Merge pull request #15313 from ↵Rafael Mendonça França2014-05-301-0/+8
|\ \ \ | | | | | | | | | | | | | | | | andreychernih/time-with-zone-string-conversion-speed-up Speed-up TimeWithZone to String conversion
| * | | Speed-up TimeWithZone to String conversionAndrey Chernih2014-05-271-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've noticed that `String(model.created_at)` is performing poorly in comparision with other fields. The source of the problem is a way `Kernel#String` works: it first tries to call `to_str` (which causes `NoMethodError` in `method_missing`) and then calls `to_s`. Performance tests: tz = Time.zone.now Benchmark.ips do |x| x.report { String(tz) } end Without this code: Calculating ------------------------------------- 572 i/100ms ------------------------------------------------- 10177.7 (±18.2%) i/s - 48620 in 5.000325s With this code: Calculating ------------------------------------- 1518 i/100ms ------------------------------------------------- 138984.2 (±10.1%) i/s - 677028 in 4.974897s
* | | | Change the version schema to reflect how deprecations are handledRafael Mendonça França2014-05-301-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip] We only introduce new deprecations at Minor releases.
* | | | Merge pull request #15425 from leafac/fix-testing-docsRafael Mendonça França2014-05-301-12/+8
|\ \ \ \ | | | | | | | | | | Update Minitest references in Testing Guide
| * | | | Update Minitest references in Testing GuideLeandro Facchinetti2014-05-301-12/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Guide references `test/unit`, which has been replaced by `Minitest` in all versions of Ruby supported by Rails. The following updates were performed: * The superclass of `ActiveSupport::TestCase` is no longer `MiniTest::Unit::TestCase`, but `Minitest::Test` [1]. * The preferred spelling is `Minitest`, not `MiniTest` [2]. * For a method to be a test in Minitest, its name must start with `test_`, not only `test` [3]. * Explanations about `test/unit` in Ruby 1.8 were removed in favor of more up-to-date information on `Minitest`. [1]: https://github.com/rails/rails/blob/6c2b569660c9216595d02ce6412e3bdcc7293317/activesupport/lib/active_support/test_case.rb#L18 [2]: https://github.com/seattlerb/minitest/blob/d5d43cef9a3fd4a0eea972dde125ed5ba1ddb821/lib/minitest.rb#L9 [3]: https://github.com/seattlerb/minitest/blob/d5d43cef9a3fd4a0eea972dde125ed5ba1ddb821/lib/minitest/test.rb#L62
* | | | | bin/setup uses `bundle check || bundle install` to improve performance.Yves Senn2014-05-301-1/+1
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-19 04:55:59 +0000