aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Refactor `test_find_by_does_not_use_statement_cache_if_table_name_is_changed`kenta-s2017-02-131-2/+2
|
* Merge pull request #27122 from kamipo/fix_unscope_with_subqueryRafael França2017-02-132-14/+38
|\ | | | | Fix unscope with subquery
| * Refactor `except_predicates_and_binds` to avoid `tap`Ryuta Kamizono2017-02-131-12/+15
| |
| * Fix unscope with subqueryRyuta Kamizono2016-12-052-10/+31
| | | | | | | | | | | | | | Currently cannot unscope subquery properly. This commit fixes the issue. Fixes #26323.
* | Merge pull request #26930 from kamipo/index_name_exists_defaultRafael França2017-02-136-27/+37
|\ \ | | | | | | The `default` arg of `index_name_exists?` makes to optional
| * | Deprecate passing `default` to `index_name_exists?`Ryuta Kamizono2017-02-134-5/+21
| | |
| * | The `default` arg of `index_name_exists?` makes to optionalRyuta Kamizono2017-02-135-24/+18
| | | | | | | | | | | | | | | | | | The `default` arg of `index_name_exists?` is only used the adapter does not implemented `indexes`. But currently all adapters implemented `indexes` (See #26688). Therefore the `default` arg is never used.
* | | Merge pull request #26630 from kamipo/quoted_binaryRafael França2017-02-134-20/+17
|\ \ \ | |/ / |/| | Extract `quoted_binary` and use it rather than override `_quote`
| * | Extract `quoted_binary` and use it rather than override `_quote`Ryuta Kamizono2016-09-274-20/+17
| | | | | | | | | | | | | | | | | | | | | Each databases have different binary representation. Therefore all adapters overrides `_quote` for quoting binary. Extract `quoted_binary` for quoting binary and use it rather than override `_quote`.
* | | Schema dumping support for PostgreSQL oid typeRyuta Kamizono2017-02-128-13/+33
| | | | | | | | | | | | Closes #27980
* | | Schema dumping support for PostgreSQL interval typeRyuta Kamizono2017-02-128-21/+36
| | | | | | | | | | | | Closes #27979
* | | Deprecate `supports_primary_key?`Ryuta Kamizono2017-02-126-28/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `supports_primary_key?` was added to determine if `primary_key` is implemented in the adapter in f060221. But we already use `primary_key` without `supports_primary_key?` (207f266, 5f3cf42) and using `supports_primary_key?` has been removed in #1318. This means that `supports_primary_key?` is no longer used in the internal and Active Record doesn't work without `primary_key` is implemented (all adapters must implement `primary_key`). Closes #27977
* | | Remove unused requireRyuta Kamizono2017-02-128-11/+0
| | | | | | | | | | | | | | | | | | These files are not using `strip_heredoc`. Closes #27976
* | | Merge pull request #27982 from Edouard-chin/removes-extra-require-callRafael França2017-02-122-2/+0
|\ \ \ | | | | | | | | Removed the `attribute_accessors` required file:
| * | | Also not needed on this file, call to `mattr_accessor` got removed in ↵Edouard CHIN2017-02-121-1/+0
| | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/9e98f3f7e61dfce0a48948c8d296400af8bfaf21#diff-1ecd313ff0ab827af30014553cf8918dL76
| * | | Removed the `attribute_accessors` required file:Edouard CHIN2017-02-121-1/+0
| | | | | | | | | | | | | | | | - This file is no more needed, the call to `cattr_reader` were removed in https://github.com/rails/rails/commit/9e2948e750fa3f641f20adad4b4ecae89b35faa7#diff-c5146df11f35304765e9ceebed108f57L60 and https://github.com/rails/rails/commit/1fe0a1b5ebebb1372968606b85ce08b93bc145c8#diff-c5146df11f35304765e9ceebed108f57L99
* | | | Make `table_name=` reset current statement cachenamusyaka2017-02-123-0/+32
|/ / / | | | | | | | | | | | | | | | So queries are not run against the previous table name. Closes #27953
* | | Merge pull request #27973 from kenta-s/add-missing-test-for-time-blankAndrew White2017-02-121-1/+1
|\ \ \ | | | | | | | | Add Time#blank? to blank_test
| * | | Add Time#blank? to blank_testkenta-s2017-02-121-1/+1
| | | |
* | | | Merge pull request #27974 from kamipo/add_new_rubocop_ruleXavier Noria2017-02-1212-11/+4
|\ \ \ \ | | | | | | | | | | Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra empty lines
| * | | | Add `Style/EmptyLinesAroundMethodBody` in `.rubocop.yml` and remove extra ↵Ryuta Kamizono2017-02-1212-11/+4
| |/ / / | | | | | | | | | | | | empty lines
* | | | document link processing in guides generation [ci skip]Xavier Noria2017-02-121-2/+42
| | | |
* | | | refactors and fixes in guides generation [ci skip]Xavier Noria2017-02-127-162/+124
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is not precisely atomic, but the changes have evolved, summary: * The ENV-based interface has been moved upwards, the generator has now a conventional initializer. * RAILS_VERSION is now assumed to be a Git tag. A blank RAILS_VERSION means edge guides. * In consequence, the EDGE env variable is gone. * The "local" version is also gone, the current SHA1 is computed for edge guides. * Assumes guides are generated from a repo checkout (time ago users could generate them from gems.) * The WARNINGS flag is gone in consequence, you cannot disable warnings. * The `api_link` Markdown helper is fixed. * Docs about usage have one single place: rake guides:help. * Links in guides have been revised.
* | | Deprecate calling `attr_will_change!` with non-attributesSean Griffin2017-02-113-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was never really intended to work (at least not without calling `define_attribute_methods`, which is less common with Active Record). As we move forward the intention is to require the use of `attribute` over `attr_accessor` for more complex model behavior both on Active Record and Active Model, so this behavior is deprecated. Fixes #27956. Close #27963. [Alex Serban & Sean Griffin]
* | | [ci skip] Fully qualify missing template error.Kasper Timm Hansen2017-02-111-1/+1
| | | | | | | | | | | | Switch extension 👉 format as it's more apt here.
* | | Merge pull request #27870 from kenta-s/get-todo-done-in-render_testKasper Timm Hansen2017-02-112-2/+3
|\ \ \ | | | | | | | | Get TODO done in `render_test`
| * | | Add information on `:formats` option in action_view_overview.mdkenta-s2017-02-062-2/+3
| | | |
* | | | Fix bigint primary key with unsignedRyuta Kamizono2017-02-102-12/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently schema dumper lost the unsigned option when primary key is defined as bigint with unsigned. This commit fixes the issue. Closes #27960
* | | | Test with the newest i18nAkira Matsuda2017-02-111-1/+1
| | | | | | | | | | | | | | | | which is bundled in new apps by default
* | | | Merge pull request #27904 from ↵Eileen M. Uchitelle2017-02-102-1/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kenta-s/add-methods-back-to-array-delegation-from-ar-relation Delegate `to_sentence` and `to_fomatted_s` to `records`
| * | | | Delegate `to_sentence` and `to_fomatted_s` to `records`kenta-s2017-02-042-1/+3
| | | | |
* | | | | Merge pull request #27959 from y-yagi/use_released_resqueKasper Timm Hansen2017-02-102-13/+8
|\ \ \ \ \ | | | | | | | | | | | | Use released resque
| * | | | | Use released resqueyuuji.yaginuma2017-02-102-13/+8
|/ / / / /
* | | | | Merge pull request #27957 from ↵Rafael França2017-02-092-10/+18
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_test_composite_primary_key_out_of_order Fix `test_composite_primary_key_out_of_order`
| * | | | | Revert "Simplify and speed up Postgres query for primary_keys"Ryuta Kamizono2017-02-101-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d6529af2954a67bd57fda45286fa9cfd0ff6b5ac.
| * | | | | Fix `test_composite_primary_key_out_of_order`Ryuta Kamizono2017-02-101-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `test_composite_primary_key_out_of_order` should use `barcodes_reverse` table.
* | | | | | Fix rubocop violationsRafael Mendonça França2017-02-093-13/+15
|/ / / / /
* | | | | Merge pull request #27950 from st0012/update-configuration-guideRafael França2017-02-091-0/+5
|\ \ \ \ \ | | | | | | | | | | | | Update configuration guide about ActiveRecord's use_schema_cache_dump option [ci skip]
| * | | | | Update configuration guide about ActiveRecord's config option.Stan Lo2017-02-101-0/+5
|/ / / / /
* | | | | Merge pull request #27954 from maclover7/jm-fix-26404Jon Moss2017-02-091-0/+10
|\ \ \ \ \ | | | | | | | | | | | | Add note about breakage in file uploads in controller tests to upgrading guide
| * | | | | Add note about breakage in file uploads in controller tests to upgradingJon Moss2017-02-091-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | guide ref #26404 [ci skip]
* | | | | | Simplify and speed up Postgres query for primary_keysJordan Lewis2017-02-092-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | primary_keys(table) needs to query various metadata tables in Postgres to determine the primary key for the table. Previously, it did so using a complex common table expression against pg_constraint and pg_attribute. This patch simplifies the query by joining pg_index against pg_attribute instead of going through pg_constraint. This avoids an expensive unnest, window function query, and common table expression. EXPLAINing these queries in Postgres against a database with a single table with a composite primary key shows a 66% reduction in the plan and execute latencies. This is significant during application startup time, especially against very large schemas, where these queries would be even slower and more numerous. Closes #27949
* | | | | | Merge pull request #27952 from dijonkitchen/patch-1Eileen M. Uchitelle2017-02-091-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix wording
| * | | | | | Fix wordingJonathan Chen2017-02-091-1/+1
|/ / / / / /
* | | | | | Refactor `ColumnDefinition` to contain `options` hashRyuta Kamizono2017-02-0915-128/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Column options are passed as an hash args then used as `options` hash in `add_column_options!`. Converting args to attributes is inconvinient for using options as an hash.
* | | | | | Merge pull request #27945 from betesh/allow-frozen-hashes-to-as_jsonRafael Mendonça França2017-02-083-1/+16
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Allow ActiveRecord::Base.as_json to accept a frozen Hash
| * | | | | | Allow ActiveRecord::Base.as_json to accept a frozen HashIsaac Betesh2017-02-083-1/+16
| | | | | | |
* | | | | | | Merge pull request #27935 from namusyaka/fix-hidden-primary_keyRafael França2017-02-085-1/+18
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fix inspection behavior when the :id column is not primary key
| * | | | | | Fix inspection behavior when the :id column is not primary keynamusyaka2017-02-095-1/+18
|/ / / / / /
* | | | | | Merge pull request #27940 from ↵Rafael França2017-02-087-23/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | y-yagi/deprecate_halt_callback_chains_on_return_false deprecate `halt_callback_chains_on_return_false` instead of `halt_and_display_warning_on_return_false`
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 02:01:06 +0000