aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove alt generation from image_submit_tagRafael Mendonça França2017-08-232-7/+7
|
* Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-239-40/+42
|\ | | | | | | Do not generate default alt text for images
| * Do not generate default alt text in image tagsCameron Cundiff2017-08-179-40/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | Merge pull request #30365 from yahonda/require_post_before_commentRyuta Kamizono2017-08-231-0/+3
|\ \ | | | | | | `counter_cache` requires association class before `attr_readonly`
| * | `counter_cache` requires association class before `attr_readonly`Yasuo Honda2017-08-231-0/+3
| | | | | | | | | | | | | | | There were similar pull requests #26370 #27575 fixed by different way by moving `require "models/post"` before `require "models/comment"`
* | | Merge pull request #30373 from ↵Ryuta Kamizono2017-08-2318-27/+27
|\ \ \ | | | | | | | | | | | | | | | | yhirano55/use_https_instead_of_http_in_rails_guide Use https instead of http in guide [ci skip]
| * | | Use https instead of http in guide [ci skip]Yoshiyuki Hirano2017-08-2318-27/+27
| | | |
* | | | Merge pull request #28991 from yahonda/load_authors_and_author_addressesRyuta Kamizono2017-08-234-4/+4
|\ \ \ \ | |/ / / |/| | | Load :author_addresses fixture to keep data integrity with :authors
| * | | Load both `:authors` and `:author_addresses` to keep data integrityYasuo Honda2017-08-224-4/+4
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `:authors` has a foreign key to `:author_addresses`. If only `:authors` fixture loaded into the database which supports foreign key and checks the existing data when enabling foreien keys like Oracle, it raises the following error `ORA-02298: cannot validate (ARUNIT.FK_RAILS_94423A17A3) - parent keys not found` It is because there is no parent data exists in `author_addresses` table. Here are how other database with foreign key support works: - MySQL does not check the existing data when enabling foreign key by `foreign_key_checks=1` https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_foreign_key_checks > Setting foreign_key_checks to 1 does not trigger a scan of the existing table data. Therefore, rows added to the table while foreign_key_checks=0 will not be verified for consistency. - PostgreSQL database itself has a feature to check existing data when enabling foreign key and discussed at #27636, which is reverted.
* | | Merge pull request #30360 from gcourtemanche/transaction_timedoutRafael França2017-08-223-0/+14
|\ \ \ | | | | | | | | Add TransactionTimeout for MySQL error code 1205
| * | | Add TransactionTimeout for MySQL error code 1205Gabriel Courtemanche2017-08-223-0/+14
| | | |
* | | | Merge pull request #30371 from yhirano55/fix_spaces_in_the_comment_blockRichard Schneeman2017-08-221-1/+1
|\ \ \ \ | | | | | | | | | | Fix spaces in the comment block [ci skip]
| * | | | Fix spaces in the comment block [ci skip]Yoshiyuki Hirano2017-08-231-1/+1
| | | | |
* | | | | Merge pull request #30369 from dustMason/security-guide-grammar-fixGeorge Claghorn2017-08-221-1/+1
|\ \ \ \ \ | |_|_|/ / |/| | | | Grammar fix
| * | | | Grammar fixJordan Sitkin2017-08-221-1/+1
|/ / / / | | | | | | | | | | | | Changed the phrase '... and many more high targets' to '... and many more high _profile_ targets'
* | | | Merge pull request #30363 from ibrahimab/patch-1Ryuta Kamizono2017-08-231-1/+1
|\ \ \ \ | | | | | | | | | | Fixing nginx configuration added missing semicolon [ci skip]
| * | | | Fixing nginx configuration added missing semicolonIbrahim2017-08-221-1/+1
|/ / / /
* | | | Merge pull request #30336 from bogdanvlviv/use_version_5_2_for_activestorageRafael França2017-08-222-2/+2
|\ \ \ \ | | | | | | | | | | Use 5.2 version of ActiveRecord::Migration for Active Storage
| * | | | Use 5.2 version of ActiveRecord::Migration for Active Storagebogdanvlviv2017-08-222-2/+2
|/ / / /
* | | | Merge pull request #30356 from ↵Kasper Timm Hansen2017-08-222-2/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | bogdanvlviv/remove-frozen_string_literal-from-blob-migration Remove frozen_string_literal comment from activestorage's migration
| * | | | Remove frozen_string_literal comment from activestorage's migrationbogdanvlviv2017-08-222-2/+1
| |/ / / | | | | | | | | | | | | | | | | The activestorage's migration is used as template for apps Related to #30348
* | | | Merge pull request #23425 from yui-knk/support_sti_automatically_inverseAkira Matsuda2017-08-223-2/+43
|\ \ \ \ | | | | | | | | | | Automatically guess the inverse associations for STI
| * | | | Automatically guess the inverse associations for STIyui-knk2017-08-223-2/+43
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord associations automatically guess the inverse associations. But this feature does not work correctly on assoctions for STI. For example, before this commit ``` class Post < ActiveRecord::Base belongs_to :author end class SpecialPost < Post; end class Author < ActiveRecord::Base has_many :posts has_many :special_posts end ``` `author.posts.first.author` works correctly, but `author.special_posts.first.author` does not work correctly.
* | | | Merge pull request #30357 from ydakuka/missing-backquotesRyuta Kamizono2017-08-223-4/+4
|\ \ \ \ | | | | | | | | | | missing backquotes [ci skip]
| * | | | missing backquotes [ci skip]Yauheni Dakuka2017-08-223-4/+4
| | | | |
* | | | | Merge pull request #30353 from yhirano55/use_https_instead_of_http_in_actionpackRyuta Kamizono2017-08-229-21/+21
|\ \ \ \ \ | | | | | | | | | | | | [actionpack] Update links to use https link instead of http [ci skip]
| * | | | | Update links to use https link instead of http [ci skip]Yoshiyuki Hirano2017-08-229-21/+21
|/ / / / /
* | | | | Merge pull request #30354 from ↵Ryuta Kamizono2017-08-2212-13/+13
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | yhirano55/use_https_instead_of_http_in_activerecord [activerecord] Update links to use https instead of http [ci skip]
| * | | | | Update links to use https instead of http [ci skip]Yoshiyuki Hirano2017-08-2212-13/+13
| | |/ / / | |/| | |
* | | | | Merge pull request #30348 from koic/remove_frozen_string_literal_from_templatesGeorge Claghorn2017-08-2142-85/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove frozen_string_literal magic comment from templates
| * | | | | Remove frozen_string_literal magic comment from templatesKoichi ITO2017-08-2242-85/+0
| | | | | |
* | | | | | Merge pull request #30355 from ↵Ryuta Kamizono2017-08-225-6/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | yhirano55/use_https_instead_of_http_in_activesupport [activesupport] Update links to use https instead of http [ci skip]
| * | | | | | Update links to use https instead of http [ci skip]Yoshiyuki Hirano2017-08-225-6/+6
|/ / / / / /
* | | | | | Merge pull request #30352 from yhirano55/update_licenses_linkRyuta Kamizono2017-08-2212-15/+14
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update MIT licenses link [ci skip]
| * | | | | | Update MIT licenses link [ci skip]Yoshiyuki Hirano2017-08-2212-15/+14
| | |/ / / / | |/| | | |
* | | | | | Add frozen string literal pragmaGeorge Claghorn2017-08-211-0/+2
| | | | | |
* | | | | | Encode Content-Disposition filenames according to RFC 2231George Claghorn2017-08-216-4/+74
| |_|/ / / |/| | | | | | | | | | | | | | Closes #30134.
* | | | | Merge pull request #30349 from ydakuka/patch-1Ryuta Kamizono2017-08-221-4/+4
|\ \ \ \ \ | |_|_|/ / |/| | | | Update debugging rails applications guide [ci skip]
| * | | | Update debugging_rails_applications [ci skip]Yauheni Dakuka2017-08-211-4/+4
|/ / / /
* | | | Merge pull request #28912 from kaspth/getting-started-form-withKasper Timm Hansen2017-08-212-67/+100
|\ \ \ \ | |_|/ / |/| | | [ci skip] form_with in the getting started guide.
| * | | [ci skip] form_with in the getting started guide.Kasper Timm Hansen2017-08-212-67/+100
| | | | | | | | | | | | | | | | Add back a bit about a resource oriented style of routing.
* | | | Merge pull request #30346 from ↵Ryuta Kamizono2017-08-222-2/+2
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | yhirano55/fix_broken_link_to_mysql_docs_in_database_yml Fix broken link to mysql docs in database.yml [ci skip]
| * | | Fix broken link to mysql docs in database.yml [ci skip]Yoshiyuki Hirano2017-08-222-2/+2
|/ / /
* | | Merge pull request #30345 from yhirano55/fix_link_contributing_guideEileen M. Uchitelle2017-08-211-7/+7
|\ \ \ | | | | | | | | Fix link in Contributing Ruby on Rails guide [ci skip]
| * | | Fix link Contributing Ruby on Rails [ci skip]Yoshiyuki Hirano2017-08-211-7/+7
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | * Add Contributing to the Rails Code link. * Wiki link for Spanish is redirect. * The base branch of Polish repo is master. And Turkish is, too. * Unified expression `rails-dev-box` * The Clone url is wrong. * The mailing list url is old.
* | | Merge pull request #30344 from yhirano55/update_guide_contributing_ruby_on_railsप्रथमेश Sonpatki2017-08-211-1/+1
|\ \ \ | | | | | | | | Update Contributing to Ruby on Rails guide [ci skip]
| * | | Update Contributing to Ruby on Rails guide [ci skip]Yoshiyuki Hirano2017-08-211-1/+1
|/ / /
* | | Merge pull request #30343 from yhirano55/update_generator_guideVipul A M2017-08-211-4/+8
|\ \ \ | | | | | | | | Update generator guide [ci skip]
| * | | Update generator guide [ci skip]Yoshiyuki Hirano2017-08-211-4/+8
| | | |
* | | | Prevent extra `SET time zone` in `configure_connection` (#28413)Ryuta Kamizono2017-08-212-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `SET time zone 'value'` is an alias for `SET timezone TO 'value'`. https://www.postgresql.org/docs/current/static/sql-set.html So if `variables["timezone"]` is specified, it is enough to `SET timezone` once.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 05:59:45 +0000