| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This also reverts the change to enable prepared statements by default on
MySQL (though I suspect we could enable them and it'd be great). This
change brings back a collector closer to the old `Bind` collector in
Arel. However, this one lives in AR, since this is an AR specific need.
Additionally, we only use it for statement caching, since the new
substitute collector in Arel is higher performance for most cases.
|
|
|
|
|
|
|
|
|
|
| |
Honestly I don't think the tests that are fixed by this change should
have been merged. Passing a range or an array to `where` has a special
meaning. We need to solve the problem more concretely without overriding
the behavior that is present for *every* other type.
However, the damage has been done. These changes were in 5.1, so we need
a deprecation cycle to remove it.
|
|\
| |
| | |
Remove duplicated assertion in `test_count_with_join`
|
| |
| |
| |
| |
| | |
The queries both `res2` and `res3` are completely the same.
And also, `assert_nothing_raised` is covered by following assertion.
|
| |
| |
| |
| |
| |
| | |
There's an actual bug in 213796fb4936dce1da2f0c097a054e1af5c25c2c around
prepared statements being disabled. I'm looking into it, but in the mean
time this gets the build green so it doesn't block other PRs
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A common source of bugs and code bloat within Active Record has been the
need for us to maintain the list of bind values separately from the AST
they're associated with. This makes any sort of AST manipulation
incredibly difficult, as any time we want to potentially insert or
remove an AST node, we need to traverse the entire tree to find where
the associated bind parameters are.
With this change, the bind parameters now live on the AST directly.
Active Record does not need to know or care about them until the final
AST traversal for SQL construction. Rather than returning just the SQL,
the Arel collector will now return both the SQL and the bind parameters.
At this point the connection adapter will have all the values that it
had before.
A bit of this code is janky and something I'd like to refactor later. In
particular, I don't like how we're handling associations in the
predicate builder, the special casing of `StatementCache::Substitute` in
`QueryAttribute`, or generally how we're handling bind value replacement
in the statement cache when prepared statements are disabled.
This also mostly reverts #26378, as it moved all the code into a
location that I wanted to delete.
/cc @metaskills @yahonda, this change will affect the adapters
Fixes #29766.
Fixes #29804.
Fixes #26541.
Close #28539.
Close #24769.
Close #26468.
Close #26202.
There are probably other issues/PRs that can be closed because of this
commit, but that's all I could find on the first few pages.
|
|\ \
| | |
| | | |
Avoid modifying frozen string in check_schema_file
|
| | |
| | |
| | |
| | |
| | |
| | | |
This was missed when the frozen string literal pragma was added to this
file because the string is only modified when running in the context of
a full Rails app, which wasn't covered by the test suite.
|
|\ \ \
| | | |
| | | | |
Fix test failure in message verifier tests
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Without this, I get the following result on my machine
```
# Running:
F
Failure:
MessageVerifierTest#test_backward_compatibility_messages_signed_without_metadata [/home/deivid/Code/rails/activesupport/test/message_verifier_test.rb:91]:
--- expected
+++ actual
@@ -1 +1 @@
-{:some=>"data", :now=>2010-01-01 00:00:00 +0100}
+{:some=>"data", :now=>2010-01-01 00:00:00 +0000}
bin/test test/message_verifier_test.rb:89
```
|
|\ \ \ \
| |/ / /
|/| | | |
Add tests to MessageVerifier
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The paragraphs retread ground covered by the title and the usage examples,
so let's just remove them.
[ Assain Jaleel & Kasper Timm Hansen ]
|
|\ \ \
| | | |
| | | | |
Document metadata support for MessageEncryptor
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| |/ /
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| |_|/
|/| | |
Remove time stubs after each test
|
| | |
| | |
| | |
| | | |
Reverts 7abb6e0.
|
|\ \ \
| | | |
| | | | |
Use frozen string literal in actioncable/
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Make actionview ready for frozen strings
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Make actioncable ready for frozen strings
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Use frozen string literal in actionmailer/
|
|/ / / |
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
So releasing 5.1 and 5.0 together won't require manual copy
and paste.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Basically revises the release flow to:
* Update the version in RAILS_VERSION + rake changelog:header
* Run rake all:verify (click around in the booted app)
* If that checks out, run rake release.
|
|\ \ \ \
| | | | |
| | | | | |
Fix a failued AR test when using OracleAdapter
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
| |_|_|/
|/| | |
| | | |
| | | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
|\ \ \ \
| |_|/ /
|/| | | |
Sort enabled adapter extensions in schema dump
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The list of enabled adapter extensions in the schema dump isn't
sorted by default, so it may happen that the sorting changes
over time. If you're using a VCS, a change to the sorting results
in a diff without any real change. Sorting the list should solve
this problem.
|
|\ \ \ \
| | | | |
| | | | | |
Use `TRUE` and `FALSE` boolean literals for MySQL
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
Since #29699, abstract boolean serialization has been changed to use
`TRUE` and `FALSE` literals. MySQL also support the literals.
So we can use the abstract boolean serialization even for MySQL.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
y-yagi/use_argument_error_instead_of_own_error_class
Use `ArgumentError` instead of own error class
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
If the argument is invalid, I think that it is more intuitive to use
`ArgumentError` than its own error class.
|
|\ \ \ \
| | | | |
| | | | | |
Make `type_map` to private because it is only used in the connection adapter
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`type_map` is an internal API and it is only used in the connection
adapter. And also, some type map initializer methods requires passed
`type_map`, but those instances already has `type_map` in itself.
So we don't need explicit passing `type_map` to the initializers.
|
|\ \ \ \
| | | | |
| | | | | |
Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
|
| | | | |
| | | | |
| | | | |
| | | | | |
removed already
|
| | |/ /
| |/| |
| | | |
| | | | |
`ActionView::Helpers::RecordTagHelper`
|
|\ \ \ \
| | | | |
| | | | | |
Fix false positive test related to wrong app root path.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Without setting root config, `config.paths["config/secrets"]`
located in https://github.com/rails/rails/blob/84eb498f84ebc5d1be0b0db6f7bca9da3d679ca6/railties/lib/rails/application.rb#L390
always returned empty list.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Match destroyed_by_association for has_one to has_many
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When a has_many association is destroyed by `dependent: destroy`,
destroyed_by_association is set to the reflection, and this can be
checked in callbacks. This matches that behaviour for has_one
associations.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use frozen-string-literal in ActiveRecord
|