aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| | | * | | | Table needed for Rich Text AR modelDavid Heinemeier Hansson2018-05-281-0/+14
| | | | | | |
| | | * | | | Merge branch 'master' into separate-rich-text-recordDavid Heinemeier Hansson2018-05-280-0/+0
| | | |\ \ \ \ | | | |/ / / / | | |/| | | |
| | * | | | | Updated nameDavid Heinemeier Hansson2018-04-151-4/+4
| | | | | | |
| | | * | | | Use actiontext references in Gemfile.lockDavid Heinemeier Hansson2018-05-281-5/+5
| | | | | | |
| | | * | | | WIPDavid Heinemeier Hansson2018-04-132-7/+33
| | |/ / / /
| | * | | | Missed a spotDavid Heinemeier Hansson2018-04-131-1/+1
| | | | | |
| | * | | | Rename from Active Text to Action TextDavid Heinemeier Hansson2018-04-1327-69/+69
| | | | | | | | | | | | | | | | | | | | | | | | This is more like Action View than Active Model.
| | * | | | Content has already been through a whitelistDavid Heinemeier Hansson2018-04-131-1/+1
| | | | | |
| | * | | | Relieve the need for having to manually set a before_action in ↵David Heinemeier Hansson2018-04-131-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | ApplicationController
| | * | | | Use rich_text instead of active_textDavid Heinemeier Hansson2018-04-137-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | Just like we use has_many_attachments instead of active_storage_attachements.
| | * | | | Try to please semver theoryDavid Heinemeier Hansson2018-04-131-1/+1
| | | | | |
| | * | | | Missed a spotJavan Makhmali2018-02-141-1/+1
| | | | | |
| | * | | | Fix formattingJavan Makhmali2018-02-141-38/+38
| | | | | |
| | * | | | Add basic install guideJavan Makhmali2018-02-141-1/+56
| | | | | |
| | * | | | Remove unused modelJavan Makhmali2018-02-141-4/+0
| | | | | |
| | * | | | Isolated engines don't expose their helpers, so noJavan Makhmali2018-02-141-2/+0
| | | | | |
| | * | | | Extract AttachmentUploadJavan Makhmali2018-02-142-28/+50
| | | | | |
| | * | | | Move hard coded URLs to computed data attributesJavan Makhmali2018-02-142-13/+15
| | | | | |
| | * | | | Create ASt::Attachment records for ASt::Blobs in contentJavan Makhmali2018-02-141-0/+7
| | | | | |
| | * | | | Dummy: Use Trix stylesJavan Makhmali2018-02-142-4/+3
| | | | | |
| | * | | | Dummy: Add mini_magick for variantsJavan Makhmali2018-02-142-0/+3
| | | | | |
| | * | | | Dummy: Set ActiveText renderer for current requestJavan Makhmali2018-02-141-0/+6
| | | | | |
| | * | | | Make renderer configurableJavan Makhmali2018-02-144-2/+10
| | | | | |
| | * | | | Build out basic blob template to match the editor'sJavan Makhmali2018-02-141-5/+14
| | | | | |
| | * | | | Delegate Content#html_safe to #to_sSam Stephenson2018-02-132-2/+2
| | | | | |
| | * | | | Preserve the outer attachment element and fix editingSam Stephenson2018-02-132-6/+6
| | | | | |
| | * | | | Initial Attachment rendering supportJavan Makhmali2018-02-133-2/+13
| | | | | |
| | * | | | Add sgid supportJavan Makhmali2018-02-123-4/+57
| | | | | |
| | * | | | Add initial ActiveStorage integrationJavan Makhmali2018-02-126-2/+91
| | | | | |
| | * | | | Pull activetext.js into dummy app with webpackerJavan Makhmali2018-02-1224-33/+6247
| | | | | |
| | * | | | Extract BC3's rich_text_field helperJavan Makhmali2018-02-123-1/+55
| | | | | |
| | * | | | Tests: Add Message scaffoldingJavan Makhmali2018-02-0820-25/+277
| | | | | |
| | * | | | Add initial ActiveRecord extension: `active_text_attribute`Javan Makhmali2018-02-083-0/+18
| | | | | |
| | * | | | Add dummy appSam Stephenson2018-02-0874-74/+1021
| | | | | |
| | * | | | Initial import from BC3 RichTextSam Stephenson2018-02-0717-0/+663
| | | | | |
| | * | | | Initial commitSam Stephenson2018-02-0714-0/+237
| | / / /
* | / / / Support in-flight jobs stored before individual execution counters for ↵Rosa Gutierrez2019-01-053-21/+39
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `retry_on` (#34731) Also, make tests and examples for individual execution counters clearer, as it wasn't entierly clear what would happen in this case: ``` retry_on CustomException, OtherException, attempts: 3 ``` The job would be retried at most 3 times in total, for both CustomException and OtherException. To have the job retry 3 times at most for each exception individually, the following retry_on declarations are necessary: ``` retry_on CustomException, attempts: 3 retry_on OtherException, attempts: 3 ```
* | | | Merge pull request #34867 from bogdanvlviv/test-actionmailbox-configurationsGeorge Claghorn2019-01-041-0/+71
|\ \ \ \ | | | | | | | | | | Test Action Mailbox configurations
| * | | | Test Action Mailbox configurationsbogdanvlviv2019-01-041-0/+71
| |/ / / | | | | | | | | | | | | Related to https://github.com/rails/rails/commit/0d40c62213cf0be58a470637bd364e92c5666402
* | | | Merge pull request #34870 from ↵Kasper Timm Hansen2019-01-041-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | bogdanvlviv/fix-new_framework_defaults_6_0.rb-file Fix `new_framework_defaults_6_0.rb` file
| * | | | Fix `new_framework_defaults_6_0.rb` filebogdanvlviv2019-01-041-1/+1
| |/ / / | | | | | | | | | | | | | | | | `Rails.application.config.active_job.return_false_on_aborted_enqueue` should be commented as well.
* | | | Merge pull request #34866 from bogdanvlviv/add-activemodel_errors_of_kindRafael França2019-01-043-10/+113
|\ \ \ \ | | | | | | | | | | Add `ActiveModel::Errors#of_kind?`
| * | | | Add `ActiveModel::Errors#of_kind?`bogdanvlviv2019-01-043-10/+113
| | | | | | | | | | | | | | | | | | | | Related to https://github.com/rails/rails/pull/34817#issuecomment-451508668
* | | | | Merge pull request #34871 from bogdanvlviv/clarify-delegate_missing_toRyuta Kamizono2019-01-051-1/+1
|\ \ \ \ \ | |_|/ / / |/| | | | Clarify `delegate_missing_to` [ci skip]
| * | | | Clarify `delegate_missing_to` [ci skip]bogdanvlviv2019-01-041-1/+1
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since #34864 removed explicit receiver to clarify the purpose of `delegate_missing_to`, I think it will be better to do the same a few lines above to easier figure out that `delegate_missing_to` defines `method_missing`, `respond_to_missing?` when comparing these examples.
* | | | Send Active Storage jobs to dedicated queues by defaultGeorge Claghorn2019-01-045-2/+49
| | | | | | | | | | | | Match Action Mailbox, which sets a default queue for each of its two jobs.
* | | | Merge pull request #34864 from mikegee/patch-1Rafael França2019-01-041-1/+1
|\ \ \ \ | | | | | | | | | | Clarify benefit of `delegate_missing_to`
| * | | | Clarify benefit of `delegate_missing_to`Michael Gee2019-01-041-1/+1
|/ / / / | | | | | | | | Removing the explicit receiver clarifies the purpose of `delegate_missing_to`.
* | | | Merge pull request #34797 from ↵Eileen M. Uchitelle2019-01-045-5/+63
|\ \ \ \ | |/ / / |/| | | | | | | | | | | gsamokovarov/views-without-defined-protect-against-forgery Don't expect defined protect_against_forgery? in {token,csrf_meta}_tag
| * | | Don't expect defined protect_against_forgery? in {token,csrf_meta}_tagGenadi Samokovarov2018-12-275-5/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `#csrf_meta_tags` and `#token_tag` Action View helper methods are expecting the class in which are included to explicitly define the method `#protect_against_forgery?` or else they will fail with `NoMethodError`. This is a problem if you want to use Action View outside of Rails applications. For example, in #34788 I used the `#button_to` helper inside of the error pages templates that have a custom `ActionView::Base` subclass, which did not defined `#protect_against_forgery?` and trying to call the button failed. I had to dig inside of Action View to find-out what's was going on. I think we should either set a default method implementation in the helpers or check for the method definition, but don't explicitly require the presence of `#protect_against_forgery?` in every `ActionViews::Base` subclass as the errors are hard to figure out.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 03:39:06 +0000