aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | Create action_cable_overview.md resolves #23176 [ci skip]David Kuhta2016-02-141-0/+659
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails Guide for Action Cable Added content from README Pull additional information from Action Cable README and restructured Client/Server elements Update to list numbering Switched from list numbers to headings in the examples Change AppearancesChannel to AppearanceChannel Word missing fixed missing word. Removed Mistaken nesting of Channel class Removed nesting of ChatChannel and AppearanceChannel from within ApplicationChannel Module. (Copy&Paste error) Incorporated first round of comments 1. Capitalize "action cable" 2. Separated "Consumers require... via JavaScript" into two sentences 3. Minor typographical correction (remember...) 4. Extra backtick 5. Revised text which implied Redis was the exclusive storage adapter to reflect it's position as default. 6. Revised reference to denote correct config file location: config/cable.yml 7. Added adapter: redis to environment configuration blocks 8. Capitalized "R" for "Rack" 9. Revised syntax for routing to reflect the hash syntax. (to: NOT :to =>) 10. Removed reference to Action Cable being separate from Rails. 11. Began revision for adapter API [I believe this requires a reformatting of the 'Redis' portion of the configuration section to simply "Storage Adapters"] 12. Celluloid -> Concurrent-ruby Moved errant grave mark [ci skip] Reordered "In App" above "Standalone" [ci skip] Reordered to reflect "In App" as preferable to "Standalone" Action Cable Deployment [ci skip] Removed paragraph that alludes to Action Cable not being able to run in the same process as Rails. Removed EM reference and updated deployment [ci skip] Removed explicit multi-threaded server dependency reference [ci skip] Revised Configuration and fixed typos [ci skip] Switched Lifecycle Graphic for Detailed Description [ci skip] Switched from Lifecycle graphic to detailed description to facilitate revision and maintainability in the future. Capitalized Heading (typo) [ci skip] Implemented merged commits from README [ci skip] Pulled over all (or at least I believe all) merged commits from README. (Dec 14, 2015 - Feb 11, 2016) Editorial - Capitalize WebSockets [ci skip] Reformated lines to ~75 characters [ci skip]
* | | | | | | Merge pull request #23811 from iamvery/string-channelDavid Heinemeier Hansson2016-02-285-1/+37
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Ensure actioncable behaves as expected with non-string queues
| * | | | | | Update changelogJay Hayes2016-02-241-0/+4
| | | | | | |
| * | | | | | Ensure server broadcasts are to string queue namesJay Hayes2016-02-242-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to the channel streaming side, these values must be strings for ActionCable to behave as expected. The conversion will allow users to send string-convertible values and get the expected behavior.
| * | | | | | Convert stream broadcasting to a stringJay Hayes2016-02-242-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActionCable does some things behind the scenes that expects these "broadcasting"s or "channel"s to be strings. However it's not immediately obvious that the value must be a string. So adding this conversion ensures things work as expected.
| * | | | | | whitespaceJay Hayes2016-02-241-1/+0
| | | | | | |
* | | | | | | Merge pull request #23937 from y-yagi/use_app_updateArun Agrawal2016-02-281-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | use `app:update` instead of deprecated `rails:update` [ci skip]
| * | | | | | | use `app:update` instead of deprecated `rails:update` [ci skip]yuuji.yaginuma2016-02-281-2/+2
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | `rails:update` was deprecated in 6fb31638c8b61731103d4963272755b217a2df87
* | | | | | | Merge pull request #23933 from HayleyCAnderson/ha-action-cable-docs-fixesJon Moss2016-02-275-15/+15
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [ci skip] Add small Action Cable documentation fixes
| * | | | | | | Add small Action Cable documentation fixesHayley Anderson2016-02-275-15/+15
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | * Fix typos/grammar errors * Make capitalization/naming consistent
* | | | | | | Update docs to point to new update task.Arthur Neves2016-02-271-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This guides were pointing to this command `rails app:update`, which I tried to run, but it didnt worked. I think the right command is `rails rails:update` instead. Also thats the name of the rake task. Also I removed the `Rake` word from the title, as we run it using `rails` bin now. cc @kaspth [skip ci]
* | | | | | | Merge pull request #23921 from y-yagi/remove_rack_cors_initializer_when_updatingArthur Nogueira Neves2016-02-272-0/+31
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | remove rack cors initializer when updating
| * | | | | | remove rack cors initializer when updatingyuuji.yaginuma2016-02-272-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rack cors initializer is only necessary to API-only applications, for when the update is unnecessary.
* | | | | | | Fix test name typo prescence -> presenceeileencodes2016-02-271-1/+1
| | | | | | |
* | | | | | | Merge pull request #23439 from ryohashimoto/160203_rake_railsKasper Timm Hansen2016-02-277-10/+29
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Use app namespace for framework tasks
| * | | | | | | The tasks in the rails task namespace is deprecated in favor of app namespace.Ryo Hashimoto2016-02-267-10/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
* | | | | | | | Merge pull request #23926 from kuldeepaggarwal/fix-docsप्रथमेश Sonpatki2016-02-271-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | [ci skip]Add info for specifying logger in different envrionments.
| * | | | | | | | [ci skip]Add info for specifying logger in different envrionments.Kuldeep Aggarwal2016-02-271-1/+1
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | refer 2dc3e81aea8dbc, 56ca2061df83a3
* | | | | | | | :scissors:Rafael Mendonça França2016-02-261-2/+2
| | | | | | | |
* | | | | | | | Merge pull request #23917 from chashmeetsingh/patch-1Rafael Mendonça França2016-02-261-1/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Create tmp folder if not present
| * | | | | | | | Create tmp folder if not presentChashmeet Singh2016-02-271-1/+3
| | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All Apps may not have a tmp folder Update dev.rake Update dev.rake Update dev.rake Update dev.rake Update dev.rake Update dev.rake Update dev.rake
* | | | | | | | Merge pull request #23920 from ianks/masterRafael França2016-02-261-1/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Specify plaform: :mri for byebug
| * | | | | | | Specify plaform: :mri for byebugIan Ker-Seymer2016-02-261-1/+1
|/ / / / / / /
* | | | | | | Merge pull request #23915 from sikachu/pr-23710-updateRafael França2016-02-263-3/+30
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start
| * | | | | | | Add CHANGELOG entry for "Rendering ..." loggingPrem Sichanugrist2016-02-261-0/+6
| | | | | | | |
| * | | | | | | Update to use Subscriber#start insteadPrem Sichanugrist2016-02-262-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't need to instrument another event as `ActiveSupport::LogSubscriber` already tracks when the instrumentation starts. Close #23717
| * | | | | | | Added log "Rendering ...", when starting to render a template, to log that ↵Vipul A M2016-02-263-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we have started to render something, at the very beginning. This helps to easily identify queries from controller vs views Fixes #23710
* | | | | | | | Merge pull request #23916 from ↵Jeremy Daer2016-02-261-2/+6
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | lifo/same-redis-connection-for-subscription-and-broadcast Always use redis_connector to create redis connections
| * | | | | | | Use redis_connector to create redis connections for both subscriptions and ↵Pratik Naik2016-02-261-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | broadcasts
* | | | | | | | Merge pull request #23906 from schneems/schneems/puma-3-0Richard Schneeman2016-02-262-1/+6
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | [close #23681] Use puma 3.0.0+
| * | | | | | | [close #23681] Use puma 3.0.0+ schneems2016-02-262-1/+6
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
* | | | | | | Merge pull request #23902 from prajakta-tambe/update-debuggings-rails-app-docप्रथमेश Sonpatki2016-02-261-5/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Changed debugging rails app doc.
| * | | | | | | - Changed Debugging Rails Applications doc's logger introduction section. ↵prajakta2016-02-261-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed location for specifying logger. [Prajakta, thiagoaugusto]
* | | | | | | | Merge pull request #23899 from y-yagi/fix_typo_in_pull_request_templateप्रथमेश Sonpatki2016-02-261-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | fix typo in pull_request_template [ci skip]
| * | | | | | | | fix typo in pull_request_template [ci skip]yuuji.yaginuma2016-02-261-1/+1
|/ / / / / / / /
* | | | | | | | :nail_care:Arthur Nogueira Neves2016-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | [skip ci]
* | | | | | | | The async.callback call should live with the hijackMatthew Draper2016-02-261-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we're deferring one, we should defer the other too.
* | | | | | | | Merge pull request #23738 from maclover7/issue-templateRafael França2016-02-252-0/+33
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add `issue_template.md`
| * | | | | | | | Add `issue_template.md` and `pull_request_template.md`Jon Moss2016-02-182-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This appears to be a new feature of GitHub. See these links for more details: - https://github.com/dear-github/dear-github/issues/125 - https://github.com/owncloud/core/issues/new - https://github.com/blog/2111-issue-and-pull-request-templates [ci skip]
* | | | | | | | | :nail_care:Rafael Mendonça França2016-02-251-2/+2
| | | | | | | | |
* | | | | | | | | Merge pull request #23852 from prathamesh-sonpatki/hsts-subdomainsRafael França2016-02-256-8/+69
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Enable HSTS with IncludeSubdomains header by default for new apps
| * | | | | | | | | Update documentation and deprecation messagePrathamesh Sonpatki2016-02-251-3/+3
| | | | | | | | | |
| * | | | | | | | | Add CHANGELOG entryPrathamesh Sonpatki2016-02-251-0/+4
| | | | | | | | | |
| * | | | | | | | | Added deprecation for older appsPrathamesh Sonpatki2016-02-252-8/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - For old apps which are not setting any value for hsts[:subdomains], a deprecation warning will be shown saying that hsts[:subdomains] will be turned on by default in Rails 5.1. Currently it will be set to false for backward compatibility. - Adjusted tests to reflect this change.
| * | | | | | | | | Old applications will not get the ssl_options initializerPrathamesh Sonpatki2016-02-252-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - We will remove the initializer for old apps which are migrated to Rails 5 so that they are not affected by this breaking change.
| * | | | | | | | | New applications will be generated with ssl_options to enable HSTS with ↵Prathamesh Sonpatki2016-02-251-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | subdomains - We will reuse config.ssl_options for setting the HSTS settings.
| * | | | | | | | | HSTS without IncludeSubdomains is often uselessEgor Homakov2016-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1) Because if you forget to add Secure; to the session cookie, it will leak to http:// subdomain in some cases 2) Because http:// subdomain can Cookie Bomb/cookie force main domain or be used for phishing. That's why *by default* it must include subdomains as it's much more common scenario. Very few websites *intend* to leave their blog.app.com working over http:// while having everything else encrypted. Yes, many developers forget to add subdomains=true by default, believe me :)
* | | | | | | | | | Merge pull request #23846 from ↵Rafael França2016-02-253-11/+31
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | y-yagi/correctly_check_ApplicationRecord_in_mountable_engine correctly check `ApplicationRecord` is exist in moutable engine
| * | | | | | | | | | correctly check `ApplicationRecord` is exist in moutable engineyuuji.yaginuma2016-02-253-11/+31
| | |_|_|_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 1813b29fc7632959800252f36e4b2e6ed4ac7266
* | | | | | | | | | Merge pull request #23887 from ↵Matthew Draper2016-02-262-1/+19
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jrafanie/fix_uniqueness_validation_on_after_create Fix uniqueness validation with an after_create hook.