| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Rails Guide for Action Cable
Added content from README
Pull additional information from Action Cable README and restructured Client/Server elements
Update to list numbering
Switched from list numbers to headings in the examples
Change AppearancesChannel to AppearanceChannel
Word missing
fixed missing word.
Removed Mistaken nesting of Channel class
Removed nesting of ChatChannel and AppearanceChannel from within ApplicationChannel Module. (Copy&Paste error)
Incorporated first round of comments
1. Capitalize "action cable"
2. Separated "Consumers require... via JavaScript" into two sentences
3. Minor typographical correction (remember...)
4. Extra backtick
5. Revised text which implied Redis was the exclusive storage adapter to reflect it's position as default.
6. Revised reference to denote correct config file location: config/cable.yml
7. Added adapter: redis to environment configuration blocks
8. Capitalized "R" for "Rack"
9. Revised syntax for routing to reflect the hash syntax. (to: NOT :to =>)
10. Removed reference to Action Cable being separate from Rails.
11. Began revision for adapter API [I believe this requires a reformatting of the 'Redis' portion of the configuration section to simply "Storage Adapters"]
12. Celluloid -> Concurrent-ruby
Moved errant grave mark [ci skip]
Reordered "In App" above "Standalone" [ci skip]
Reordered to reflect "In App" as preferable to "Standalone"
Action Cable Deployment [ci skip]
Removed paragraph that alludes to Action Cable not being able to run in the same process as Rails.
Removed EM reference and updated deployment [ci skip]
Removed explicit multi-threaded server dependency reference [ci skip]
Revised Configuration and fixed typos [ci skip]
Switched Lifecycle Graphic for Detailed Description [ci skip]
Switched from Lifecycle graphic to detailed description to facilitate revision and maintainability in the future.
Capitalized Heading (typo) [ci skip]
Implemented merged commits from README [ci skip]
Pulled over all (or at least I believe all) merged commits from README. (Dec 14, 2015 - Feb 11, 2016)
Editorial - Capitalize WebSockets [ci skip]
Reformated lines to ~75 characters [ci skip]
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Ensure actioncable behaves as expected with non-string queues
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Similar to the channel streaming side, these values must be strings for
ActionCable to behave as expected. The conversion will allow users to
send string-convertible values and get the expected behavior.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
ActionCable does some things behind the scenes that expects these
"broadcasting"s or "channel"s to be strings. However it's not
immediately obvious that the value must be a string. So adding this
conversion ensures things work as expected.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
use `app:update` instead of deprecated `rails:update` [ci skip]
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
`rails:update` was deprecated in 6fb31638c8b61731103d4963272755b217a2df87
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ci skip] Add small Action Cable documentation fixes
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* Fix typos/grammar errors
* Make capitalization/naming consistent
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This guides were pointing to this command `rails app:update`, which I
tried to run, but it didnt worked. I think the right command is `rails
rails:update` instead. Also thats the name of the rake task.
Also I removed the `Rake` word from the title, as we run it using
`rails` bin now.
cc @kaspth
[skip ci]
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
remove rack cors initializer when updating
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Rack cors initializer is only necessary to API-only applications, for when the update is unnecessary.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Use app namespace for framework tasks
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
(e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
[ci skip]Add info for specifying logger in different envrionments.
|
|/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | | |
refer 2dc3e81aea8dbc, 56ca2061df83a3
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Create tmp folder if not present
|
| | |/ / / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
All Apps may not have a tmp folder
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
Update dev.rake
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Specify plaform: :mri for byebug
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
We don't need to instrument another event as
`ActiveSupport::LogSubscriber` already tracks when the instrumentation
starts.
Close #23717
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
we have started to render something, at the very beginning.
This helps to easily identify queries from controller vs views
Fixes #23710
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
lifo/same-redis-connection-for-subscription-and-broadcast
Always use redis_connector to create redis connections
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
broadcasts
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
[close #23681] Use puma 3.0.0+
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Changed debugging rails app doc.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Changed location for specifying logger.
[Prajakta, thiagoaugusto]
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
fix typo in pull_request_template [ci skip]
|
|/ / / / / / / / |
|
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[skip ci]
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
If we're deferring one, we should defer the other too.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Add `issue_template.md`
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This appears to be a new feature of GitHub.
See these links for more details:
- https://github.com/dear-github/dear-github/issues/125
- https://github.com/owncloud/core/issues/new
- https://github.com/blog/2111-issue-and-pull-request-templates
[ci skip]
|
| | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | | |
Enable HSTS with IncludeSubdomains header by default for new apps
|
| | | | | | | | | | |
|
| | | | | | | | | | |
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
- For old apps which are not setting any value for hsts[:subdomains],
a deprecation warning will be shown saying that hsts[:subdomains] will
be turned on by default in Rails 5.1. Currently it will be set to
false for backward compatibility.
- Adjusted tests to reflect this change.
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
- We will remove the initializer for old apps which are migrated to
Rails 5 so that they are not affected by this breaking change.
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
subdomains
- We will reuse config.ssl_options for setting the HSTS settings.
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
1) Because if you forget to add Secure; to the session cookie, it will leak to http:// subdomain in some cases
2) Because http:// subdomain can Cookie Bomb/cookie force main domain or be used for phishing.
That's why *by default* it must include subdomains as it's much more common scenario. Very few websites *intend* to leave their blog.app.com working over http:// while having everything else encrypted.
Yes, many developers forget to add subdomains=true by default, believe me :)
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
y-yagi/correctly_check_ApplicationRecord_in_mountable_engine
correctly check `ApplicationRecord` is exist in moutable engine
|
| | |_|_|_|_|_|_|/ /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Follow up to 1813b29fc7632959800252f36e4b2e6ed4ac7266
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
jrafanie/fix_uniqueness_validation_on_after_create
Fix uniqueness validation with an after_create hook.
|